From e48a3d7a76f446f3f88e38a5ac96f5a6f7c74d77 Mon Sep 17 00:00:00 2001 From: markchien Date: Wed, 3 Jun 2020 23:08:10 +0800 Subject: [PATCH] Remove isProvisioningNeededButUnavailable usage config_mobile_hotspot_provision_app would be move out of framework and only private for tethering only. TetherUtil#isProvisioningNeeded and isProvisioningNeededButUnavailable are no longer needed because tethering would ensure entitlement app is valid if entitlement check is needed. Otherwise, tethering would return not supported that tethering settings would be hidden. Bug: 146918263 Test: m Change-Id: If0b0a3e6cadab3c4a4d2c003e2aa9e9f3dd7449c Merged-In: If0b0a3e6cadab3c4a4d2c003e2aa9e9f3dd7449c --- src/com/android/settings/TetherSettings.java | 20 ------------------- .../network/TetherPreferenceController.java | 4 ---- 2 files changed, 24 deletions(-) diff --git a/src/com/android/settings/TetherSettings.java b/src/com/android/settings/TetherSettings.java index 26cd9221b01..23f2b28bf40 100644 --- a/src/com/android/settings/TetherSettings.java +++ b/src/com/android/settings/TetherSettings.java @@ -29,7 +29,6 @@ import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; import android.content.IntentFilter; -import android.content.pm.PackageManager; import android.hardware.usb.UsbManager; import android.net.ConnectivityManager; import android.net.EthernetManager; @@ -433,25 +432,6 @@ public class TetherSettings extends RestrictedSettingsFragment } } - public static boolean isProvisioningNeededButUnavailable(Context context) { - return (TetherUtil.isProvisioningNeeded(context) - && !isIntentAvailable(context)); - } - - private static boolean isIntentAvailable(Context context) { - String[] provisionApp = context.getResources().getStringArray( - com.android.internal.R.array.config_mobile_hotspot_provision_app); - if (provisionApp.length < 2) { - return false; - } - final PackageManager packageManager = context.getPackageManager(); - Intent intent = new Intent(Intent.ACTION_MAIN); - intent.setClassName(provisionApp[0], provisionApp[1]); - - return (packageManager.queryIntentActivities(intent, - PackageManager.MATCH_DEFAULT_ONLY).size() > 0); - } - private void startTethering(int choice) { if (choice == TETHERING_BLUETOOTH) { // Turn on Bluetooth first. diff --git a/src/com/android/settings/network/TetherPreferenceController.java b/src/com/android/settings/network/TetherPreferenceController.java index 0d4a6a6189c..8ed4f89236d 100644 --- a/src/com/android/settings/network/TetherPreferenceController.java +++ b/src/com/android/settings/network/TetherPreferenceController.java @@ -39,7 +39,6 @@ import androidx.preference.Preference; import androidx.preference.PreferenceScreen; import com.android.settings.R; -import com.android.settings.TetherSettings; import com.android.settings.core.PreferenceControllerMixin; import com.android.settingslib.TetherUtil; import com.android.settingslib.core.AbstractPreferenceController; @@ -106,9 +105,6 @@ public class TetherPreferenceController extends AbstractPreferenceController imp if (mPreference != null && !mAdminDisallowedTetherConfig) { mPreference.setTitle( com.android.settingslib.Utils.getTetheringLabel(mConnectivityManager)); - - // Grey out if provisioning is not available. - mPreference.setEnabled(!TetherSettings.isProvisioningNeededButUnavailable(mContext)); } }