From e4673a3dc835e8081b842620ff802186968b02ba Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Tue, 17 May 2022 10:41:21 +0800 Subject: [PATCH] Center apps Preference title when there is no summary Hide apps Preference summary when a summary is empty then its title will be vertically centered. Bug: 229646669 Test: manual visual Settings -> Apps -> See all apps Settings -> Notifications -> App settings Settings -> Storage -> Apps Settings -> System -> Language & input -> App Languages Change-Id: I6fceba243e2ccac9ea180b940b571da07e1ba805 --- .../manageapplications/ApplicationViewHolder.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/com/android/settings/applications/manageapplications/ApplicationViewHolder.java b/src/com/android/settings/applications/manageapplications/ApplicationViewHolder.java index ef5b029a9d0..e1db417dd46 100644 --- a/src/com/android/settings/applications/manageapplications/ApplicationViewHolder.java +++ b/src/com/android/settings/applications/manageapplications/ApplicationViewHolder.java @@ -87,10 +87,17 @@ public class ApplicationViewHolder extends RecyclerView.ViewHolder { void setSummary(CharSequence summary) { mSummary.setText(summary); + updateSummaryVisibility(); } void setSummary(@StringRes int summary) { mSummary.setText(summary); + updateSummaryVisibility(); + } + + private void updateSummaryVisibility() { + // Hide an empty summary and then title will be vertically centered. + mSummary.setVisibility(TextUtils.isEmpty(mSummary.getText()) ? View.GONE : View.VISIBLE); } void setEnabled(boolean isEnabled) {