PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NPE in constructor

Browse Source 
Move getActivity() call and fetching of metrics feature provider into
onCreateView rathre than the Constructor of the fragment (where Activity
is not yet created).

Test: manual
Test: existing robotests
Fixes: 128808444
Change-Id: I88586b0ca3ebda60f8933041322541cc5911de68
This commit is contained in:
Matthew Fritze
2019-03-19 16:28:33 -07:00
parent 23924cf3f4
commit e435b062a0
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/panel/PanelFragment.java
View File

@@ -48,16 +48,11 @@ public class PanelFragment extends Fragment {
private RecyclerView mPanelSlices; private RecyclerView mPanelSlices;
private PanelContent mPanel; private PanelContent mPanel;
private final MetricsFeatureProvider mMetricsProvider; private MetricsFeatureProvider mMetricsProvider;
@VisibleForTesting @VisibleForTesting
PanelSlicesAdapter mAdapter; PanelSlicesAdapter mAdapter;
public PanelFragment() {
final Context context = getActivity();
mMetricsProvider = FeatureFactory.getFactory(context).getMetricsFeatureProvider();
}
@Nullable @Nullable
@Override @Override
public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
@@ -83,6 +78,7 @@ public class PanelFragment extends Fragment {
.getPanelFeatureProvider() .getPanelFeatureProvider()
.getPanel(activity, panelType, mediaPackageName); .getPanel(activity, panelType, mediaPackageName);
mMetricsProvider = FeatureFactory.getFactory(activity).getMetricsFeatureProvider();
// Log panel opened. // Log panel opened.
mMetricsProvider.action( mMetricsProvider.action(
0 /* attribution */, 0 /* attribution */,