Add 'Restore' button to AppInfo screen
Test: AppButtonsTest, AppRestoreButtonTest Bug: 304255818 Change-Id: Ica9055d8ee5603e4bb682e9b5d90a225c839002a
This commit is contained in:
@@ -138,6 +138,7 @@
|
|||||||
<uses-permission android:name="android.permission.CUSTOMIZE_SYSTEM_UI" />
|
<uses-permission android:name="android.permission.CUSTOMIZE_SYSTEM_UI" />
|
||||||
<uses-permission android:name="android.permission.REMAP_MODIFIER_KEYS" />
|
<uses-permission android:name="android.permission.REMAP_MODIFIER_KEYS" />
|
||||||
<uses-permission android:name="android.permission.ACCESS_GPU_SERVICE" />
|
<uses-permission android:name="android.permission.ACCESS_GPU_SERVICE" />
|
||||||
|
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
|
||||||
|
|
||||||
<application
|
<application
|
||||||
android:name=".SettingsApplication"
|
android:name=".SettingsApplication"
|
||||||
|
@@ -3898,6 +3898,8 @@
|
|||||||
<string name="force_stop">Force stop</string>
|
<string name="force_stop">Force stop</string>
|
||||||
<!-- Manage applications, text label for button to archive an application. Archiving means uninstalling the app without deleting user's personal data and replacing the app with a stub app with minimum size. So, the user can unarchive the app later and not lose any personal data. -->
|
<!-- Manage applications, text label for button to archive an application. Archiving means uninstalling the app without deleting user's personal data and replacing the app with a stub app with minimum size. So, the user can unarchive the app later and not lose any personal data. -->
|
||||||
<string name="archive">Archive</string>
|
<string name="archive">Archive</string>
|
||||||
|
<!-- Manage applications, text label for button to restore an application. Restoring means installing the archived app. -->
|
||||||
|
<string name="restore">Restore</string>
|
||||||
<!-- Manage applications, individual application info screen,label under Storage heading. The total storage space taken up by this app. -->
|
<!-- Manage applications, individual application info screen,label under Storage heading. The total storage space taken up by this app. -->
|
||||||
<string name="total_size_label">Total</string>
|
<string name="total_size_label">Total</string>
|
||||||
<!-- Manage applications, individual application info screen, label under Storage heading. The amount of space taken up by the application itself (for example, the java compield files and things like that) -->
|
<!-- Manage applications, individual application info screen, label under Storage heading. The amount of space taken up by the application itself (for example, the java compield files and things like that) -->
|
||||||
@@ -4012,6 +4014,12 @@
|
|||||||
<string name="archiving_failed">Archiving failed</string>
|
<string name="archiving_failed">Archiving failed</string>
|
||||||
<!-- Toast message when archiving an app succeeded. -->
|
<!-- Toast message when archiving an app succeeded. -->
|
||||||
<string name="archiving_succeeded">Archived <xliff:g id="package_label" example="Translate">%1$s</xliff:g></string>
|
<string name="archiving_succeeded">Archived <xliff:g id="package_label" example="Translate">%1$s</xliff:g></string>
|
||||||
|
<!-- Toast message when restoring an app failed. -->
|
||||||
|
<string name="restoring_failed">Restoring failed</string>
|
||||||
|
<!-- Toast message when restoring an app succeeded. -->
|
||||||
|
<string name="restoring_succeeded">Restored <xliff:g id="package_label" example="Translate">%1$s</xliff:g></string>
|
||||||
|
<!-- Toast message when restoring an app has started. -->
|
||||||
|
<string name="restoring_in_progress">Restoring <xliff:g id="package_label" example="Translate">%1$s</xliff:g></string>
|
||||||
|
|
||||||
<!-- Text of pop up message if the request for a "migrate primary storage" operation
|
<!-- Text of pop up message if the request for a "migrate primary storage" operation
|
||||||
(see storage_menu_migrate) is denied as another is already in progress. [CHAR LIMIT=75] -->
|
(see storage_menu_migrate) is denied as another is already in progress. [CHAR LIMIT=75] -->
|
||||||
|
@@ -53,6 +53,7 @@ private class AppButtonsPresenter(
|
|||||||
private val appClearButton = AppClearButton(packageInfoPresenter)
|
private val appClearButton = AppClearButton(packageInfoPresenter)
|
||||||
private val appForceStopButton = AppForceStopButton(packageInfoPresenter)
|
private val appForceStopButton = AppForceStopButton(packageInfoPresenter)
|
||||||
private val appArchiveButton = AppArchiveButton(packageInfoPresenter)
|
private val appArchiveButton = AppArchiveButton(packageInfoPresenter)
|
||||||
|
private val appRestoreButton = AppRestoreButton(packageInfoPresenter)
|
||||||
|
|
||||||
@Composable
|
@Composable
|
||||||
fun getActionButtons() =
|
fun getActionButtons() =
|
||||||
@@ -63,7 +64,11 @@ private class AppButtonsPresenter(
|
|||||||
@Composable
|
@Composable
|
||||||
private fun getActionButtons(app: ApplicationInfo): List<ActionButton> = listOfNotNull(
|
private fun getActionButtons(app: ApplicationInfo): List<ActionButton> = listOfNotNull(
|
||||||
if (featureFlags.archiving()) {
|
if (featureFlags.archiving()) {
|
||||||
appArchiveButton.getActionButton(app)
|
if (app.isArchived) {
|
||||||
|
appRestoreButton.getActionButton(app)
|
||||||
|
} else {
|
||||||
|
appArchiveButton.getActionButton(app)
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
appLaunchButton.getActionButton(app)
|
appLaunchButton.getActionButton(app)
|
||||||
},
|
},
|
||||||
|
135
src/com/android/settings/spa/app/appinfo/AppRestoreButton.kt
Normal file
135
src/com/android/settings/spa/app/appinfo/AppRestoreButton.kt
Normal file
@@ -0,0 +1,135 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2023 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.spa.app.appinfo
|
||||||
|
|
||||||
|
import android.app.PendingIntent
|
||||||
|
import android.content.Intent
|
||||||
|
import android.content.IntentFilter
|
||||||
|
import android.content.pm.ApplicationInfo
|
||||||
|
import android.content.pm.PackageInstaller
|
||||||
|
import android.os.UserHandle
|
||||||
|
import android.util.Log
|
||||||
|
import android.widget.Toast
|
||||||
|
import androidx.compose.material.icons.Icons
|
||||||
|
import androidx.compose.material.icons.outlined.CloudDownload
|
||||||
|
import androidx.compose.runtime.Composable
|
||||||
|
import com.android.settings.R
|
||||||
|
import com.android.settingslib.spa.widget.button.ActionButton
|
||||||
|
import com.android.settingslib.spaprivileged.framework.compose.DisposableBroadcastReceiverAsUser
|
||||||
|
|
||||||
|
class AppRestoreButton(packageInfoPresenter: PackageInfoPresenter) {
|
||||||
|
private companion object {
|
||||||
|
private const val LOG_TAG = "AppRestoreButton"
|
||||||
|
private const val INTENT_ACTION = "com.android.settings.unarchive.action"
|
||||||
|
}
|
||||||
|
|
||||||
|
private val context = packageInfoPresenter.context
|
||||||
|
private val userPackageManager = packageInfoPresenter.userPackageManager
|
||||||
|
private val packageInstaller = userPackageManager.packageInstaller
|
||||||
|
private val packageName = packageInfoPresenter.packageName
|
||||||
|
private val userHandle = UserHandle.of(packageInfoPresenter.userId)
|
||||||
|
private var broadcastReceiverIsCreated = false
|
||||||
|
|
||||||
|
@Composable
|
||||||
|
fun getActionButton(app: ApplicationInfo): ActionButton {
|
||||||
|
if (!broadcastReceiverIsCreated) {
|
||||||
|
val intentFilter = IntentFilter(INTENT_ACTION)
|
||||||
|
DisposableBroadcastReceiverAsUser(intentFilter, userHandle) { intent ->
|
||||||
|
if (app.packageName == intent.getStringExtra(PackageInstaller.EXTRA_PACKAGE_NAME)) {
|
||||||
|
onReceive(intent, app)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
broadcastReceiverIsCreated = true
|
||||||
|
}
|
||||||
|
return ActionButton(
|
||||||
|
text = context.getString(R.string.restore),
|
||||||
|
imageVector = Icons.Outlined.CloudDownload,
|
||||||
|
enabled = app.isArchived
|
||||||
|
) { onRestoreClicked(app) }
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun onRestoreClicked(app: ApplicationInfo) {
|
||||||
|
val intent = Intent(INTENT_ACTION)
|
||||||
|
intent.setPackage(context.packageName)
|
||||||
|
val pendingIntent = PendingIntent.getBroadcastAsUser(
|
||||||
|
context, 0, intent,
|
||||||
|
// FLAG_MUTABLE is required by PackageInstaller#requestUnarchive
|
||||||
|
PendingIntent.FLAG_ONE_SHOT or PendingIntent.FLAG_MUTABLE,
|
||||||
|
userHandle
|
||||||
|
)
|
||||||
|
try {
|
||||||
|
packageInstaller.requestUnarchive(app.packageName, pendingIntent.intentSender)
|
||||||
|
val appLabel = userPackageManager.getApplicationLabel(app)
|
||||||
|
Toast.makeText(
|
||||||
|
context,
|
||||||
|
context.getString(R.string.restoring_in_progress, appLabel),
|
||||||
|
Toast.LENGTH_SHORT
|
||||||
|
).show()
|
||||||
|
} catch (e: Exception) {
|
||||||
|
Log.e(LOG_TAG, "Request unarchive failed", e)
|
||||||
|
Toast.makeText(
|
||||||
|
context,
|
||||||
|
context.getString(R.string.restoring_failed),
|
||||||
|
Toast.LENGTH_SHORT
|
||||||
|
).show()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun onReceive(intent: Intent, app: ApplicationInfo) {
|
||||||
|
when (val unarchiveStatus =
|
||||||
|
intent.getIntExtra(PackageInstaller.EXTRA_UNARCHIVE_STATUS, Int.MIN_VALUE)) {
|
||||||
|
PackageInstaller.STATUS_PENDING_USER_ACTION -> {
|
||||||
|
Log.e(
|
||||||
|
LOG_TAG,
|
||||||
|
"Request unarchiving failed for $packageName with code $unarchiveStatus"
|
||||||
|
)
|
||||||
|
Toast.makeText(
|
||||||
|
context,
|
||||||
|
context.getString(R.string.restoring_failed),
|
||||||
|
Toast.LENGTH_SHORT
|
||||||
|
).show()
|
||||||
|
}
|
||||||
|
|
||||||
|
PackageInstaller.STATUS_SUCCESS -> {
|
||||||
|
val appLabel = userPackageManager.getApplicationLabel(app)
|
||||||
|
Toast.makeText(
|
||||||
|
context,
|
||||||
|
context.getString(R.string.restoring_succeeded, appLabel),
|
||||||
|
Toast.LENGTH_SHORT
|
||||||
|
).show()
|
||||||
|
}
|
||||||
|
|
||||||
|
else -> {
|
||||||
|
Log.e(
|
||||||
|
LOG_TAG,
|
||||||
|
"Request unarchiving failed for $packageName with code $unarchiveStatus"
|
||||||
|
)
|
||||||
|
val errorDialogIntent =
|
||||||
|
intent.getParcelableExtra(Intent.EXTRA_INTENT, Intent::class.java)
|
||||||
|
if (errorDialogIntent != null) {
|
||||||
|
context.startActivityAsUser(errorDialogIntent, userHandle)
|
||||||
|
} else {
|
||||||
|
Toast.makeText(
|
||||||
|
context,
|
||||||
|
context.getString(R.string.restoring_failed),
|
||||||
|
Toast.LENGTH_SHORT
|
||||||
|
).show()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
@@ -140,6 +140,38 @@ class AppButtonsTest {
|
|||||||
composeTestRule.onNodeWithText(context.getString(R.string.uninstall_text)).assertIsEnabled()
|
composeTestRule.onNodeWithText(context.getString(R.string.uninstall_text)).assertIsEnabled()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun archiveButton_displayed_whenAppIsNotArchived() {
|
||||||
|
featureFlags.setFlag(Flags.FLAG_ARCHIVING, true)
|
||||||
|
val packageInfo = PackageInfo().apply {
|
||||||
|
applicationInfo = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = false
|
||||||
|
}
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
}
|
||||||
|
setContent(packageInfo)
|
||||||
|
|
||||||
|
composeTestRule.onNodeWithText(context.getString(R.string.archive)).assertIsDisplayed()
|
||||||
|
composeTestRule.onNodeWithText(context.getString(R.string.restore)).assertIsNotDisplayed()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun restoreButton_displayed_whenAppIsArchived() {
|
||||||
|
featureFlags.setFlag(Flags.FLAG_ARCHIVING, true)
|
||||||
|
val packageInfo = PackageInfo().apply {
|
||||||
|
applicationInfo = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = true
|
||||||
|
}
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
}
|
||||||
|
setContent(packageInfo)
|
||||||
|
|
||||||
|
composeTestRule.onNodeWithText(context.getString(R.string.restore)).assertIsDisplayed()
|
||||||
|
composeTestRule.onNodeWithText(context.getString(R.string.archive)).assertIsNotDisplayed()
|
||||||
|
}
|
||||||
|
|
||||||
private fun setContent(packageInfo: PackageInfo = PACKAGE_INFO) {
|
private fun setContent(packageInfo: PackageInfo = PACKAGE_INFO) {
|
||||||
whenever(packageInfoPresenter.flow).thenReturn(MutableStateFlow(packageInfo))
|
whenever(packageInfoPresenter.flow).thenReturn(MutableStateFlow(packageInfo))
|
||||||
composeTestRule.setContent {
|
composeTestRule.setContent {
|
||||||
|
@@ -0,0 +1,132 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2023 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.spa.app.appinfo
|
||||||
|
|
||||||
|
import android.content.Context
|
||||||
|
import android.content.pm.ApplicationInfo
|
||||||
|
import android.content.pm.PackageInstaller
|
||||||
|
import android.content.pm.PackageManager
|
||||||
|
import androidx.compose.material.icons.Icons
|
||||||
|
import androidx.compose.material.icons.outlined.CloudDownload
|
||||||
|
import androidx.compose.ui.test.junit4.createComposeRule
|
||||||
|
import androidx.test.annotation.UiThreadTest
|
||||||
|
import androidx.test.core.app.ApplicationProvider
|
||||||
|
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||||
|
import com.android.settings.R
|
||||||
|
import com.android.settingslib.spa.widget.button.ActionButton
|
||||||
|
import com.google.common.truth.Truth.assertThat
|
||||||
|
import org.junit.Before
|
||||||
|
import org.junit.Rule
|
||||||
|
import org.junit.Test
|
||||||
|
import org.junit.runner.RunWith
|
||||||
|
import org.mockito.kotlin.any
|
||||||
|
import org.mockito.kotlin.eq
|
||||||
|
import org.mockito.kotlin.mock
|
||||||
|
import org.mockito.kotlin.spy
|
||||||
|
import org.mockito.kotlin.verify
|
||||||
|
import org.mockito.kotlin.whenever
|
||||||
|
|
||||||
|
@RunWith(AndroidJUnit4::class)
|
||||||
|
class AppRestoreButtonTest {
|
||||||
|
@get:Rule
|
||||||
|
val composeTestRule = createComposeRule()
|
||||||
|
|
||||||
|
private val context: Context = spy(ApplicationProvider.getApplicationContext()) {}
|
||||||
|
|
||||||
|
private val packageInfoPresenter = mock<PackageInfoPresenter>()
|
||||||
|
|
||||||
|
private val userPackageManager = mock<PackageManager>()
|
||||||
|
|
||||||
|
private val packageInstaller = mock<PackageInstaller>()
|
||||||
|
|
||||||
|
private lateinit var appRestoreButton: AppRestoreButton
|
||||||
|
|
||||||
|
@Before
|
||||||
|
fun setUp() {
|
||||||
|
whenever(packageInfoPresenter.context).thenReturn(context)
|
||||||
|
whenever(packageInfoPresenter.userPackageManager).thenReturn(userPackageManager)
|
||||||
|
whenever(userPackageManager.packageInstaller).thenReturn(packageInstaller)
|
||||||
|
whenever(packageInfoPresenter.packageName).thenReturn(PACKAGE_NAME)
|
||||||
|
appRestoreButton = AppRestoreButton(packageInfoPresenter)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun appRestoreButton_whenIsNotArchived_isDisabled() {
|
||||||
|
val app = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = false
|
||||||
|
}
|
||||||
|
|
||||||
|
val actionButton = setContent(app)
|
||||||
|
|
||||||
|
assertThat(actionButton.enabled).isFalse()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun appRestoreButton_whenIsArchived_isEnabled() {
|
||||||
|
val app = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = true
|
||||||
|
}
|
||||||
|
|
||||||
|
val actionButton = setContent(app)
|
||||||
|
|
||||||
|
assertThat(actionButton.enabled).isTrue()
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun appRestoreButton_displaysRightTextAndIcon() {
|
||||||
|
val app = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = false
|
||||||
|
}
|
||||||
|
|
||||||
|
val actionButton = setContent(app)
|
||||||
|
|
||||||
|
assertThat(actionButton.text).isEqualTo(context.getString(R.string.restore))
|
||||||
|
assertThat(actionButton.imageVector).isEqualTo(Icons.Outlined.CloudDownload)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
@UiThreadTest
|
||||||
|
fun appRestoreButton_clicked() {
|
||||||
|
val app = ApplicationInfo().apply {
|
||||||
|
packageName = PACKAGE_NAME
|
||||||
|
isArchived = true
|
||||||
|
}
|
||||||
|
|
||||||
|
val actionButton = setContent(app)
|
||||||
|
actionButton.onClick()
|
||||||
|
|
||||||
|
verify(packageInstaller).requestUnarchive(
|
||||||
|
eq(PACKAGE_NAME),
|
||||||
|
any()
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
private fun setContent(app: ApplicationInfo): ActionButton {
|
||||||
|
lateinit var actionButton: ActionButton
|
||||||
|
composeTestRule.setContent {
|
||||||
|
actionButton = appRestoreButton.getActionButton(app)
|
||||||
|
}
|
||||||
|
return actionButton
|
||||||
|
}
|
||||||
|
|
||||||
|
private companion object {
|
||||||
|
const val PACKAGE_NAME = "package.name"
|
||||||
|
}
|
||||||
|
}
|
Reference in New Issue
Block a user