Update some TODO comments.

This commit is contained in:
Wink Saville
2009-05-29 14:06:30 -07:00
parent 2a2daf960c
commit e2a14e35aa
2 changed files with 8 additions and 14 deletions

View File

@@ -622,23 +622,21 @@ public class RadioInfo extends Activity {
dnsCheckState.setText(phone.isDnsCheckDisabled() ? dnsCheckState.setText(phone.isDnsCheckDisabled() ?
"0.0.0.0 allowed" :"0.0.0.0 not allowed"); "0.0.0.0 allowed" :"0.0.0.0 not allowed");
} }
private final void private final void
updateSignalStrength() { updateSignalStrength() {
// TODO TELECA: PhoneStateIntentReceiver deprecated, use TelephonyManager or // TODO PhoneStateIntentReceiver is deprecated and PhoneStateListener
// PhoneStateListener instead. // should probably used instead.
// Use new SignalStrength for signal int state = mPhoneStateReceiver.getServiceState().getState();
int state =
mPhoneStateReceiver.getServiceState().getState();
Resources r = getResources(); Resources r = getResources();
if ((ServiceState.STATE_OUT_OF_SERVICE == state) || if ((ServiceState.STATE_OUT_OF_SERVICE == state) ||
(ServiceState.STATE_POWER_OFF == state)) { (ServiceState.STATE_POWER_OFF == state)) {
dBm.setText("0"); dBm.setText("0");
} }
int signalDbm = mPhoneStateReceiver.getSignalStrengthDbm(); int signalDbm = mPhoneStateReceiver.getSignalStrengthDbm();
if (-1 == signalDbm) signalDbm = 0; if (-1 == signalDbm) signalDbm = 0;
int signalAsu = mPhoneStateReceiver.getSignalStrength(); int signalAsu = mPhoneStateReceiver.getSignalStrength();
@@ -1188,4 +1186,3 @@ public class RadioInfo extends Activity {
private String[] mPreferredNetworkLabels = { private String[] mPreferredNetworkLabels = {
"WCDMA preferred", "GSM only", "WCDMA only", "Unknown"}; "WCDMA preferred", "GSM only", "WCDMA only", "Unknown"};
} }

View File

@@ -303,9 +303,8 @@ public class Status extends PreferenceActivity {
} }
void updateSignalStrength() { void updateSignalStrength() {
// TODO TELECA: PhoneStateIntentReceiver deprecated, use TelephonyManager or // TODO PhoneStateIntentReceiver is deprecated and PhoneStateListener
// PhoneStateListener instead. // should probably used instead.
// Use new SignalStrength for signal
// not loaded in some versions of the code (e.g., zaku) // not loaded in some versions of the code (e.g., zaku)
if (mSignalStrength != null) { if (mSignalStrength != null) {
@@ -385,5 +384,3 @@ public class Status extends PreferenceActivity {
return h + ":" + pad(m) + ":" + pad(s); return h + ":" + pad(m) + ":" + pad(s);
} }
} }