From 8bb198a7d462c7989d36534343491c5977753f1a Mon Sep 17 00:00:00 2001 From: Bonian Chen Date: Fri, 19 Nov 2021 13:17:49 +0800 Subject: [PATCH 1/5] [Settings] Remove the capital of 2nd wording 2nd wording should avoid from capital. Bug: 191525963 Test: local Change-Id: I55b188df04ac0a88062a24492f44534a7d61a05b --- res/values/strings.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index f790a521ce3..2e0ec7d47ba 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2823,7 +2823,7 @@ - Emergency Address + Emergency address Used as your location when you make an emergency call over Wi\u2011Fi From 90eef24080abfd5b79c67534de0548be92f06561 Mon Sep 17 00:00:00 2001 From: Jason Chiu Date: Fri, 19 Nov 2021 14:35:27 +0800 Subject: [PATCH 2/5] UI refinement of highlighted menu entry for large screen - Add a new highlight background drawable - Add two homepage specific preferences for the new layout design Fix: 207079684 Test: visual Change-Id: I20c80da090a03129bffa845d443ee5d1ad13b97b --- .../homepage_highlighted_item_background.xml | 27 +++++++ res/layout/homepage_preference.xml | 81 +++++++++++++++++++ res/values/dimens.xml | 4 + res/xml/top_level_settings.xml | 36 ++++----- .../settings/dashboard/DashboardFragment.java | 3 +- .../settings/homepage/TopLevelSettings.java | 7 ++ ...ighlightableTopLevelPreferenceAdapter.java | 21 +++-- .../settings/widget/HomepagePreference.java | 48 +++++++++++ .../widget/RestrictedHomepagePreference.java | 47 +++++++++++ 9 files changed, 243 insertions(+), 31 deletions(-) create mode 100644 res/drawable/homepage_highlighted_item_background.xml create mode 100644 res/layout/homepage_preference.xml create mode 100644 src/com/android/settings/widget/HomepagePreference.java create mode 100644 src/com/android/settings/widget/RestrictedHomepagePreference.java diff --git a/res/drawable/homepage_highlighted_item_background.xml b/res/drawable/homepage_highlighted_item_background.xml new file mode 100644 index 00000000000..d45e489c7d3 --- /dev/null +++ b/res/drawable/homepage_highlighted_item_background.xml @@ -0,0 +1,27 @@ + + + + + + + + \ No newline at end of file diff --git a/res/layout/homepage_preference.xml b/res/layout/homepage_preference.xml new file mode 100644 index 00000000000..62f6457d27f --- /dev/null +++ b/res/layout/homepage_preference.xml @@ -0,0 +1,81 @@ + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 9eadf897af6..2468db62bd1 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -141,6 +141,10 @@ 8dp 24dp + + 16dp + 28dp + 16dp 16dp diff --git a/res/xml/top_level_settings.xml b/res/xml/top_level_settings.xml index e2cb1736fcf..042ce43999a 100644 --- a/res/xml/top_level_settings.xml +++ b/res/xml/top_level_settings.xml @@ -20,7 +20,7 @@ xmlns:settings="http://schemas.android.com/apk/res-auto" android:key="top_level_settings"> - - - - - - - - - - - - - - - - - - Date: Tue, 23 Nov 2021 11:35:09 +0800 Subject: [PATCH 3/5] Fix talkback issue on Subsettings Set window title for activity, so it won't announce "Settings" again. Test: Run the talkback and do not observe issue Fix: 200749911 Change-Id: Ied973916bdd43562424b97eadea2b3a413c712ec --- src/com/android/settings/core/SettingsBaseActivity.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/com/android/settings/core/SettingsBaseActivity.java b/src/com/android/settings/core/SettingsBaseActivity.java index 464e459f2bd..72770be7f09 100644 --- a/src/com/android/settings/core/SettingsBaseActivity.java +++ b/src/com/android/settings/core/SettingsBaseActivity.java @@ -187,19 +187,17 @@ public class SettingsBaseActivity extends FragmentActivity implements CategoryHa @Override public void setTitle(CharSequence title) { + super.setTitle(title); if (mCollapsingToolbarLayout != null) { mCollapsingToolbarLayout.setTitle(title); - } else { - super.setTitle(title); } } @Override public void setTitle(int titleId) { + super.setTitle(getText(titleId)); if (mCollapsingToolbarLayout != null) { mCollapsingToolbarLayout.setTitle(getText(titleId)); - } else { - super.setTitle(titleId); } } From cffaef122b2394561dbda9ed38f5eee5ef808995 Mon Sep 17 00:00:00 2001 From: Jason Chang Date: Sat, 20 Nov 2021 23:21:28 +0800 Subject: [PATCH 4/5] (2) Update new intent action ACTION_ONE_HANDED_SETTINGS in Settings AndroidManifest to support long-pressed action for One-handed mode tile Update new intent action ACTION_ONE_HANDED_SETTINGS in Settings AndroidManifest for Settings$OneHandedSettingsActivity. Bug: 201743873 Bug: 202132480 Bug: 207381742 Test: manually test long-pressed on One-handed mode QS tile Change-Id: Id3882c62b6531a2a8c03378025cbda03efbb8c7c --- AndroidManifest.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 9f0891ee242..cd235216015 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -4272,6 +4272,10 @@ android:label="@string/one_handed_title" android:exported="true" android:enabled="true"> + + + + From ebbb5c277e3d9aa7217d785951de6b0510ceec2f Mon Sep 17 00:00:00 2001 From: Joe Bolinger Date: Tue, 23 Nov 2021 11:41:17 -0800 Subject: [PATCH 5/5] Prevent scrolling when interacting with confirm pattern prompt. This uses the same fix as related commit e55568a7ba980966f78a7d88f812587e13341a4e Fix: 207325277 Test: manual (set pattern via settings in dual pane mode) Change-Id: Ic56829df23442df45d47d60ea5b8319e4ab58931 --- .../android/settings/password/ConfirmLockPattern.java | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/com/android/settings/password/ConfirmLockPattern.java b/src/com/android/settings/password/ConfirmLockPattern.java index a1a7ea7fa44..ec5efcfbc4e 100644 --- a/src/com/android/settings/password/ConfirmLockPattern.java +++ b/src/com/android/settings/password/ConfirmLockPattern.java @@ -17,6 +17,7 @@ package com.android.settings.password; import android.annotation.Nullable; +import android.annotation.SuppressLint; import android.app.Activity; import android.app.settings.SettingsEnums; import android.content.Intent; @@ -28,6 +29,7 @@ import android.os.UserManager; import android.os.storage.StorageManager; import android.text.TextUtils; import android.view.LayoutInflater; +import android.view.MotionEvent; import android.view.View; import android.view.ViewGroup; import android.view.animation.AnimationUtils; @@ -108,6 +110,7 @@ public class ConfirmLockPattern extends ConfirmDeviceCredentialBaseActivity { } + @SuppressLint("ClickableViewAccessibility") @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { @@ -146,6 +149,12 @@ public class ConfirmLockPattern extends ConfirmDeviceCredentialBaseActivity { mLockPatternView.setInStealthMode(!mLockPatternUtils.isVisiblePatternEnabled( mEffectiveUserId)); mLockPatternView.setOnPatternListener(mConfirmExistingLockPatternListener); + mLockPatternView.setOnTouchListener((v, event) -> { + if (event.getAction() == MotionEvent.ACTION_DOWN) { + v.getParent().requestDisallowInterceptTouchEvent(true); + } + return false; + }); updateStage(Stage.NeedToUnlock); if (savedInstanceState == null) {