From e0036fc8b26a5d5470992f90d6e2260b57ddc9ac Mon Sep 17 00:00:00 2001 From: Kasia Krejszeff Date: Tue, 7 Jan 2025 01:44:12 +0000 Subject: [PATCH] Remove nested ScrollView in the PrivateSpaceEducation screen. It is not needed for the scrolling to work -- GlifLayout from the SUW library generates a ScrollView. Additional ScrollView causes Talkback to interpret it as a separate item and read out contents of its all children. See b/379256039. Video before: https://drive.google.com/file/d/1H3k5AxlIdgAA15PHUQ9tVq5AechziA4Z/view?usp=sharing&resourcekey=0-ozeQsQSS5jubL0pZ5FAZHA Video after: https://drive.google.com/file/d/1W_ODgQhbQS6Xf_57A4TcYeJbqMJxYF16/view?usp=sharing&resourcekey=0-zQ0_p3qlIxpBL3rB5SC4vQ In the before video, talkback is highlighting and (the green frames) and reading out the whole "How it works" section in addition to each element separately. After the fix it only highlights elements separately. Bug: 379256039 Test: Manually testesd and presubmit. Flag: EXEMPT bugfix Change-Id: Idf6772b8772c54c1907d3a12617fcd03451af41b --- res/layout/private_space_education_screen.xml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/res/layout/private_space_education_screen.xml b/res/layout/private_space_education_screen.xml index 3afe7f97ed9..5a34939ac66 100644 --- a/res/layout/private_space_education_screen.xml +++ b/res/layout/private_space_education_screen.xml @@ -24,10 +24,6 @@ app:sucHeaderText="@string/private_space_setup_title" app:sudDescriptionText="@string/private_space_hide_apps_summary" android:icon="@drawable/ic_private_space_icon"> - -