PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix of Settings application sort crash

Browse Source 
The original implementation of compareTo function
will sometimes cause crash when the power usage list
above 32 items.

When comparing double values a proper comparison method
needs to be used. Using just subtraction does not take
into account NaN:S, infinities and +/-0 numbers. In certain
cirtumstances it seems that using subtraction causes
compareTo to return values that is not expected by the
sorting code and causes an illegal argument exception with
"Comparison method violates its general contract!".

This problem only happens if the sort code is called arrays
containing more than 32 (currently) due to how
ComparableTimSort works (call chain is Collections.sort ->
Arrays.sort(Object[]) -> ComparableTimSort.

Change-Id: If732f04797a3c8b2a43568c90bb73a1ec69a4c98
This commit is contained in:
Jia Arlan
2012-05-11 16:27:07 +08:00
committed by Henrik Baard
parent f141594c05
commit dffcc39ba5
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/com/android/settings/fuelgauge/BatterySipper.java
View File

@@ -93,7 +93,7 @@ class BatterySipper implements Comparable<BatterySipper> {
public int compareTo(BatterySipper other) { public int compareTo(BatterySipper other) {
// Return the flipped value because we want the items in descending order // Return the flipped value because we want the items in descending order
return (int) (other.getSortValue() - getSortValue()); return Double.compare(other.getSortValue(), getSortValue());
} }
void getQuickNameIconForUid(Uid uidObj) { void getQuickNameIconForUid(Uid uidObj) {