diff --git a/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogController.java b/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogController.java index 166eda3306c..857f535084d 100644 --- a/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogController.java +++ b/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogController.java @@ -26,10 +26,10 @@ import android.os.Bundle; import android.os.PersistableBundle; import android.os.UserHandle; import android.telephony.CarrierConfigManager; -import android.telephony.SmsCbMessage; import android.telephony.PhoneStateListener; import android.telephony.ServiceState; import android.telephony.SignalStrength; +import android.telephony.SmsCbMessage; import android.telephony.SubscriptionInfo; import android.telephony.SubscriptionManager; import android.telephony.SubscriptionManager.OnSubscriptionsChangedListener; @@ -141,9 +141,9 @@ public class SimStatusDialogController implements LifecycleObserver, OnResume, O mSlotIndex = slotId; mSubscriptionInfo = getPhoneSubscriptionInfo(slotId); - mTelephonyManager = mContext.getSystemService(TelephonyManager.class); - mCarrierConfigManager = mContext.getSystemService(CarrierConfigManager.class); - mEuiccManager = mContext.getSystemService(EuiccManager.class); + mTelephonyManager = mContext.getSystemService(TelephonyManager.class); + mCarrierConfigManager = mContext.getSystemService(CarrierConfigManager.class); + mEuiccManager = mContext.getSystemService(EuiccManager.class); mSubscriptionManager = mContext.getSystemService(SubscriptionManager.class); mRes = mContext.getResources(); @@ -182,9 +182,9 @@ public class SimStatusDialogController implements LifecycleObserver, OnResume, O mTelephonyManager.createForSubscriptionId(mSubscriptionInfo.getSubscriptionId()) .listen(mPhoneStateListener, - PhoneStateListener.LISTEN_DATA_CONNECTION_STATE - | PhoneStateListener.LISTEN_SIGNAL_STRENGTHS - | PhoneStateListener.LISTEN_SERVICE_STATE); + PhoneStateListener.LISTEN_DATA_CONNECTION_STATE + | PhoneStateListener.LISTEN_SIGNAL_STRENGTHS + | PhoneStateListener.LISTEN_SERVICE_STATE); mSubscriptionManager.addOnSubscriptionsChangedListener(mOnSubscriptionsChangedListener); if (mShowLatestAreaInfo) { @@ -405,13 +405,14 @@ public class SimStatusDialogController implements LifecycleObserver, OnResume, O private void updateImsRegistrationState() { final int subscriptionId = mSubscriptionInfo.getSubscriptionId(); final PersistableBundle carrierConfig = - mCarrierConfigManager.getConfigForSubId(subscriptionId); + mCarrierConfigManager.getConfigForSubId(subscriptionId); final boolean showImsRegState = carrierConfig == null ? false : - carrierConfig.getBoolean(CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL); + carrierConfig.getBoolean( + CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL); if (showImsRegState) { final boolean isImsRegistered = mTelephonyManager.isImsRegistered(subscriptionId); mDialog.setText(IMS_REGISTRATION_STATE_VALUE_ID, mRes.getString(isImsRegistered ? - R.string.ims_reg_status_registered : R.string.ims_reg_status_not_registered)); + R.string.ims_reg_status_registered : R.string.ims_reg_status_not_registered)); } else { mDialog.removeSettingFromScreen(IMS_REGISTRATION_STATE_LABEL_ID); mDialog.removeSettingFromScreen(IMS_REGISTRATION_STATE_VALUE_ID); diff --git a/tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogControllerTest.java b/tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogControllerTest.java index 147e627b8b2..3ecdcffb03c 100644 --- a/tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogControllerTest.java +++ b/tests/robotests/src/com/android/settings/deviceinfo/simstatus/SimStatusDialogControllerTest.java @@ -16,35 +16,21 @@ package com.android.settings.deviceinfo.simstatus; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .CELL_DATA_NETWORK_TYPE_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .CELL_VOICE_NETWORK_TYPE_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.CELL_DATA_NETWORK_TYPE_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.CELL_VOICE_NETWORK_TYPE_VALUE_ID; import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.EID_INFO_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .ICCID_INFO_LABEL_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .ICCID_INFO_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .IMS_REGISTRATION_STATE_LABEL_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .IMS_REGISTRATION_STATE_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .NETWORK_PROVIDER_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .OPERATOR_INFO_LABEL_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .OPERATOR_INFO_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .PHONE_NUMBER_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .ROAMING_INFO_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .SERVICE_STATE_VALUE_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .SIGNAL_STRENGTH_LABEL_ID; -import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController - .SIGNAL_STRENGTH_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.ICCID_INFO_LABEL_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.ICCID_INFO_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.IMS_REGISTRATION_STATE_LABEL_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.IMS_REGISTRATION_STATE_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.NETWORK_PROVIDER_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.OPERATOR_INFO_LABEL_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.OPERATOR_INFO_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.PHONE_NUMBER_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.ROAMING_INFO_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SERVICE_STATE_VALUE_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_LABEL_ID; +import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_VALUE_ID; import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.anyInt; @@ -146,7 +132,7 @@ public class SimStatusDialogControllerTest { .thenReturn(true); final ShadowPackageManager shadowPackageManager = - Shadows.shadowOf(RuntimeEnvironment.application.getPackageManager()); + Shadows.shadowOf(RuntimeEnvironment.application.getPackageManager()); final PackageInfo sysUIPackageInfo = new PackageInfo(); sysUIPackageInfo.packageName = "com.android.systemui"; shadowPackageManager.addPackage(sysUIPackageInfo); @@ -251,7 +237,7 @@ public class SimStatusDialogControllerTest { mController.initialize(); final String signalStrengthString = - mContext.getString(R.string.sim_signal_strength, signalDbm, signalAsu); + mContext.getString(R.string.sim_signal_strength, signalDbm, signalAsu); verify(mDialog).setText(SIGNAL_STRENGTH_VALUE_ID, signalStrengthString); } @@ -333,7 +319,7 @@ public class SimStatusDialogControllerTest { public void initialize_doNotShowSignalStrength_shouldRemoveSignalStrengthSetting() { when(mPersistableBundle.getBoolean( CarrierConfigManager.KEY_SHOW_SIGNAL_STRENGTH_IN_SIM_STATUS_BOOL)) - .thenReturn(false); + .thenReturn(false); mController.initialize(); @@ -389,31 +375,31 @@ public class SimStatusDialogControllerTest { @Test public void initialize_imsRegistered_shouldSetImsRegistrationStateSummaryToRegisterd() { when(mPersistableBundle.getBoolean( - CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); + CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); when(mTelephonyManager.isImsRegistered(anyInt())).thenReturn(true); mController.initialize(); verify(mDialog).setText(IMS_REGISTRATION_STATE_VALUE_ID, - mContext.getString(R.string.ims_reg_status_registered)); + mContext.getString(R.string.ims_reg_status_registered)); } @Test public void initialize_imsNotRegistered_shouldSetImsRegistrationStateSummaryToNotRegisterd() { when(mPersistableBundle.getBoolean( - CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); + CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); when(mTelephonyManager.isImsRegistered(anyInt())).thenReturn(false); mController.initialize(); verify(mDialog).setText(IMS_REGISTRATION_STATE_VALUE_ID, - mContext.getString(R.string.ims_reg_status_not_registered)); + mContext.getString(R.string.ims_reg_status_not_registered)); } @Test public void initialize_showImsRegistration_shouldNotRemoveImsRegistrationStateSetting() { when(mPersistableBundle.getBoolean( - CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); + CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(true); mController.initialize(); @@ -423,7 +409,7 @@ public class SimStatusDialogControllerTest { @Test public void initialize_doNotShowImsRegistration_shouldRemoveImsRegistrationStateSetting() { when(mPersistableBundle.getBoolean( - CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(false); + CarrierConfigManager.KEY_SHOW_IMS_REGISTRATION_STATUS_BOOL)).thenReturn(false); mController.initialize();