diff --git a/res/values/strings.xml b/res/values/strings.xml index 04d9f17de4b..927035d3095 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -1526,8 +1526,6 @@ Disconnect App? %1$s app will no longer connect to your %2$s - - Experimental. Improves audio quality. Forget device @@ -6431,7 +6429,7 @@ delete, guest, activity, remove, data, visitor, erase - Allow guest to use phone + Allow guest to make phone calls Call history will be shared with guest user diff --git a/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java b/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java index 701967bfb5e..00f18e8a87a 100644 --- a/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java +++ b/src/com/android/settings/bluetooth/BluetoothDetailsProfilesController.java @@ -116,10 +116,6 @@ public class BluetoothDetailsProfilesController extends BluetoothDetailsControll pref.setTitle(profile.getNameResource(mCachedDevice.getDevice())); pref.setOnPreferenceClickListener(this); pref.setOrder(profile.getOrdinal()); - - if (profile instanceof LeAudioProfile) { - pref.setSummary(R.string.device_details_leaudio_toggle_summary); - } return pref; } diff --git a/src/com/android/settings/password/SetupChooseLockPattern.java b/src/com/android/settings/password/SetupChooseLockPattern.java index 2cad1813568..4424b4f6c2d 100644 --- a/src/com/android/settings/password/SetupChooseLockPattern.java +++ b/src/com/android/settings/password/SetupChooseLockPattern.java @@ -90,6 +90,12 @@ public class SetupChooseLockPattern extends ChooseLockPattern { } // Show the skip button during SUW but not during Settings > Biometric Enrollment mSkipOrClearButton.setOnClickListener(this::onSkipOrClearButtonClick); + + final View headerView = view.findViewById(R.id.sud_layout_header); + final ViewGroup.MarginLayoutParams lp = + (ViewGroup.MarginLayoutParams) headerView.getLayoutParams(); + lp.bottomMargin = 0; + view.setLayoutParams(lp); return view; } diff --git a/src/com/android/settings/users/GuestTelephonyPreferenceController.java b/src/com/android/settings/users/GuestTelephonyPreferenceController.java index a935b8a4535..2aa808f4e5c 100644 --- a/src/com/android/settings/users/GuestTelephonyPreferenceController.java +++ b/src/com/android/settings/users/GuestTelephonyPreferenceController.java @@ -17,6 +17,7 @@ package com.android.settings.users; import android.content.Context; +import android.content.pm.PackageManager; import android.os.Bundle; import android.os.UserManager; @@ -73,6 +74,7 @@ public class GuestTelephonyPreferenceController extends TogglePreferenceControll public void updateState(Preference preference) { super.updateState(preference); mUserCaps.updateAddUserCapabilities(mContext); - preference.setVisible(isAvailable() && mUserCaps.mUserSwitcherEnabled); + preference.setVisible(isAvailable() && mUserCaps.mUserSwitcherEnabled && mContext + .getPackageManager().hasSystemFeature(PackageManager.FEATURE_TELEPHONY)); } } diff --git a/src/com/android/settings/users/UserSettings.java b/src/com/android/settings/users/UserSettings.java index d9fbc423f8d..93b7c781517 100644 --- a/src/com/android/settings/users/UserSettings.java +++ b/src/com/android/settings/users/UserSettings.java @@ -977,10 +977,10 @@ public class UserSettings extends SettingsPreferenceFragment return; } try { - getContext().getSystemService(UserManager.class) - .removeUserWhenPossible(UserHandle.of(UserHandle.myUserId()), - /* overrideDevicePolicy= */ false); - ActivityManager.getService().switchUser(UserHandle.USER_SYSTEM); + mUserManager.removeUserWhenPossible( + UserHandle.of(UserHandle.myUserId()), /* overrideDevicePolicy= */ false); + ActivityManager.getService().switchUser( + mUserManager.getPreviousForegroundUser().getIdentifier()); } catch (RemoteException re) { Log.e(TAG, "Unable to remove self user"); } @@ -1099,7 +1099,7 @@ public class UserSettings extends SettingsPreferenceFragment } mMetricsFeatureProvider.action(getActivity(), SettingsEnums.ACTION_USER_GUEST_EXIT_CONFIRMED); - switchToUserId(UserHandle.USER_SYSTEM); + switchToUserId(mUserManager.getPreviousForegroundUser().getIdentifier()); } private int createGuest() { @@ -1139,8 +1139,8 @@ public class UserSettings extends SettingsPreferenceFragment // Create a new guest in the foreground, and then immediately switch to it int newGuestUserId = createGuest(); if (newGuestUserId == UserHandle.USER_NULL) { - Log.e(TAG, "Could not create new guest, switching back to system user"); - switchToUserId(UserHandle.USER_SYSTEM); + Log.e(TAG, "Could not create new guest, switching back to previous user"); + switchToUserId(mUserManager.getPreviousForegroundUser().getIdentifier()); mUserManager.removeUser(oldGuestUserId); WindowManagerGlobal.getWindowManagerService().lockNow(/* options= */ null); return; diff --git a/tests/robotests/src/com/android/settings/password/SetupChooseLockPatternTest.java b/tests/robotests/src/com/android/settings/password/SetupChooseLockPatternTest.java index c5e08137863..2f469867d0d 100644 --- a/tests/robotests/src/com/android/settings/password/SetupChooseLockPatternTest.java +++ b/tests/robotests/src/com/android/settings/password/SetupChooseLockPatternTest.java @@ -28,6 +28,7 @@ import android.content.res.Resources; import android.os.UserHandle; import android.util.TypedValue; import android.view.View; +import android.view.ViewGroup; import android.widget.Button; import android.widget.TextView; @@ -114,6 +115,14 @@ public class SetupChooseLockPatternTest { assertThat(button.getVisibility()).isEqualTo(View.VISIBLE); } + @Test + public void headerView_noBottomMargin() { + final View header = mActivity.findViewById(R.id.sud_layout_header); + final ViewGroup.MarginLayoutParams lp = + (ViewGroup.MarginLayoutParams) header.getLayoutParams(); + assertThat(lp.bottomMargin).isEqualTo(0); + } + private void verifyScreenLockOptionsShown() { final Button button = mActivity.findViewById(R.id.screen_lock_options); assertThat(button).isNotNull();