From 4f4424a820688638930f871ad421e05588549ae5 Mon Sep 17 00:00:00 2001
From: Tony Mantler <nicoya@google.com>
Date: Wed, 21 Oct 2015 11:30:10 -0700
Subject: [PATCH] Move some app methods to AppUtils in SettingsLib

Change-Id: I1503e9d0e35c57aae32f90ff2c148cf1b75dcf05
---
 res/values/strings.xml                        |  5 ----
 src/com/android/settings/Utils.java           | 25 -------------------
 .../applications/ClearDefaultsPreference.java |  6 ++---
 .../applications/InstalledAppDetails.java     |  3 ++-
 4 files changed, 5 insertions(+), 34 deletions(-)

diff --git a/res/values/strings.xml b/res/values/strings.xml
index 1e29144bdf7..f5854b4a98c 100644
--- a/res/values/strings.xml
+++ b/res/values/strings.xml
@@ -6622,11 +6622,6 @@
     <!-- Runtime permissions preference summary, shown when the app requests no permissions. [CHAR LIMIT=40] -->
     <string name="runtime_permissions_summary_no_permissions_requested">No permissions requested</string>
 
-    <!-- Launch defaults preference summary with some set [CHAR LIMIT=40] -->
-    <string name="launch_defaults_some">Some defaults set</string>
-    <!-- Launch defaults preference summary with none set [CHAR LIMIT=40] -->
-    <string name="launch_defaults_none">No defaults set</string>
-
     <!-- Label for showing all apps in list [CHAR LIMIT=30] -->
     <string name="filter_all_apps">All apps</string>
     <!-- Label for showing enabled apps in list [CHAR LIMIT=30] -->
diff --git a/src/com/android/settings/Utils.java b/src/com/android/settings/Utils.java
index ed67ee41dd9..679122dbf65 100644
--- a/src/com/android/settings/Utils.java
+++ b/src/com/android/settings/Utils.java
@@ -1024,17 +1024,6 @@ public final class Utils {
         return bitmap;
     }
 
-    public static boolean hasUsbDefaults(IUsbManager usbManager, String packageName) {
-        try {
-            if (usbManager != null) {
-                return usbManager.hasDefaults(packageName, UserHandle.myUserId());
-            }
-        } catch (RemoteException e) {
-            Log.e(TAG, "mUsbManager.hasDefaults", e);
-        }
-        return false;
-    }
-
     public static boolean hasPreferredActivities(PackageManager pm, String packageName) {
         // Get list of preferred activities
         List<ComponentName> prefActList = new ArrayList<>();
@@ -1069,20 +1058,6 @@ public final class Utils {
         return result;
     }
 
-    public static CharSequence getLaunchByDeafaultSummary(ApplicationsState.AppEntry appEntry,
-            IUsbManager usbManager, PackageManager pm, Context context) {
-        String packageName = appEntry.info.packageName;
-        boolean hasPreferred = hasPreferredActivities(pm, packageName)
-                || hasUsbDefaults(usbManager, packageName);
-        int status = pm.getIntentVerificationStatus(packageName, UserHandle.myUserId());
-        // consider a visible current link-handling state to be any explicitly designated behavior
-        boolean hasDomainURLsPreference =
-                status != PackageManager.INTENT_FILTER_DOMAIN_VERIFICATION_STATUS_UNDEFINED;
-        return context.getString(hasPreferred || hasDomainURLsPreference
-                ? R.string.launch_defaults_some
-                : R.string.launch_defaults_none);
-    }
-
     public static void handleLoadingContainer(View loading, View doneLoading, boolean done,
             boolean animate) {
         setViewShown(loading, !done, animate);
diff --git a/src/com/android/settings/applications/ClearDefaultsPreference.java b/src/com/android/settings/applications/ClearDefaultsPreference.java
index 96a9b3fb31d..3a63a663b04 100644
--- a/src/com/android/settings/applications/ClearDefaultsPreference.java
+++ b/src/com/android/settings/applications/ClearDefaultsPreference.java
@@ -36,7 +36,7 @@ import android.widget.Button;
 import android.widget.TextView;
 
 import com.android.settings.R;
-import com.android.settings.Utils;
+import com.android.settingslib.applications.AppUtils;
 import com.android.settingslib.applications.ApplicationsState;
 
 public class ClearDefaultsPreference extends Preference {
@@ -117,9 +117,9 @@ public class ClearDefaultsPreference extends Preference {
                 mAppWidgetManager.hasBindAppWidgetPermission(mAppEntry.info.packageName);
 
         TextView autoLaunchView = (TextView) view.findViewById(R.id.auto_launch);
-        boolean autoLaunchEnabled = Utils.hasPreferredActivities(mPm, mPackageName)
+        boolean autoLaunchEnabled = AppUtils.hasPreferredActivities(mPm, mPackageName)
                 || isDefaultBrowser(mPackageName)
-                || Utils.hasUsbDefaults(mUsbManager, mPackageName);
+                || AppUtils.hasUsbDefaults(mUsbManager, mPackageName);
         if (!autoLaunchEnabled && !hasBindAppWidgetPermission) {
             resetLaunchDefaultsUi(autoLaunchView);
         } else {
diff --git a/src/com/android/settings/applications/InstalledAppDetails.java b/src/com/android/settings/applications/InstalledAppDetails.java
index ce7b9fd3a94..ecb0b6f433f 100755
--- a/src/com/android/settings/applications/InstalledAppDetails.java
+++ b/src/com/android/settings/applications/InstalledAppDetails.java
@@ -79,6 +79,7 @@ import com.android.settings.notification.AppNotificationSettings;
 import com.android.settings.notification.NotificationBackend;
 import com.android.settings.notification.NotificationBackend.AppRow;
 import com.android.settingslib.AppItem;
+import com.android.settingslib.applications.AppUtils;
 import com.android.settingslib.applications.ApplicationsState;
 import com.android.settingslib.applications.ApplicationsState.AppEntry;
 import com.android.settingslib.net.ChartData;
@@ -504,7 +505,7 @@ public class InstalledAppDetails extends AppInfoBase
         }
         mPermissionReceiver = PermissionsSummaryHelper.getPermissionSummary(getContext(),
                 mPackageName, mPermissionCallback);
-        mLaunchPreference.setSummary(Utils.getLaunchByDeafaultSummary(mAppEntry, mUsbManager,
+        mLaunchPreference.setSummary(AppUtils.getLaunchByDefaultSummary(mAppEntry, mUsbManager,
                 mPm, context));
         mNotificationPreference.setSummary(getNotificationSummary(mAppEntry, context,
                 mBackend));