diff --git a/res/values/strings.xml b/res/values/strings.xml index 8f2c34e077c..5dbd34c38f4 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -212,8 +212,6 @@ Tap to pair with %1$s. Received files - - Files received via Bluetooth Bluetooth is off @@ -4800,7 +4798,7 @@ Delete app data? - All this app\u2019s data will be deleted permanently. This includes all files, settings, accounts, databases, etc. + This app\u2019s data will be permanently deleted. This includes files, settings, databases, and other app data. OK @@ -6560,6 +6558,8 @@ No usage from last full charge No usage for past 24 hr + + Battery left estimate is based on your device usage diff --git a/res/xml/connected_devices_advanced.xml b/res/xml/connected_devices_advanced.xml index 85e4a762429..152446c38c7 100644 --- a/res/xml/connected_devices_advanced.xml +++ b/res/xml/connected_devices_advanced.xml @@ -60,11 +60,6 @@ android:fragment="com.android.settings.print.PrintSettingsFragment" android:order="-3"/> - - controllers = new ArrayList<>(); - controllers.add(new BluetoothFilesPreferenceController(context)); - final PrintSettingPreferenceController printerController = new PrintSettingPreferenceController(context); diff --git a/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java b/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java index 8019d0a087a..0d0cdba5a09 100644 --- a/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java +++ b/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetail.java @@ -326,10 +326,7 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements } if (mEnableTriState) { - final long foregroundTimeMs = bundle.getLong(EXTRA_FOREGROUND_TIME); - final long backgroundTimeMs = bundle.getLong(EXTRA_BACKGROUND_TIME); - final String slotTime = bundle.getString(EXTRA_SLOT_TIME, null); - controller.setSummary(getAppActiveTime(foregroundTimeMs, backgroundTimeMs, slotTime)); + controller.setSummary(getAppActiveTime(bundle)); } controller.done(context, true /* rebindActions */); @@ -493,16 +490,21 @@ public class AdvancedPowerUsageDetail extends DashboardFragment implements mOptimizationMode = mBatteryOptimizeUtils.getAppOptimizationMode(); } - private CharSequence getAppActiveTime( - long foregroundTimeMs, long backgroundTimeMs, String slotTime) { + private CharSequence getAppActiveTime(Bundle bundle) { + final long foregroundTimeMs = bundle.getLong(EXTRA_FOREGROUND_TIME); + final long backgroundTimeMs = bundle.getLong(EXTRA_BACKGROUND_TIME); + final int consumedPower = bundle.getInt(EXTRA_POWER_USAGE_AMOUNT); + final String slotTime = bundle.getString(EXTRA_SLOT_TIME, null); final long totalTimeMs = foregroundTimeMs + backgroundTimeMs; final CharSequence usageTimeSummary; final PowerUsageFeatureProvider powerFeatureProvider = FeatureFactory.getFactory(getContext()).getPowerUsageFeatureProvider(getContext()); if (totalTimeMs == 0) { + final int batteryWithoutUsageTime = consumedPower > 0 + ? R.string.battery_usage_without_time : R.string.battery_not_usage_24hr; usageTimeSummary = getText(powerFeatureProvider.isChartGraphEnabled(getContext()) - ? R.string.battery_not_usage_24hr : R.string.battery_not_usage); + ? batteryWithoutUsageTime : R.string.battery_not_usage); } else if (slotTime == null) { // Shows summary text with past 24 hr or full charge if slot time is null. usageTimeSummary = powerFeatureProvider.isChartGraphEnabled(getContext()) diff --git a/src/com/android/settings/wifi/tether/WifiTetherSettings.java b/src/com/android/settings/wifi/tether/WifiTetherSettings.java index 088356b904e..23601fac5d8 100644 --- a/src/com/android/settings/wifi/tether/WifiTetherSettings.java +++ b/src/com/android/settings/wifi/tether/WifiTetherSettings.java @@ -54,7 +54,6 @@ public class WifiTetherSettings extends RestrictedDashboardFragment private static final String TAG = "WifiTetherSettings"; private static final IntentFilter TETHER_STATE_CHANGE_FILTER; private static final String KEY_WIFI_TETHER_SCREEN = "wifi_tether_settings_screen"; - private static final int EXPANDED_CHILD_COUNT_DEFAULT = 3; @VisibleForTesting static final String KEY_WIFI_TETHER_NETWORK_NAME = "wifi_tether_network_name"; @@ -204,10 +203,6 @@ public class WifiTetherSettings extends RestrictedDashboardFragment mSwitchBarController.stopTether(); } mWifiManager.setSoftApConfiguration(config); - - if (context instanceof WifiTetherSecurityPreferenceController) { - reConfigInitialExpandedChildCount(); - } } private SoftApConfiguration buildNewConfig() { @@ -287,11 +282,4 @@ public class WifiTetherSettings extends RestrictedDashboardFragment } } } - - private void reConfigInitialExpandedChildCount() { - final PreferenceGroup screen = getPreferenceScreen(); - if (screen != null) { - screen.setInitialExpandedChildrenCount(getInitialExpandedChildCount()); - } - } } diff --git a/tests/robotests/src/com/android/settings/bluetooth/BluetoothFilesPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/bluetooth/BluetoothFilesPreferenceControllerTest.java deleted file mode 100644 index 40489983acc..00000000000 --- a/tests/robotests/src/com/android/settings/bluetooth/BluetoothFilesPreferenceControllerTest.java +++ /dev/null @@ -1,74 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.settings.bluetooth; - -import static com.google.common.truth.Truth.assertThat; - -import static org.mockito.Mockito.doReturn; -import static org.mockito.Mockito.spy; - -import android.content.Context; -import android.content.Intent; -import android.content.pm.PackageManager; -import android.os.Bundle; - -import androidx.preference.Preference; - -import org.junit.Before; -import org.junit.Test; -import org.junit.runner.RunWith; -import org.mockito.Mock; -import org.mockito.MockitoAnnotations; -import org.robolectric.RobolectricTestRunner; -import org.robolectric.RuntimeEnvironment; -import org.robolectric.shadows.ShadowApplication; - -@RunWith(RobolectricTestRunner.class) -public class BluetoothFilesPreferenceControllerTest { - - private Context mContext; - private BluetoothFilesPreferenceController mController; - private Preference mPreference; - @Mock - private PackageManager mPackageManager; - - @Before - public void setUp() { - MockitoAnnotations.initMocks(this); - mContext = spy(RuntimeEnvironment.application); - mController = new BluetoothFilesPreferenceController(mContext); - mPreference = new Preference(mContext); - mPreference.setKey(BluetoothFilesPreferenceController.KEY_RECEIVED_FILES); - doReturn(mPackageManager).when(mContext).getPackageManager(); - doReturn(true).when(mPackageManager).hasSystemFeature(PackageManager.FEATURE_BLUETOOTH); - } - - @Test - public void testHandlePreferenceTreeClick_sendBroadcast() { - mController.handlePreferenceTreeClick(mPreference); - - final Intent intent = ShadowApplication.getInstance().getNextStartedActivity(); - assertThat(intent).isNotNull(); - assertThat(intent.getAction()) - .isEqualTo(BluetoothFilesPreferenceController.ACTION_OPEN_FILES); - - final Bundle bundle = intent.getExtras(); - assertThat(bundle.getInt(BluetoothFilesPreferenceController.EXTRA_DIRECTION)).isEqualTo(1); - assertThat(bundle.getBoolean(BluetoothFilesPreferenceController.EXTRA_SHOW_ALL_FILES)) - .isTrue(); - } -} diff --git a/tests/robotests/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetailTest.java b/tests/robotests/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetailTest.java index a2e78c3a2b5..3501726bc1a 100644 --- a/tests/robotests/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetailTest.java +++ b/tests/robotests/src/com/android/settings/fuelgauge/AdvancedPowerUsageDetailTest.java @@ -437,6 +437,21 @@ public class AdvancedPowerUsageDetailTest { .isEqualTo("No usage for past 24 hr"); } + @Test + public void testInitHeader_noUsageTimeButConsumedPower_hasEmptySummary() { + Bundle bundle = new Bundle(3); + bundle.putLong(AdvancedPowerUsageDetail.EXTRA_BACKGROUND_TIME, /* value */ 0); + bundle.putLong(AdvancedPowerUsageDetail.EXTRA_FOREGROUND_TIME, /* value */ 0); + bundle.putInt(AdvancedPowerUsageDetail.EXTRA_POWER_USAGE_AMOUNT, /* value */ 10); + when(mFragment.getArguments()).thenReturn(bundle); + + mFragment.initHeader(); + + ArgumentCaptor captor = ArgumentCaptor.forClass(CharSequence.class); + verify(mEntityHeaderController).setSummary(captor.capture()); + assertThat(captor.getValue().toString()).isEmpty(); + } + @Test public void testInitHeader_backgroundTwoMinForegroundZero_hasCorrectSummary() { final long backgroundTimeTwoMinutes = 120000;