From dce94bb23762aa8292cd1fc9a4ee69cde1fa886f Mon Sep 17 00:00:00 2001 From: tmfang Date: Mon, 26 Nov 2018 18:41:01 +0800 Subject: [PATCH] Use SettingsLib's LayoutPreference - Remove LayoutPreference in Settings source code. - Remove unused style, layout - Replace old imports to com.android.settingslib.widget.LayoutPreference - Replace old XML tag to com.android.settingslib.widget.LayoutPreference Test: robotest, manual test Bug: 120005054 Change-Id: I9ae1ae14a16f443e11ac5d75b6038c7c5e253844 --- res/layout/layout_preference_frame.xml | 18 --- res/layout/settings_entity_header.xml | 105 ---------------- res/values/styles.xml | 24 ---- res/xml/account_type_settings.xml | 4 +- res/xml/app_info_settings.xml | 4 +- res/xml/app_notification_settings.xml | 4 +- res/xml/app_storage_settings.xml | 4 +- res/xml/bluetooth_device_details_fragment.xml | 2 +- res/xml/channel_notification_settings.xml | 4 +- res/xml/dream_fragment_overview.xml | 2 +- res/xml/my_device_info.xml | 2 +- res/xml/night_display_settings.xml | 2 +- res/xml/notification_group_settings.xml | 4 +- res/xml/power_usage_detail.xml | 2 +- res/xml/power_usage_details.xml | 2 +- res/xml/power_usage_summary.xml | 2 +- res/xml/security_settings_face.xml | 2 +- res/xml/usb_details_fragment.xml | 2 +- res/xml/wifi_network_details_fragment.xml | 2 +- res/xml/zen_mode_event_rule_settings.xml | 4 +- res/xml/zen_mode_schedule_rule_settings.xml | 4 +- res/xml/zen_mode_settings.xml | 2 +- .../settings/SettingsPreferenceFragment.java | 2 +- .../AccountHeaderPreferenceController.java | 2 +- .../RemoveAccountPreferenceController.java | 2 +- .../applications/AppStorageSettings.java | 1 + .../applications/LayoutPreference.java | 119 ------------------ .../AppHeaderViewPreferenceController.java | 3 +- ...InstantAppButtonsPreferenceController.java | 2 +- ...tingsRemoveButtonPreferenceController.java | 2 +- .../BluetoothDetailsHeaderController.java | 2 +- .../usb/UsbDetailsHeaderController.java | 2 +- .../aboutphone/MyDeviceInfoFragment.java | 3 +- .../display/ColorModePreferenceFragment.java | 2 +- ...DisplayActivationPreferenceController.java | 2 +- .../dream/StartNowPreferenceController.java | 2 +- .../fuelgauge/AdvancedPowerUsageDetail.java | 2 +- .../BatteryHeaderPreferenceController.java | 2 +- .../settings/fuelgauge/PowerUsageSummary.java | 2 +- .../BlockPreferenceController.java | 2 +- .../HeaderPreferenceController.java | 2 +- .../NotificationSwitchBarPreference.java | 2 +- ...tomaticRuleHeaderPreferenceController.java | 14 +-- ...tomaticRuleSwitchPreferenceController.java | 2 +- .../ZenModeButtonPreferenceController.java | 2 +- .../widget/EntityHeaderController.java | 5 +- .../widget/TwoStateButtonPreference.java | 2 +- .../WifiDetailPreferenceController.java | 2 +- ...AccountHeaderPreferenceControllerTest.java | 2 +- ...RemoveAccountPreferenceControllerTest.java | 2 +- .../applications/AppInfoWithHeaderTest.java | 1 + .../applications/LayoutPreferenceTest.java | 93 -------------- ...AppHeaderViewPreferenceControllerTest.java | 2 +- ...antAppButtonsPreferenceControllerTest.java | 2 +- .../BluetoothDetailsHeaderControllerTest.java | 2 +- .../usb/UsbDetailsHeaderControllerTest.java | 2 +- .../ColorModePreferenceFragmentTest.java | 2 +- ...layActivationPreferenceControllerTest.java | 2 +- .../StartNowPreferenceControllerTest.java | 2 +- .../AdvancedPowerUsageDetailTest.java | 2 +- ...BatteryHeaderPreferenceControllerTest.java | 2 +- .../fuelgauge/PowerUsageSummaryTest.java | 2 +- .../BlockPreferenceControllerTest.java | 2 +- .../HeaderPreferenceControllerTest.java | 2 +- .../SettingsRobolectricTestRunner.java | 2 + .../widget/EntityHeaderControllerTest.java | 2 +- .../WifiDetailPreferenceControllerTest.java | 2 +- 67 files changed, 78 insertions(+), 436 deletions(-) delete mode 100644 res/layout/layout_preference_frame.xml delete mode 100644 res/layout/settings_entity_header.xml delete mode 100644 src/com/android/settings/applications/LayoutPreference.java delete mode 100644 tests/robotests/src/com/android/settings/applications/LayoutPreferenceTest.java diff --git a/res/layout/layout_preference_frame.xml b/res/layout/layout_preference_frame.xml deleted file mode 100644 index eec3d7af345..00000000000 --- a/res/layout/layout_preference_frame.xml +++ /dev/null @@ -1,18 +0,0 @@ - - diff --git a/res/layout/settings_entity_header.xml b/res/layout/settings_entity_header.xml deleted file mode 100644 index 5f5fe004a99..00000000000 --- a/res/layout/settings_entity_header.xml +++ /dev/null @@ -1,105 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/res/values/styles.xml b/res/values/styles.xml index 3ce11931eb4..4be1bb3569e 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -331,23 +331,6 @@ ?android:attr/textColorSecondary - - - - - -