From dc80bddc1ef9f26db9ba37d52f3d76f2af7edf9b Mon Sep 17 00:00:00 2001 From: Jacky Wang Date: Wed, 11 Dec 2024 16:22:49 +0800 Subject: [PATCH] [Catalyst] Partially revert ag/30664694 The preference is not yet migrated, we should not update fragment based on current flag rollout plan. Bug: 368355361 Bug: 368359963 Flag: com.android.settings.flags.catalyst_tether_settings Test: manual Change-Id: I89a5d2ee29e1c3428d40428b3d3d4ba3afcd4ece --- .../network/tether/TetherSettings.java | 29 +++++++------------ 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/com/android/settings/network/tether/TetherSettings.java b/src/com/android/settings/network/tether/TetherSettings.java index 57715be94db..53de9f65bed 100644 --- a/src/com/android/settings/network/tether/TetherSettings.java +++ b/src/com/android/settings/network/tether/TetherSettings.java @@ -72,7 +72,6 @@ import java.util.HashSet; import java.util.List; import java.util.concurrent.atomic.AtomicReference; -// LINT.IfChange /** * Displays preferences for Tethering. */ @@ -209,19 +208,16 @@ public class TetherSettings extends RestrictedDashboardFragment mWifiTetherPreferenceController.displayPreference(getPreferenceScreen()); } - if (!isCatalystEnabled()) { - if (!bluetoothAvailable) { - mBluetoothTether.setVisible(false); + if (!bluetoothAvailable) { + getPreferenceScreen().removePreference(mBluetoothTether); + } else { + BluetoothPan pan = mBluetoothPan.get(); + if (pan != null && pan.isTetheringOn()) { + mBluetoothTether.setChecked(true); } else { - BluetoothPan pan = mBluetoothPan.get(); - if (pan != null && pan.isTetheringOn()) { - mBluetoothTether.setChecked(true); - } else { - mBluetoothTether.setChecked(false); - } + mBluetoothTether.setChecked(false); } } - if (!ethernetAvailable) getPreferenceScreen().removePreference(mEthernetTether); // Set initial state based on Data Saver mode. onDataSaverChanged(mDataSaverBackend.isDataSaverEnabled()); @@ -274,9 +270,7 @@ public class TetherSettings extends RestrictedDashboardFragment mWifiTetherPreferenceController.setDataSaverEnabled(mDataSaverEnabled); } mUsbTether.setEnabled(!mDataSaverEnabled); - if (!isCatalystEnabled()) { - mBluetoothTether.setEnabled(!mDataSaverEnabled); - } + mBluetoothTether.setEnabled(!mDataSaverEnabled); mEthernetTether.setEnabled(!mDataSaverEnabled); mDataSaverFooter.setVisible(mDataSaverEnabled); } @@ -526,8 +520,6 @@ public class TetherSettings extends RestrictedDashboardFragment } private void updateBluetoothState() { - if (isCatalystEnabled()) return; - final int btState = getBluetoothState(); if (DEBUG) { Log.d(TAG, "updateBluetoothState() btState : " + btState); @@ -583,7 +575,7 @@ public class TetherSettings extends RestrictedDashboardFragment } private void startTethering(int choice) { - if (choice == TETHERING_BLUETOOTH && !isCatalystEnabled()) { + if (choice == TETHERING_BLUETOOTH) { // Turn on Bluetooth first. BluetoothAdapter adapter = BluetoothAdapter.getDefaultAdapter(); if (adapter.getState() == BluetoothAdapter.STATE_OFF) { @@ -605,7 +597,7 @@ public class TetherSettings extends RestrictedDashboardFragment } else { mCm.stopTethering(TETHERING_USB); } - } else if (preference == mBluetoothTether && !isCatalystEnabled()) { + } else if (preference == mBluetoothTether) { if (mBluetoothTether.isChecked()) { startTethering(TETHERING_BLUETOOTH); } else { @@ -753,4 +745,3 @@ public class TetherSettings extends RestrictedDashboardFragment return TetherScreen.KEY; } } -// LINT.ThenChange(BluetoothTetherSwitchPreference.kt)