From 8850c3c677fe912640f3673739b6acbdd993c1d5 Mon Sep 17 00:00:00 2001 From: Matt Pietal Date: Thu, 6 May 2021 08:35:13 -0400 Subject: [PATCH] Wallet/controls - Migrate existing settings Step 2 of 2. Move wallet settings from System -> Gestures -> Power Menu to Display -> Lockscreen. Split the existing sensitivity setting into two separate toggles to give users better control of their privacy settings. Bug: 185597511 Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.display Change-Id: Ifc390945a45258bbcc3c0a6ac67a0c4a3f7a9e91 --- AndroidManifest.xml | 11 -- res/values/strings.xml | 44 ++--- res/xml/global_actions_panel_settings.xml | 36 ----- res/xml/power_menu_settings.xml | 15 -- res/xml/security_lockscreen_settings.xml | 13 +- src/com/android/settings/Settings.java | 2 - .../core/gateway/SettingsGateway.java | 2 - .../ControlsPrivacyPreferenceController.java} | 39 ++--- .../WalletPrivacyPreferenceController.java | 95 +++++++++++ .../gestures/GlobalActionsPanelSettings.java | 48 ------ .../PowerMenuPreferenceController.java | 24 +-- ...trolsPrivacyPreferenceControllerTest.java} | 67 +++----- ...WalletPrivacyPreferenceControllerTest.java | 151 ++++++++++++++++++ ...erMenuPreferenceControllerSummaryTest.java | 86 ---------- .../PowerMenuPreferenceControllerTest.java | 42 +---- ...yPreferenceControllerAvailabilityTest.java | 116 -------------- 16 files changed, 305 insertions(+), 486 deletions(-) delete mode 100644 res/xml/global_actions_panel_settings.xml rename src/com/android/settings/{gestures/PowerMenuPrivacyPreferenceController.java => display/ControlsPrivacyPreferenceController.java} (59%) create mode 100644 src/com/android/settings/display/WalletPrivacyPreferenceController.java delete mode 100644 src/com/android/settings/gestures/GlobalActionsPanelSettings.java rename tests/robotests/src/com/android/settings/{gestures/PowerMenuPrivacyPreferenceControllerTest.java => display/ControlsPrivacyPreferenceControllerTest.java} (65%) create mode 100644 tests/robotests/src/com/android/settings/display/WalletPrivacyPreferenceControllerTest.java delete mode 100644 tests/robotests/src/com/android/settings/gestures/PowerMenuPreferenceControllerSummaryTest.java delete mode 100644 tests/robotests/src/com/android/settings/gestures/PowerMenuPrivacyPreferenceControllerAvailabilityTest.java diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 9b11fe81c98..05dd0839f08 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -3682,17 +3682,6 @@ android:value="com.android.settings.fuelgauge.batterysaver.BatterySaverScheduleSettings" /> - - - - - - - - diff --git a/res/values/strings.xml b/res/values/strings.xml index 8368b4647e8..ed7afbadd16 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -8082,8 +8082,7 @@ work challenge, work, profile work profile, managed profile, unify, unification, work, profile gestures - cards, passes - device controls, controls + wallet pay, tap, payments backup, back up gesture @@ -12979,32 +12978,11 @@ Power button menu - - Show cards & passes - - - Lock screen - Don\u2019t show any content - - Sensitive content - - - Show cards and controls when locked - - - Show controls when locked - - - Show cards when locked - - - Hide cards and controls when locked - - To use, first set a screen lock + To use, first set a screen lock Hold for Assistant @@ -13012,17 +12990,15 @@ Trigger the Assistant by holding the power button + + Show wallet + + Allow access to wallet from lock screen and quick settings + - Show device controls - - - Show cards & passes - - - To access controls for connected devices, hold the Power button - - - To access things like your payment methods and boarding passes, press and hold the Power button. + Show device controls + + Access controls when locked diff --git a/res/xml/global_actions_panel_settings.xml b/res/xml/global_actions_panel_settings.xml deleted file mode 100644 index e49c0d2b0d7..00000000000 --- a/res/xml/global_actions_panel_settings.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - - - - diff --git a/res/xml/power_menu_settings.xml b/res/xml/power_menu_settings.xml index 406cd0b3708..f88531e3802 100644 --- a/res/xml/power_menu_settings.xml +++ b/res/xml/power_menu_settings.xml @@ -26,19 +26,4 @@ android:summary="@string/power_menu_long_press_for_assist_summary" settings:controller="com.android.settings.gestures.LongPressPowerButtonPreferenceController" /> - - - - - - - diff --git a/res/xml/security_lockscreen_settings.xml b/res/xml/security_lockscreen_settings.xml index 8962fc2cf74..82cb8609114 100644 --- a/res/xml/security_lockscreen_settings.xml +++ b/res/xml/security_lockscreen_settings.xml @@ -46,11 +46,16 @@ android:summary="@string/owner_info_settings_summary" /> + android:key="lockscreen_privacy_wallet_switch" + android:title="@string/lockscreen_privacy_wallet_setting_toggle" + android:summary="@string/lockscreen_privacy_wallet_summary" + settings:controller="com.android.settings.display.WalletPrivacyPreferenceController" /> +