PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prevent app bar title from drawing twice

Browse Source 
Sometimes we could see a flick problem with app bar title. It appears to
draw the app bar title twice. This CL is to prevent app bar title from
rendering twice.

Bug: 182232144
Test: robotests and visual verified
1) Open Settings app
2) Click on any entrypoint
3) Observe and see if there's a flick problem on app bar title

Change-Id: I9f5b7cdd163f20dd7f85cf2f83b9ef01a473dd3c
This commit is contained in:
Mill Chen
2021-03-09 15:10:22 +08:00
parent 50527b1f63
commit db5ca4ee1a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/android/settings/core/SettingsBaseActivity.java
View File

@@ -184,16 +184,18 @@ public class SettingsBaseActivity extends FragmentActivity {
public void setTitle(CharSequence title) { public void setTitle(CharSequence title) {
if (mCollapsingToolbarLayout != null) { if (mCollapsingToolbarLayout != null) {
mCollapsingToolbarLayout.setTitle(title); mCollapsingToolbarLayout.setTitle(title);
} else {
super.setTitle(title);
} }
super.setTitle(title);
} }
@Override @Override
public void setTitle(int titleId) { public void setTitle(int titleId) {
if (mCollapsingToolbarLayout != null) { if (mCollapsingToolbarLayout != null) {
mCollapsingToolbarLayout.setTitle(getText(titleId)); mCollapsingToolbarLayout.setTitle(getText(titleId));
} else {
super.setTitle(titleId);
} }
super.setTitle(titleId);
} }
/** /**