PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Migrate UnrestrictedDataAccess to DashboardFragment

Browse Source 
- UnrestrictedDataAccessPreferenceController

Test: make RunSettingsRoboTests -j ROBOTEST_FILTER=com.android.settings.datausage
      make RunSettingsRoboTests -j ROBOTEST_FILTER=CodeInspectionTest
      atest UniquePreferenceTest

Change-Id: I71abd837ef51e4e9e0a2ee46791d704245c9b3ab
This commit is contained in:
Yanting_Yang
2018-04-19 21:09:44 +08:00
committed by Fan Zhang
parent d43283b53a
commit db435e256d
7 changed files with 508 additions and 335 deletions
Download Patch File Download Diff File Expand all files Collapse all files

103
tests/robotests/src/com/android/settings/datausage/UnrestrictedDataAccessTest.java → tests/robotests/src/com/android/settings/datausage/UnrestrictedDataAccessPreferenceControllerTest.java
View File

@@ -1,5 +1,5 @@
/*
* Copyright (C) 2016 The Android Open Source Project
* Copyright (C) 2018 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@ import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.doAnswer;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
@@ -35,11 +36,12 @@ import androidx.preference.PreferenceScreen;
import com.android.internal.logging.nano.MetricsProto;
import com.android.settings.R;
import com.android.settings.applications.AppStateBaseBridge;
import com.android.settings.datausage.AppStateDataUsageBridge.DataUsageState;
import com.android.settings.datausage.UnrestrictedDataAccess.AccessPreference;
import com.android.settings.testutils.FakeFeatureFactory;
import com.android.settings.testutils.SettingsRobolectricTestRunner;
import com.android.settings.testutils.shadow.ShadowRestrictedLockUtils;
import com.android.settingslib.applications.ApplicationsState;
import com.android.settingslib.applications.ApplicationsState.AppEntry;
import org.junit.Before;
@@ -49,77 +51,85 @@ import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.annotation.Config;
import org.robolectric.annotation.Implements;
import org.robolectric.util.ReflectionHelpers;
import java.util.ArrayList;
@RunWith(SettingsRobolectricTestRunner.class)
@Config(shadows = ShadowRestrictedLockUtils.class)
public class UnrestrictedDataAccessTest {
@Config(shadows = {
ShadowRestrictedLockUtils.class,
UnrestrictedDataAccessPreferenceControllerTest.ShadowAppStateBaseBridge.class
})
public class UnrestrictedDataAccessPreferenceControllerTest {
@Mock
private ApplicationsState mState;
@Mock
private ApplicationsState.Session mSession;
@Mock
private AppEntry mAppEntry;
private UnrestrictedDataAccess mFragment;
private Context mContext;
private FakeFeatureFactory mFeatureFactory;
@Mock
private PreferenceScreen mPreferenceScreen;
@Mock
private PreferenceManager mPreferenceManager;
@Mock
private DataSaverBackend mDataSaverBackend;
private PreferenceScreen mPreferenceScreen;
private UnrestrictedDataAccess mFragment;
private UnrestrictedDataAccessPreferenceController mController;
@Before
public void setUp() {
MockitoAnnotations.initMocks(this);
mContext = RuntimeEnvironment.application;
mFeatureFactory = FakeFeatureFactory.setupForTest();
mFragment = spy(new UnrestrictedDataAccess());
ReflectionHelpers.setStaticField(ApplicationsState.class, "sInstance", mState);
when(mState.newSession(any())).thenReturn(mSession);
mController = spy(new UnrestrictedDataAccessPreferenceController(mContext, "pref_key"));
}
@Test
public void testShouldAddPreferenceForApps() {
mAppEntry.info = new ApplicationInfo();
mAppEntry.info.uid = Process.FIRST_APPLICATION_UID + 10;
assertThat(mFragment.shouldAddPreference(mAppEntry)).isTrue();
public void shouldAddPreference_forApps_shouldBeTrue() {
final int uid = Process.FIRST_APPLICATION_UID + 10;
final AppEntry entry = createAppEntry(uid);
assertThat(UnrestrictedDataAccessPreferenceController.shouldAddPreference(entry)).isTrue();
}
@Test
public void testShouldNotAddPreferenceForNonApps() {
mAppEntry.info = new ApplicationInfo();
mAppEntry.info.uid = Process.FIRST_APPLICATION_UID - 10;
assertThat(mFragment.shouldAddPreference(mAppEntry)).isFalse();
public void shouldAddPreference_forNonApps_shouldBeFalse() {
final int uid = Process.FIRST_APPLICATION_UID - 10;
final AppEntry entry = createAppEntry(uid);
assertThat(UnrestrictedDataAccessPreferenceController.shouldAddPreference(entry)).isFalse();
}
@Test
public void logSpecialPermissionChange() {
mFragment.logSpecialPermissionChange(true, "app");
mController.logSpecialPermissionChange(true, "app");
verify(mFeatureFactory.metricsFeatureProvider).action(nullable(Context.class),
eq(MetricsProto.MetricsEvent.APP_SPECIAL_PERMISSION_UNL_DATA_ALLOW), eq("app"));
mFragment.logSpecialPermissionChange(false, "app");
mController.logSpecialPermissionChange(false, "app");
verify(mFeatureFactory.metricsFeatureProvider).action(nullable(Context.class),
eq(MetricsProto.MetricsEvent.APP_SPECIAL_PERMISSION_UNL_DATA_DENY), eq("app"));
}
@Test
public void testOnRebuildComplete_restricted_shouldBeDisabled() {
final Context context = RuntimeEnvironment.application;
doReturn(context).when(mFragment).getContext();
when(mPreferenceManager.getContext()).thenReturn(context);
doReturn(true).when(mFragment).shouldAddPreference(any(AppEntry.class));
public void onRebuildComplete_restricted_shouldBeDisabled() {
mFragment = spy(new UnrestrictedDataAccess());
doNothing().when(mFragment).setLoading(anyBoolean(), anyBoolean());
mController.setParentFragment(mFragment);
mPreferenceManager = new PreferenceManager(mContext);
mPreferenceScreen = spy(mPreferenceManager.createPreferenceScreen(mContext));
doReturn(mPreferenceManager).when(mFragment).getPreferenceManager();
doReturn(mPreferenceScreen).when(mFragment).getPreferenceScreen();
when(mFragment.getPreferenceManager()).thenReturn(mPreferenceManager);
ReflectionHelpers.setField(mFragment, "mDataSaverBackend", mDataSaverBackend);
doReturn(0).when(mPreferenceScreen).getPreferenceCount();
final DataSaverBackend dataSaverBackend = mock(DataSaverBackend.class);
ReflectionHelpers.setField(mController, "mDataSaverBackend", dataSaverBackend);
ReflectionHelpers.setField(mController, "mScreen", mPreferenceScreen);
final String testPkg1 = "com.example.one";
final String testPkg2 = "com.example.two";
ShadowRestrictedLockUtils.setRestrictedPkgs(testPkg2);
doAnswer((invocation) -> {
final AccessPreference preference = invocation.getArgument(0);
final AppEntry entry = preference.getEntryForTest();
final UnrestrictedDataAccessPreference preference = invocation.getArgument(0);
final AppEntry entry = preference.getEntry();
// Verify preference is disabled by admin and the summary is changed accordingly.
if (testPkg1.equals(entry.info.packageName)) {
assertThat(preference.isDisabledByAdmin()).isFalse();
@@ -127,7 +137,7 @@ public class UnrestrictedDataAccessTest {
} else if (testPkg2.equals(entry.info.packageName)) {
assertThat(preference.isDisabledByAdmin()).isTrue();
assertThat(preference.getSummary()).isEqualTo(
context.getString(R.string.disabled_by_admin));
mContext.getString(R.string.disabled_by_admin));
}
assertThat(preference.isChecked()).isFalse();
preference.performClick();
@@ -144,8 +154,9 @@ public class UnrestrictedDataAccessTest {
}
ShadowRestrictedLockUtils.clearAdminSupportDetailsIntentLaunch();
return null;
}).when(mPreferenceScreen).addPreference(any(AccessPreference.class));
mFragment.onRebuildComplete(createAppEntries(testPkg1, testPkg2));
}).when(mPreferenceScreen).addPreference(any(UnrestrictedDataAccessPreference.class));
mController.onRebuildComplete(createAppEntries(testPkg1, testPkg2));
}
private ArrayList<AppEntry> createAppEntries(String... packageNames) {
@@ -155,7 +166,7 @@ public class UnrestrictedDataAccessTest {
info.packageName = packageNames[i];
info.uid = Process.FIRST_APPLICATION_UID + i;
info.sourceDir = info.packageName;
final AppEntry appEntry = spy(new AppEntry(RuntimeEnvironment.application, info, i));
final AppEntry appEntry = spy(new AppEntry(mContext, info, i));
appEntry.extraInfo = new DataUsageState(false, false);
doNothing().when(appEntry).ensureLabel(any(Context.class));
ReflectionHelpers.setField(appEntry, "info", info);
@@ -163,4 +174,20 @@ public class UnrestrictedDataAccessTest {
}
return appEntries;
}
private AppEntry createAppEntry(int uid) {
final ApplicationInfo info = new ApplicationInfo();
info.packageName = "com.example.three";
info.uid = uid;
info.sourceDir = info.packageName;
return new AppEntry(mContext, info, uid);
}
@Implements(AppStateBaseBridge.class)
public static class ShadowAppStateBaseBridge {
public void __constructor__(ApplicationsState appState,
AppStateBaseBridge.Callback callback) {
}
}
}