PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleaning up Font Size QS tile tooltip

Browse Source 
Cleaning up Font Size QS tile tooltip in the Settings page in onDestroy
to avoid leaking the window.

Bug: 279547549
Bug: 279549685
Test: manually check only one tooltip exist
Change-Id: Icafa2109af316989330bda5ed831c2f746e7968b
This commit is contained in:
Candice Lo
2023-05-16 02:44:39 +00:00
parent d263a5921f
commit dad011f5ba
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/com/android/settings/accessibility/PreviewSizeSeekBarController.java
View File

@@ -28,7 +28,6 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.widget.LabeledSeekBarPreference; import com.android.settings.widget.LabeledSeekBarPreference;
import com.android.settings.widget.SeekBarPreference;
import com.android.settingslib.core.lifecycle.LifecycleObserver; import com.android.settingslib.core.lifecycle.LifecycleObserver;
import com.android.settingslib.core.lifecycle.events.OnCreate; import com.android.settingslib.core.lifecycle.events.OnCreate;
import com.android.settingslib.core.lifecycle.events.OnDestroy; import com.android.settingslib.core.lifecycle.events.OnDestroy;
@@ -111,6 +110,10 @@ abstract class PreviewSizeSeekBarController extends BasePreferenceController imp
public void onDestroy() { public void onDestroy() {
// remove runnables in the queue. // remove runnables in the queue.
mHandler.removeCallbacksAndMessages(null); mHandler.removeCallbacksAndMessages(null);
final boolean isTooltipWindowShowing = mTooltipWindow != null && mTooltipWindow.isShowing();
if (isTooltipWindowShowing) {
mTooltipWindow.dismiss();
}
} }
@Override @Override