From 232b3ac12a5349e4b0a7906752a81622c6e8ae67 Mon Sep 17 00:00:00 2001 From: Tsung-Mao Fang Date: Thu, 17 Jun 2021 18:25:12 +0800 Subject: [PATCH] Disable the scrollable ability on app bar area As title, we do not allow user can scroll app bar while the search menu is expanding. So, we can ignore all drag events on app bar. Test: Can not scroll on the app bar area Fix: 181741353 Change-Id: I20c0b69059cdc4d13a15abd810a725d4591f6396 --- .../datetime/timezone/BaseTimeZonePicker.java | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java b/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java index 6032abd9b17..6ce9f6f9ae8 100644 --- a/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java +++ b/src/com/android/settings/datetime/timezone/BaseTimeZonePicker.java @@ -27,6 +27,8 @@ import android.widget.LinearLayout; import android.widget.SearchView; import android.widget.TextView; +import androidx.annotation.NonNull; +import androidx.coordinatorlayout.widget.CoordinatorLayout; import androidx.core.view.ViewCompat; import androidx.recyclerview.widget.LinearLayoutManager; import androidx.recyclerview.widget.RecyclerView; @@ -95,6 +97,7 @@ public abstract class BaseTimeZonePicker extends InstrumentedFragment LinearLayoutManager.VERTICAL, /* reverseLayout */ false)); mRecyclerView.setAdapter(mAdapter); mAppBarLayout = getActivity().findViewById(R.id.app_bar); + disableToolBarScrollableBehavior(); // Initialize TimeZoneDataLoader only when mRecyclerView is ready to avoid race // during onDateLoaderReady callback. @@ -160,13 +163,15 @@ public abstract class BaseTimeZonePicker extends InstrumentedFragment public boolean onMenuItemActionExpand(MenuItem item) { // To prevent a large space on tool bar. mAppBarLayout.setExpanded(false /*expanded*/, false /*animate*/); - // To prevent user can expand the collpasing tool bar view. + // To prevent user can expand the collapsing tool bar view. ViewCompat.setNestedScrollingEnabled(mRecyclerView, false); return true; } @Override public boolean onMenuItemActionCollapse(MenuItem item) { + // We keep the collapsed status after user cancel the search function. + mAppBarLayout.setExpanded(false /*expanded*/, false /*animate*/); ViewCompat.setNestedScrollingEnabled(mRecyclerView, true); return true; } @@ -188,4 +193,17 @@ public abstract class BaseTimeZonePicker extends InstrumentedFragment void onListItemClick(T item); } + private void disableToolBarScrollableBehavior() { + CoordinatorLayout.LayoutParams params = + (CoordinatorLayout.LayoutParams) mAppBarLayout.getLayoutParams(); + AppBarLayout.Behavior behavior = new AppBarLayout.Behavior(); + behavior.setDragCallback( + new AppBarLayout.Behavior.DragCallback() { + @Override + public boolean canDrag(@NonNull AppBarLayout appBarLayout) { + return false; + } + }); + params.setBehavior(behavior); + } }