From da847e7f00eaef99db986812402b712285c73f59 Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Thu, 24 Nov 2022 16:40:42 +0800 Subject: [PATCH] Fix SettingsHomepageActivity crash during configuration change Attempt to remove the animator to avoid a RecyclerView crash. Bug: 260208703 Test: compile Change-Id: I568cf964107f832fde4d82306fc84772bb208e20 --- .../android/settings/homepage/TopLevelHighlightMixin.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/homepage/TopLevelHighlightMixin.java b/src/com/android/settings/homepage/TopLevelHighlightMixin.java index 4718443f8a4..db099cbfb98 100644 --- a/src/com/android/settings/homepage/TopLevelHighlightMixin.java +++ b/src/com/android/settings/homepage/TopLevelHighlightMixin.java @@ -114,9 +114,14 @@ public class TopLevelHighlightMixin implements Parcelable, DialogInterface.OnSho } Log.d(TAG, "onCreateAdapter, pref key: " + mCurrentKey); + + // Remove the animator to avoid a RecyclerView crash. + RecyclerView recyclerView = topLevelSettings.getListView(); + recyclerView.setItemAnimator(null); + mTopLevelAdapter = new HighlightableTopLevelPreferenceAdapter( (SettingsHomepageActivity) topLevelSettings.getActivity(), preferenceScreen, - topLevelSettings.getListView(), mCurrentKey, scrollNeeded); + recyclerView, mCurrentKey, scrollNeeded); return mTopLevelAdapter; }