Revert "Refactor BiometricEnrollBase::onStop()"
This reverts commit 6b6d8c0d6d
.
Reason for revert: Should use shouldFinishWhenBackgrounded() to
control the behavior during onStop()
Bug: 197717071
Change-Id: I6aeacd5fb0d4400911a2e3d1567db660a0f1798a
This commit is contained in:
@@ -181,6 +181,16 @@ public abstract class BiometricEnrollBase extends InstrumentedActivity {
|
|||||||
getWindow().setStatusBarColor(getBackgroundColor());
|
getWindow().setStatusBarColor(getBackgroundColor());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
protected void onStop() {
|
||||||
|
super.onStop();
|
||||||
|
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
||||||
|
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
||||||
|
setResult(RESULT_TIMEOUT);
|
||||||
|
finish();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
protected boolean shouldFinishWhenBackgrounded() {
|
protected boolean shouldFinishWhenBackgrounded() {
|
||||||
return !WizardManagerHelper.isAnySetupWizard(getIntent());
|
return !WizardManagerHelper.isAnySetupWizard(getIntent());
|
||||||
}
|
}
|
||||||
|
@@ -241,16 +241,6 @@ public abstract class BiometricEnrollIntroduction extends BiometricEnrollBase
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
protected void onStop() {
|
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected void onSaveInstanceState(Bundle outState) {
|
protected void onSaveInstanceState(Bundle outState) {
|
||||||
super.onSaveInstanceState(outState);
|
super.onSaveInstanceState(outState);
|
||||||
|
@@ -49,16 +49,6 @@ public class BiometricHandoffActivity extends BiometricEnrollBase {
|
|||||||
mFooterBarMixin.setPrimaryButton(getPrimaryFooterButton());
|
mFooterBarMixin.setPrimaryButton(getPrimaryFooterButton());
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
protected void onStop() {
|
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
|
||||||
|
|
||||||
@NonNull
|
@NonNull
|
||||||
protected FooterButton getPrimaryFooterButton() {
|
protected FooterButton getPrimaryFooterButton() {
|
||||||
if (mPrimaryFooterButton == null) {
|
if (mPrimaryFooterButton == null) {
|
||||||
|
@@ -62,11 +62,7 @@ public abstract class BiometricsEnrollEnrolling extends BiometricEnrollBase
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected void onStop() {
|
protected void onStop() {
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
super.onStop();
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
|
|
||||||
if (mSidecar != null) {
|
if (mSidecar != null) {
|
||||||
mSidecar.setListener(null);
|
mSidecar.setListener(null);
|
||||||
@@ -84,7 +80,6 @@ public abstract class BiometricsEnrollEnrolling extends BiometricEnrollBase
|
|||||||
}
|
}
|
||||||
finish();
|
finish();
|
||||||
}
|
}
|
||||||
super.onStop();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -170,16 +170,6 @@ public class FaceEnrollEducation extends BiometricEnrollBase {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
protected void onStop() {
|
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected boolean shouldFinishWhenBackgrounded() {
|
protected boolean shouldFinishWhenBackgrounded() {
|
||||||
return super.shouldFinishWhenBackgrounded() && !mNextClicked;
|
return super.shouldFinishWhenBackgrounded() && !mNextClicked;
|
||||||
|
@@ -22,7 +22,6 @@ import android.view.View;
|
|||||||
|
|
||||||
import com.android.settings.R;
|
import com.android.settings.R;
|
||||||
import com.android.settings.biometrics.BiometricEnrollBase;
|
import com.android.settings.biometrics.BiometricEnrollBase;
|
||||||
import com.android.settings.biometrics.BiometricUtils;
|
|
||||||
|
|
||||||
import com.google.android.setupcompat.template.FooterBarMixin;
|
import com.google.android.setupcompat.template.FooterBarMixin;
|
||||||
import com.google.android.setupcompat.template.FooterButton;
|
import com.google.android.setupcompat.template.FooterButton;
|
||||||
@@ -49,16 +48,6 @@ public class FaceEnrollFinish extends BiometricEnrollBase {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
protected void onStop() {
|
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
public int getMetricsCategory() {
|
public int getMetricsCategory() {
|
||||||
return SettingsEnums.FACE_ENROLL_FINISHED;
|
return SettingsEnums.FACE_ENROLL_FINISHED;
|
||||||
|
@@ -249,15 +249,10 @@ public class FingerprintEnrollFindSensor extends BiometricEnrollBase implements
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected void onStop() {
|
protected void onStop() {
|
||||||
|
super.onStop();
|
||||||
if (mAnimation != null) {
|
if (mAnimation != null) {
|
||||||
mAnimation.pauseAnimation();
|
mAnimation.pauseAnimation();
|
||||||
}
|
}
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
|
@@ -108,16 +108,6 @@ public class FingerprintEnrollFinish extends BiometricEnrollBase {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@Override
|
|
||||||
protected void onStop() {
|
|
||||||
if (!isChangingConfigurations() && shouldFinishWhenBackgrounded()
|
|
||||||
&& !BiometricUtils.isAnyMultiBiometricFlow(this)) {
|
|
||||||
setResult(RESULT_TIMEOUT);
|
|
||||||
finish();
|
|
||||||
}
|
|
||||||
super.onStop();
|
|
||||||
}
|
|
||||||
|
|
||||||
@Override
|
@Override
|
||||||
protected void onNextButtonClick(View view) {
|
protected void onNextButtonClick(View view) {
|
||||||
updateFingerprintSuggestionEnableState();
|
updateFingerprintSuggestionEnableState();
|
||||||
|
Reference in New Issue
Block a user