Remove context from getSupportFeatureProvider

Bug: 286764889
Test: m Settings
Change-Id: I5635c7a809fd24d59da377993c7d1435d0c839e3

src/com/android/settings/overlay/FeatureFactory.kt

@@ -66,8 +66,11 @@ abstract class FeatureFactory {
      */
     abstract val hardwareInfoFeatureProvider: HardwareInfoFeatureProvider
 
-    abstract fun getSupportFeatureProvider(context: Context): SupportFeatureProvider?
+    /** Implementation for [SupportFeatureProvider]. */
+    open val supportFeatureProvider: SupportFeatureProvider? = null
+
     abstract val metricsFeatureProvider: MetricsFeatureProvider
+
     abstract fun getPowerUsageFeatureProvider(context: Context): PowerUsageFeatureProvider
 
     /**

src/com/android/settings/overlay/FeatureFactoryImpl.kt

@@ -95,8 +95,6 @@ open class FeatureFactoryImpl : FeatureFactory() {
     override val hardwareInfoFeatureProvider: HardwareInfoFeatureProvider =
         HardwareInfoFeatureProviderImpl
 
-    override fun getSupportFeatureProvider(context: Context): SupportFeatureProvider? = null
-
     override val metricsFeatureProvider by lazy { SettingsMetricsFeatureProvider() }
 
     override fun getPowerUsageFeatureProvider(context: Context) = powerUsageFeatureProvider

src/com/android/settings/support/SupportDashboardActivity.java

@@ -42,8 +42,8 @@ public class SupportDashboardActivity extends Activity implements Indexable {
     @Override
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
-        SupportFeatureProvider supportFeatureProvider = FeatureFactory.getFactory(this)
+        SupportFeatureProvider supportFeatureProvider = FeatureFactory.getFeatureFactory()
-                .getSupportFeatureProvider(this);
+                .getSupportFeatureProvider();
 
         // try to launch support if we have the feature provider
         if (supportFeatureProvider != null) {

src/com/android/settings/support/SupportPreferenceController.java

@@ -34,8 +34,7 @@ public class SupportPreferenceController extends BasePreferenceController {
 
     public SupportPreferenceController(Context context, String preferenceKey) {
         super(context, preferenceKey);
-        mSupportFeatureProvider = FeatureFactory.getFactory(context)
+        mSupportFeatureProvider = FeatureFactory.getFeatureFactory().getSupportFeatureProvider();
-                .getSupportFeatureProvider(context);
     }
 
     public void setActivity(Activity activity) {

tests/robotests/src/com/android/settings/testutils/FakeFeatureFactory.java

@@ -145,7 +145,7 @@ public class FakeFeatureFactory extends FeatureFactory {
     }
 
     @Override
-    public SupportFeatureProvider getSupportFeatureProvider(Context context) {
+    public SupportFeatureProvider getSupportFeatureProvider() {
         return supportFeatureProvider;
     }
 

tests/spa_unit/src/com/android/settings/testutils/FakeFeatureFactory.kt

@@ -69,10 +69,6 @@ class FakeFeatureFactory : FeatureFactory() {
     override val hardwareInfoFeatureProvider: HardwareInfoFeatureProvider
         get() = TODO("Not yet implemented")
 
-    override fun getSupportFeatureProvider(context: Context): SupportFeatureProvider? {
-        TODO("Not yet implemented")
-    }
-
     override val metricsFeatureProvider = mockMetricsFeatureProvider
 
     override fun getPowerUsageFeatureProvider(context: Context): PowerUsageFeatureProvider {

tests/unit/src/com/android/settings/testutils/FakeFeatureFactory.java

@@ -144,7 +144,7 @@ public class FakeFeatureFactory extends FeatureFactory {
     }
 
     @Override
-    public SupportFeatureProvider getSupportFeatureProvider(Context context) {
+    public SupportFeatureProvider getSupportFeatureProvider() {
         return supportFeatureProvider;
     }