Merge "Fix PhoneNumberPreferenceControllerTest" into main
This commit is contained in:
Chaohui Wang
Android (Google) Code Review
@@ -0,0 +1,135 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2024 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.deviceinfo
|
||||||
|
|
||||||
|
import android.content.Context
|
||||||
|
import android.telephony.SubscriptionInfo
|
||||||
|
import android.telephony.SubscriptionManager
|
||||||
|
import android.telephony.TelephonyManager
|
||||||
|
import androidx.preference.Preference
|
||||||
|
import androidx.preference.PreferenceCategory
|
||||||
|
import androidx.preference.PreferenceManager
|
||||||
|
import androidx.test.core.app.ApplicationProvider
|
||||||
|
import androidx.test.ext.junit.runners.AndroidJUnit4
|
||||||
|
import com.android.settings.R
|
||||||
|
import com.google.common.truth.Truth.assertThat
|
||||||
|
import org.junit.Before
|
||||||
|
import org.junit.Test
|
||||||
|
import org.junit.runner.RunWith
|
||||||
|
import org.mockito.kotlin.any
|
||||||
|
import org.mockito.kotlin.doReturn
|
||||||
|
import org.mockito.kotlin.mock
|
||||||
|
import org.mockito.kotlin.spy
|
||||||
|
import org.mockito.kotlin.verify
|
||||||
|
import org.mockito.kotlin.whenever
|
||||||
|
|
||||||
|
@RunWith(AndroidJUnit4::class)
|
||||||
|
class PhoneNumberPreferenceControllerTest {
|
||||||
|
|
||||||
|
private val mockTelephonyManager = mock<TelephonyManager>()
|
||||||
|
private val mockSubscriptionManager = mock<SubscriptionManager>()
|
||||||
|
|
||||||
|
private val context: Context =
|
||||||
|
spy(ApplicationProvider.getApplicationContext()) {
|
||||||
|
on { getSystemService(SubscriptionManager::class.java) } doReturn
|
||||||
|
mockSubscriptionManager
|
||||||
|
|
||||||
|
on { getSystemService(TelephonyManager::class.java) } doReturn mockTelephonyManager
|
||||||
|
}
|
||||||
|
|
||||||
|
private val subscriptionInfo = mock<SubscriptionInfo>()
|
||||||
|
private val preference = spy(Preference(context))
|
||||||
|
private val secondPreference = mock<Preference>()
|
||||||
|
private var category = PreferenceCategory(context)
|
||||||
|
private var preferenceScreen = PreferenceManager(context).createPreferenceScreen(context)
|
||||||
|
|
||||||
|
private var controller = spy(PhoneNumberPreferenceController(context, "phone_number"))
|
||||||
|
|
||||||
|
@Before
|
||||||
|
fun setup() {
|
||||||
|
preference.setKey(controller.preferenceKey)
|
||||||
|
preference.isVisible = true
|
||||||
|
preferenceScreen.addPreference(preference)
|
||||||
|
category.key = "basic_info_category"
|
||||||
|
preferenceScreen.addPreference(category)
|
||||||
|
|
||||||
|
doReturn(secondPreference).whenever(controller).createNewPreference(context)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun displayPreference_multiSim_shouldAddSecondPreference() {
|
||||||
|
whenever(mockTelephonyManager.phoneCount).thenReturn(2)
|
||||||
|
|
||||||
|
val sim1Preference = Preference(context)
|
||||||
|
category.addItemFromInflater(sim1Preference)
|
||||||
|
controller.displayPreference(preferenceScreen)
|
||||||
|
|
||||||
|
assertThat(category.preferenceCount).isEqualTo(2)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun updateState_singleSim_shouldUpdateTitleAndPhoneNumber() {
|
||||||
|
val phoneNumber = "1111111111"
|
||||||
|
doReturn(subscriptionInfo).whenever(controller).getSubscriptionInfo(any())
|
||||||
|
doReturn(phoneNumber).whenever(controller).getFormattedPhoneNumber(subscriptionInfo)
|
||||||
|
whenever(mockTelephonyManager.phoneCount).thenReturn(1)
|
||||||
|
controller.displayPreference(preferenceScreen)
|
||||||
|
|
||||||
|
controller.updateState(preference)
|
||||||
|
|
||||||
|
verify(preference).title = context.getString(R.string.status_number)
|
||||||
|
verify(preference).summary = phoneNumber
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun updateState_multiSim_shouldUpdateTitleAndPhoneNumberOfMultiplePreferences() {
|
||||||
|
val phoneNumber = "1111111111"
|
||||||
|
doReturn(subscriptionInfo).whenever(controller).getSubscriptionInfo(any())
|
||||||
|
doReturn(phoneNumber).whenever(controller).getFormattedPhoneNumber(subscriptionInfo)
|
||||||
|
whenever(mockTelephonyManager.phoneCount).thenReturn(2)
|
||||||
|
controller.displayPreference(preferenceScreen)
|
||||||
|
|
||||||
|
controller.updateState(preference)
|
||||||
|
|
||||||
|
verify(preference).title =
|
||||||
|
context.getString(R.string.status_number_sim_slot, 1 /* sim slot */)
|
||||||
|
verify(preference).summary = phoneNumber
|
||||||
|
verify(secondPreference).title =
|
||||||
|
context.getString(R.string.status_number_sim_slot, 2 /* sim slot */)
|
||||||
|
verify(secondPreference).summary = phoneNumber
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun getSummary_cannotGetActiveSubscriptionInfo_shouldShowNotAvailable() {
|
||||||
|
whenever(mockSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(null)
|
||||||
|
controller.displayPreference(preferenceScreen)
|
||||||
|
|
||||||
|
controller.updateState(preference)
|
||||||
|
|
||||||
|
verify(preference).summary = context.getString(R.string.device_info_not_available)
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
fun getSummary_getEmptySubscriptionInfo_shouldShowNotAvailable() {
|
||||||
|
whenever(mockSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(emptyList())
|
||||||
|
controller.displayPreference(preferenceScreen)
|
||||||
|
|
||||||
|
controller.updateState(preference)
|
||||||
|
|
||||||
|
verify(preference).summary = context.getString(R.string.device_info_not_available)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,158 +0,0 @@
|
|||||||
/*
|
|
||||||
* Copyright (C) 2017 The Android Open Source Project
|
|
||||||
*
|
|
||||||
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
||||||
* you may not use this file except in compliance with the License.
|
|
||||||
* You may obtain a copy of the License at
|
|
||||||
*
|
|
||||||
* http://www.apache.org/licenses/LICENSE-2.0
|
|
||||||
*
|
|
||||||
* Unless required by applicable law or agreed to in writing, software
|
|
||||||
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
||||||
* See the License for the specific language governing permissions and
|
|
||||||
* limitations under the License.
|
|
||||||
*/
|
|
||||||
|
|
||||||
package com.android.settings.deviceinfo;
|
|
||||||
|
|
||||||
import static com.google.common.truth.Truth.assertThat;
|
|
||||||
|
|
||||||
import static org.mockito.ArgumentMatchers.anyInt;
|
|
||||||
import static org.mockito.Mockito.doReturn;
|
|
||||||
import static org.mockito.Mockito.spy;
|
|
||||||
import static org.mockito.Mockito.verify;
|
|
||||||
import static org.mockito.Mockito.when;
|
|
||||||
|
|
||||||
import android.content.Context;
|
|
||||||
import android.os.Looper;
|
|
||||||
import android.telephony.SubscriptionInfo;
|
|
||||||
import android.telephony.SubscriptionManager;
|
|
||||||
import android.telephony.TelephonyManager;
|
|
||||||
|
|
||||||
import androidx.preference.Preference;
|
|
||||||
import androidx.preference.PreferenceCategory;
|
|
||||||
import androidx.preference.PreferenceManager;
|
|
||||||
import androidx.preference.PreferenceScreen;
|
|
||||||
import androidx.test.core.app.ApplicationProvider;
|
|
||||||
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
|
||||||
|
|
||||||
import com.android.settings.R;
|
|
||||||
import com.android.settings.testutils.ResourcesUtils;
|
|
||||||
|
|
||||||
import org.junit.Before;
|
|
||||||
import org.junit.Test;
|
|
||||||
import org.junit.runner.RunWith;
|
|
||||||
import org.mockito.Mock;
|
|
||||||
import org.mockito.MockitoAnnotations;
|
|
||||||
|
|
||||||
import java.util.ArrayList;
|
|
||||||
import java.util.List;
|
|
||||||
|
|
||||||
@RunWith(AndroidJUnit4.class)
|
|
||||||
public class PhoneNumberPreferenceControllerTest {
|
|
||||||
|
|
||||||
private Preference mPreference;
|
|
||||||
@Mock
|
|
||||||
private Preference mSecondPreference;
|
|
||||||
@Mock
|
|
||||||
private TelephonyManager mTelephonyManager;
|
|
||||||
@Mock
|
|
||||||
private SubscriptionInfo mSubscriptionInfo;
|
|
||||||
@Mock
|
|
||||||
private SubscriptionManager mSubscriptionManager;
|
|
||||||
private PreferenceCategory mCategory;
|
|
||||||
private PreferenceScreen mScreen;
|
|
||||||
|
|
||||||
private Context mContext;
|
|
||||||
private PhoneNumberPreferenceController mController;
|
|
||||||
|
|
||||||
@Before
|
|
||||||
public void setup() {
|
|
||||||
MockitoAnnotations.initMocks(this);
|
|
||||||
mContext = spy(ApplicationProvider.getApplicationContext());
|
|
||||||
when(mContext.getSystemService(SubscriptionManager.class)).thenReturn(mSubscriptionManager);
|
|
||||||
when(mContext.getSystemService(TelephonyManager.class)).thenReturn(mTelephonyManager);
|
|
||||||
mController = spy(new PhoneNumberPreferenceController(mContext, "phone_number"));
|
|
||||||
|
|
||||||
if (Looper.myLooper() == null) {
|
|
||||||
Looper.prepare();
|
|
||||||
}
|
|
||||||
final PreferenceManager preferenceManager = new PreferenceManager(mContext);
|
|
||||||
mScreen = preferenceManager.createPreferenceScreen(mContext);
|
|
||||||
mPreference = spy(new Preference(mContext));
|
|
||||||
mPreference.setKey(mController.getPreferenceKey());
|
|
||||||
mPreference.setVisible(true);
|
|
||||||
mScreen.addPreference(mPreference);
|
|
||||||
final String categoryKey = "basic_info_category";
|
|
||||||
mCategory = new PreferenceCategory(mContext);
|
|
||||||
mCategory.setKey(categoryKey);
|
|
||||||
mScreen.addPreference(mCategory);
|
|
||||||
|
|
||||||
doReturn(mSecondPreference).when(mController).createNewPreference(mContext);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void displayPreference_multiSim_shouldAddSecondPreference() {
|
|
||||||
when(mTelephonyManager.getPhoneCount()).thenReturn(2);
|
|
||||||
|
|
||||||
final Preference sim1Preference = new Preference(mContext);
|
|
||||||
mCategory.addItemFromInflater(sim1Preference);
|
|
||||||
mController.displayPreference(mScreen);
|
|
||||||
|
|
||||||
assertThat(mCategory.getPreferenceCount()).isEqualTo(2);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void updateState_singleSim_shouldUpdateTitleAndPhoneNumber() {
|
|
||||||
final String phoneNumber = "1111111111";
|
|
||||||
doReturn(mSubscriptionInfo).when(mController).getSubscriptionInfo(anyInt());
|
|
||||||
doReturn(phoneNumber).when(mController).getFormattedPhoneNumber(mSubscriptionInfo);
|
|
||||||
when(mTelephonyManager.getPhoneCount()).thenReturn(1);
|
|
||||||
mController.displayPreference(mScreen);
|
|
||||||
|
|
||||||
mController.updateState(mPreference);
|
|
||||||
|
|
||||||
verify(mPreference).setTitle(ResourcesUtils.getResourcesString(mContext, "status_number"));
|
|
||||||
verify(mPreference).setSummary(phoneNumber);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void updateState_multiSim_shouldUpdateTitleAndPhoneNumberOfMultiplePreferences() {
|
|
||||||
final String phoneNumber = "1111111111";
|
|
||||||
doReturn(mSubscriptionInfo).when(mController).getSubscriptionInfo(anyInt());
|
|
||||||
doReturn(phoneNumber).when(mController).getFormattedPhoneNumber(mSubscriptionInfo);
|
|
||||||
when(mTelephonyManager.getPhoneCount()).thenReturn(2);
|
|
||||||
mController.displayPreference(mScreen);
|
|
||||||
|
|
||||||
mController.updateState(mPreference);
|
|
||||||
|
|
||||||
verify(mPreference).setTitle(ResourcesUtils.getResourcesString(
|
|
||||||
mContext, "status_number_sim_slot", 1 /* sim slot */));
|
|
||||||
verify(mPreference).setSummary(phoneNumber);
|
|
||||||
verify(mSecondPreference).setTitle(ResourcesUtils.getResourcesString(
|
|
||||||
mContext, "status_number_sim_slot", 2 /* sim slot */));
|
|
||||||
verify(mSecondPreference).setSummary(phoneNumber);
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void getSummary_cannotGetActiveSubscriptionInfo_shouldShowNotAvailable() {
|
|
||||||
when(mSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(null);
|
|
||||||
mController.displayPreference(mScreen);
|
|
||||||
|
|
||||||
mController.updateState(mPreference);
|
|
||||||
|
|
||||||
verify(mPreference).setSummary(mContext.getString(R.string.device_info_not_available));
|
|
||||||
}
|
|
||||||
|
|
||||||
@Test
|
|
||||||
public void getSummary_getEmptySubscriptionInfo_shouldShowNotAvailable() {
|
|
||||||
List<SubscriptionInfo> infos = new ArrayList<>();
|
|
||||||
when(mSubscriptionManager.getActiveSubscriptionInfoList()).thenReturn(infos);
|
|
||||||
|
|
||||||
mController.displayPreference(mScreen);
|
|
||||||
mController.updateState(mPreference);
|
|
||||||
|
|
||||||
verify(mPreference).setSummary(mContext.getString(R.string.device_info_not_available));
|
|
||||||
}
|
|
||||||
}
|
|
||||||
Reference in New Issue
Block a user