PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: fix ADB URI doesn't work

Browse Source 
Using old WifiQrCode parsing for ADB Uri.

Flag: EXEMPT bugfix
Bug: 355088188
Test: Manual test & TH
Change-Id: I54a12b03ed9be6dc49fb957df0f1f7b31647810d
This commit is contained in:
Les Lee
2024-07-24 20:32:54 +00:00
parent 8a4a5f207e
commit da21128568
3 changed files with 241 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

65
tests/unit/src/com/android/settings/wifi/dpp/AdbQrCodeTest.java Normal file
View File

@@ -0,0 +1,65 @@
/*
* Copyright (C) 2024 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.wifi.dpp;
import static com.google.common.truth.Truth.assertThat;
import androidx.test.ext.junit.runners.AndroidJUnit4;
import org.junit.Test;
import org.junit.runner.RunWith;
@RunWith(AndroidJUnit4.class)
public class AdbQrCodeTest {
@Test
public void testZxParsing_validCode() {
WifiNetworkConfig config = new AdbQrCode(
"WIFI:S:reallyLONGone;T:ADB;P:somepasswo#%^**123rd").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("reallyLONGone");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("somepasswo#%^**123rd");
config = new AdbQrCode("WIFI:S:anotherone;T:ADB;P:3#=3j9asicla").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("anotherone");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("3#=3j9asicla");
config = new AdbQrCode("WIFI:S:xx;T:ADB;P:a").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("xx");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("a");
}
@Test
public void testZxParsing_invalidCodeButShouldWork() {
WifiNetworkConfig config = new AdbQrCode(
"WIFI:S:reallyLONGone;T:ADB; P:somepassword").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("reallyLONGone");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("somepassword");
config = new AdbQrCode("WIFI: S:anotherone;T:ADB;P:abcdefghihklmn").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("anotherone");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("abcdefghihklmn");
config = new AdbQrCode("WIFI: S:xx; T:ADB; P:a").getWifiNetworkConfig();
assertThat(config.getSsid()).isEqualTo("xx");
assertThat(config.getSecurity()).isEqualTo("ADB");
assertThat(config.getPreSharedKey()).isEqualTo("a");
}
}