diff --git a/src/com/android/settings/sim/CallsSimListDialogFragment.java b/src/com/android/settings/sim/CallsSimListDialogFragment.java index bb5a0035fdf..7d3de443821 100644 --- a/src/com/android/settings/sim/CallsSimListDialogFragment.java +++ b/src/com/android/settings/sim/CallsSimListDialogFragment.java @@ -16,6 +16,7 @@ package com.android.settings.sim; +import android.app.settings.SettingsEnums; import android.content.Context; import android.telecom.PhoneAccount; import android.telecom.PhoneAccountHandle; @@ -56,4 +57,9 @@ public class CallsSimListDialogFragment extends SimListDialogFragment { } return result; } + + @Override + public int getMetricsCategory() { + return SettingsEnums.DIALOG_CALL_SIM_LIST; + } } diff --git a/src/com/android/settings/sim/PreferredSimDialogFragment.java b/src/com/android/settings/sim/PreferredSimDialogFragment.java index 5b81e62e5d3..29f4c655340 100644 --- a/src/com/android/settings/sim/PreferredSimDialogFragment.java +++ b/src/com/android/settings/sim/PreferredSimDialogFragment.java @@ -18,6 +18,7 @@ package com.android.settings.sim; import android.app.Activity; import android.app.Dialog; +import android.app.settings.SettingsEnums; import android.content.DialogInterface; import android.os.Bundle; import android.telephony.SubscriptionInfo; @@ -98,4 +99,9 @@ public class PreferredSimDialogFragment extends SimDialogFragment implements protected SubscriptionManager getSubscriptionManager() { return getContext().getSystemService(SubscriptionManager.class); } + + @Override + public int getMetricsCategory() { + return SettingsEnums.DIALOG_PREFERRED_SIM_PICKER; + } } diff --git a/src/com/android/settings/sim/SimDialogFragment.java b/src/com/android/settings/sim/SimDialogFragment.java index 10815fd7679..de991ec14f8 100644 --- a/src/com/android/settings/sim/SimDialogFragment.java +++ b/src/com/android/settings/sim/SimDialogFragment.java @@ -20,10 +20,11 @@ import android.content.DialogInterface; import android.os.Bundle; import androidx.annotation.NonNull; -import androidx.fragment.app.DialogFragment; + +import com.android.settings.core.instrumentation.InstrumentedDialogFragment; /** Common functionality for showing a dialog in SimDialogActivity. */ -public abstract class SimDialogFragment extends DialogFragment { +public abstract class SimDialogFragment extends InstrumentedDialogFragment { private static final String TAG = "SimDialogFragment"; private static final String KEY_TITLE_ID = "title_id"; diff --git a/src/com/android/settings/sim/SimListDialogFragment.java b/src/com/android/settings/sim/SimListDialogFragment.java index f78c4e76e44..1802d65420b 100644 --- a/src/com/android/settings/sim/SimListDialogFragment.java +++ b/src/com/android/settings/sim/SimListDialogFragment.java @@ -17,6 +17,7 @@ package com.android.settings.sim; import android.app.Dialog; +import android.app.settings.SettingsEnums; import android.content.Context; import android.content.DialogInterface; import android.os.Bundle; @@ -50,7 +51,7 @@ public class SimListDialogFragment extends SimDialogFragment implements protected SelectSubscriptionAdapter mAdapter; @VisibleForTesting - List mSubscriptions; + List mSubscriptions; public static SimListDialogFragment newInstance(int dialogType, int titleResId, boolean includeAskEveryTime) { @@ -122,6 +123,11 @@ public class SimListDialogFragment extends SimDialogFragment implements builder.setAdapter(mAdapter, this); } + @Override + public int getMetricsCategory() { + return SettingsEnums.DIALOG_SIM_LIST; + } + private static class SelectSubscriptionAdapter extends BaseAdapter { private Context mContext; private LayoutInflater mInflater; diff --git a/tests/robotests/src/com/android/settings/core/codeinspection/CodeInspectionTest.java b/tests/robotests/src/com/android/settings/core/codeinspection/CodeInspectionTest.java index 5fdadb48662..ccc8cbd0934 100644 --- a/tests/robotests/src/com/android/settings/core/codeinspection/CodeInspectionTest.java +++ b/tests/robotests/src/com/android/settings/core/codeinspection/CodeInspectionTest.java @@ -24,12 +24,11 @@ import com.android.settings.search.SearchIndexProviderCodeInspector; import com.android.settings.slices.SliceControllerInXmlCodeInspector; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; +import org.robolectric.RobolectricTestRunner; import java.util.List; -import org.robolectric.RobolectricTestRunner; /** * Test suite that scans all classes in app package, and performs different types of code inspection @@ -47,7 +46,6 @@ public class CodeInspectionTest { } @Test - @Ignore("b/130897640") public void runInstrumentableFragmentCodeInspection() { new InstrumentableFragmentCodeInspector(mClasses).run(); }