diff --git a/tests/robotests/Android.mk b/tests/robotests/Android.mk index 97e5e04f875..727188488a1 100644 --- a/tests/robotests/Android.mk +++ b/tests/robotests/Android.mk @@ -14,7 +14,7 @@ LOCAL_STATIC_JAVA_LIBRARIES := \ LOCAL_JAVA_LIBRARIES := \ junit \ - platform-robolectric-3.4.2-prebuilt \ + platform-robolectric-3.5.1-prebuilt \ telephony-common LOCAL_INSTRUMENTATION_FOR := Settings @@ -42,4 +42,4 @@ LOCAL_INSTRUMENT_SOURCE_DIRS := $(dir $(LOCAL_PATH))../src LOCAL_ROBOTEST_TIMEOUT := 36000 -include prebuilts/misc/common/robolectric/3.4.2/run_robotests.mk +include prebuilts/misc/common/robolectric/3.5.1/run_robotests.mk diff --git a/tests/robotests/src/com/android/settings/HelpTrampolineTest.java b/tests/robotests/src/com/android/settings/HelpTrampolineTest.java index e10b878d31a..a6bcf03c7fc 100644 --- a/tests/robotests/src/com/android/settings/HelpTrampolineTest.java +++ b/tests/robotests/src/com/android/settings/HelpTrampolineTest.java @@ -50,7 +50,7 @@ public class HelpTrampolineTest { final Intent intent = new Intent().setClassName( RuntimeEnvironment.application.getPackageName(), HelpTrampoline.class.getName()); - Robolectric.buildActivity(HelpTrampoline.class).withIntent(intent).create().get(); + Robolectric.buildActivity(HelpTrampoline.class, intent).create().get(); assertThat(ShadowHelpUtils.isGetHelpIntentCalled()).isFalse(); } @@ -60,8 +60,8 @@ public class HelpTrampolineTest { final Intent intent = new Intent().setClassName( RuntimeEnvironment.application.getPackageName(), HelpTrampoline.class.getName()) .putExtra(Intent.EXTRA_TEXT, "help_url_upgrading"); - final ShadowActivity shadow = shadowOf(Robolectric.buildActivity(HelpTrampoline.class) - .withIntent(intent).create().get()); + final ShadowActivity shadow = + shadowOf(Robolectric.buildActivity(HelpTrampoline.class, intent).create().get()); final Intent launchedIntent = shadow.getNextStartedActivity(); assertThat(ShadowHelpUtils.isGetHelpIntentCalled()).isTrue(); diff --git a/tests/robotests/src/com/android/settings/password/ChooseLockSettingsHelperTest.java b/tests/robotests/src/com/android/settings/password/ChooseLockSettingsHelperTest.java index 20a05e3b2dc..8628678930c 100644 --- a/tests/robotests/src/com/android/settings/password/ChooseLockSettingsHelperTest.java +++ b/tests/robotests/src/com/android/settings/password/ChooseLockSettingsHelperTest.java @@ -131,9 +131,7 @@ public class ChooseLockSettingsHelperTest { public void testLaunchConfirmationActivity_internal_shouldPropagateTheme() { Intent intent = new Intent() .putExtra(WizardManagerHelper.EXTRA_THEME, WizardManagerHelper.THEME_GLIF_V2); - Activity activity = Robolectric.buildActivity(Activity.class) - .withIntent(intent) - .get(); + Activity activity = Robolectric.buildActivity(Activity.class, intent).get(); ChooseLockSettingsHelper helper = getChooseLockSettingsHelper(activity); helper.launchConfirmationActivity(123, "test title", true, 0 /* userId */); diff --git a/tests/robotests/src/com/android/settings/testutils/SettingsRobolectricTestRunner.java b/tests/robotests/src/com/android/settings/testutils/SettingsRobolectricTestRunner.java index 2e8bac0f36c..7c374e9e92d 100644 --- a/tests/robotests/src/com/android/settings/testutils/SettingsRobolectricTestRunner.java +++ b/tests/robotests/src/com/android/settings/testutils/SettingsRobolectricTestRunner.java @@ -62,8 +62,8 @@ public class SettingsRobolectricTestRunner extends RobolectricTestRunner { // By adding any resources from libraries we need the AndroidManifest, we can access // them from within the parallel universe's resource loader. - final AndroidManifest manifest = new AndroidManifest(Fs.fileFromPath(manifestPath), - Fs.fileFromPath(resDir), Fs.fileFromPath(assetsDir)) { + return new AndroidManifest(Fs.fileFromPath(manifestPath), Fs.fileFromPath(resDir), + Fs.fileFromPath(assetsDir), "com.android.settings") { @Override public List getIncludedResourcePaths() { List paths = super.getIncludedResourcePaths(); @@ -71,10 +71,6 @@ public class SettingsRobolectricTestRunner extends RobolectricTestRunner { return paths; } }; - - // Set the package name to the renamed one - manifest.setPackageName("com.android.settings"); - return manifest; } public static void getIncludedResourcePaths(String packageName, List paths) {