From d9d21d6cb1e435bd46dcd089ecdc11a357dd7cfb Mon Sep 17 00:00:00 2001 From: Fan Zhang Date: Tue, 29 Mar 2016 10:43:02 -0700 Subject: [PATCH] Move actionbar menu from DashboardSummary to container. Bug: 27751187 Change-Id: I7730f104805abcbb6d243fccac94e39fad26ddd2 --- .../dashboard/DashboardContainerFragment.java | 17 +++++++++++++++++ .../settings/dashboard/DashboardSummary.java | 13 +------------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/com/android/settings/dashboard/DashboardContainerFragment.java b/src/com/android/settings/dashboard/DashboardContainerFragment.java index d1745f825d4..f839ae700cf 100644 --- a/src/com/android/settings/dashboard/DashboardContainerFragment.java +++ b/src/com/android/settings/dashboard/DashboardContainerFragment.java @@ -22,9 +22,12 @@ import android.os.Bundle; import android.support.v13.app.FragmentPagerAdapter; import android.support.v4.view.ViewPager; import android.view.LayoutInflater; +import android.view.Menu; +import android.view.MenuInflater; import android.view.View; import android.view.ViewGroup; +import com.android.settings.HelpUtils; import com.android.settings.InstrumentedFragment; import com.android.settings.R; @@ -41,6 +44,12 @@ public final class DashboardContainerFragment extends InstrumentedFragment { return DASHBOARD_CONTAINER; } + @Override + public void onCreate(Bundle savedInstanceState) { + super.onCreate(savedInstanceState); + setHasOptionsMenu(true); + } + @Override public View onCreateView(LayoutInflater inflater, ViewGroup parent, Bundle savedInstanceState) { final View content = inflater.inflate(R.layout.dashboard_container, parent, false); @@ -50,6 +59,14 @@ public final class DashboardContainerFragment extends InstrumentedFragment { return content; } + @Override + public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { + super.onCreateOptionsMenu(menu, inflater); + if (getActivity() == null) return; + HelpUtils.prepareHelpMenuItem(getActivity(), menu, R.string.help_uri_dashboard, + getClass().getName()); + } + private static final class DashboardViewPagerAdapter extends FragmentPagerAdapter { diff --git a/src/com/android/settings/dashboard/DashboardSummary.java b/src/com/android/settings/dashboard/DashboardSummary.java index 5d9a79bc53c..1a27e605528 100644 --- a/src/com/android/settings/dashboard/DashboardSummary.java +++ b/src/com/android/settings/dashboard/DashboardSummary.java @@ -21,13 +21,11 @@ import android.os.Bundle; import android.support.v7.widget.LinearLayoutManager; import android.util.Log; import android.view.LayoutInflater; -import android.view.Menu; -import android.view.MenuInflater; import android.view.View; import android.view.ViewGroup; + import com.android.internal.logging.MetricsLogger; import com.android.internal.logging.MetricsProto.MetricsEvent; -import com.android.settings.HelpUtils; import com.android.settings.InstrumentedFragment; import com.android.settings.R; import com.android.settings.Settings; @@ -83,7 +81,6 @@ public class DashboardSummary extends InstrumentedFragment List categories = ((SettingsActivity) getActivity()).getDashboardCategories(); mSummaryLoader = new SummaryLoader(getActivity(), categories); - setHasOptionsMenu(true); if (DEBUG_TIMING) Log.d(TAG, "onCreate took " + (System.currentTimeMillis() - startTime) + " ms"); Context context = getContext(); @@ -98,14 +95,6 @@ public class DashboardSummary extends InstrumentedFragment super.onDestroy(); } - @Override - public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) { - super.onCreateOptionsMenu(menu, inflater); - if (getActivity() == null) return; - HelpUtils.prepareHelpMenuItem(getActivity(), menu, R.string.help_uri_dashboard, - getClass().getName()); - } - @Override public void onResume() { super.onResume();