From 69eb99109242ced6a1231b1ec9e5d6fc975f8489 Mon Sep 17 00:00:00 2001 From: Tarandeep Singh Date: Tue, 26 Mar 2019 11:26:58 -0700 Subject: [PATCH] Fix dupicate preference in personal dict Duplicate preference is added on the UserDictionaryListPreferenceController. With this change, we check before adding. Fix: 129079798 Test: Manually using steps mentioned in bug Change-Id: If73880f3be460f377b8985a44fc9f9fbe6370c06 --- .../inputmethod/UserDictionaryListPreferenceController.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java b/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java index 4a409e1c789..9343493de2f 100644 --- a/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java +++ b/src/com/android/settings/inputmethod/UserDictionaryListPreferenceController.java @@ -174,7 +174,10 @@ public class UserDictionaryListPreferenceController extends BasePreferenceContro mScreen.addPreference(createUserDictionaryPreference(null)); } else { for (String locale : localeSet) { - mScreen.addPreference(createUserDictionaryPreference(locale)); + final Preference pref = createUserDictionaryPreference(locale); + if (mScreen.findPreference(pref.getKey()) == null) { + mScreen.addPreference(pref); + } } } }