PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check for DeviceAdminInfo type before casting

Browse Source 
Race conditions seem to cause disabled list adapter items to trigger an
onListItemClick event. Type of item object needs to be checked therefore.

Bug:17187120
Change-Id: I469004081c89c9ba24dfa95872b54648a26213f9
This commit is contained in:
Zoltan Szatmary-Ban
2014-08-28 13:13:34 +01:00
parent e58fda7997
commit d92897d39f
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/com/android/settings/DeviceAdminSettings.java
View File

@@ -127,7 +127,12 @@ public class DeviceAdminSettings extends ListFragment {
@Override @Override
public void onListItemClick(ListView l, View v, int position, long id) { public void onListItemClick(ListView l, View v, int position, long id) {
DeviceAdminInfo dpi = (DeviceAdminInfo) l.getAdapter().getItem(position); Object o = l.getAdapter().getItem(position);
if (!(o instanceof DeviceAdminInfo)) {
// race conditions may cause this
return;
}
DeviceAdminInfo dpi = (DeviceAdminInfo) o;
final Activity activity = getActivity(); final Activity activity = getActivity();
final int userId = getUserId(dpi); final int userId = getUserId(dpi);
if (userId == UserHandle.myUserId() || !isProfileOwner(dpi)) { if (userId == UserHandle.myUserId() || !isProfileOwner(dpi)) {