PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Bluetooth: Fix to avoid BluetoothPan ServiceConnection leak" into pi-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2018-05-16 23:28:28 +00:00
committed by Android (Google) Code Review
parent e7f321c3c0 1b0afb9d1c
commit d924894652
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/com/android/settings/network/TetherPreferenceController.java
View File

@@ -131,7 +131,8 @@ public class TetherPreferenceController extends AbstractPreferenceController imp
@Override
public void onCreate(Bundle savedInstanceState) {
if (mBluetoothAdapter != null) {
if (mBluetoothAdapter != null &&
mBluetoothAdapter.getState() == BluetoothAdapter.STATE_ON) {
mBluetoothAdapter.getProfileProxy(mContext, mBtProfileServiceListener,
BluetoothProfile.PAN);
}

15
tests/robotests/src/com/android/settings/network/TetherPreferenceControllerTest.java
View File

@@ -75,10 +75,21 @@ public class TetherPreferenceControllerTest {
@Test
public void lifeCycle_onCreate_shouldInitBluetoothPan() {
when(mBluetoothAdapter.getState()).thenReturn(BluetoothAdapter.STATE_ON);
mController.onCreate(null);
verify(mBluetoothAdapter)
.getProfileProxy(mContext, mController.mBtProfileServiceListener, BluetoothProfile.PAN);
verify(mBluetoothAdapter).getState();
verify(mBluetoothAdapter).getProfileProxy(mContext, mController.mBtProfileServiceListener,
BluetoothProfile.PAN);
}
@Test
public void lifeCycle_onCreate_shouldNotInitBluetoothPanWhenBluetoothOff() {
when(mBluetoothAdapter.getState()).thenReturn(BluetoothAdapter.STATE_OFF);
mController.onCreate(null);
verify(mBluetoothAdapter).getState();
verifyNoMoreInteractions(mBluetoothAdapter);
}
@Test