From bd482c986c288aa8f2f382961cc441692d821adc Mon Sep 17 00:00:00 2001 From: Weng Su Date: Wed, 11 Nov 2020 07:57:44 +0000 Subject: [PATCH] Add a mutability flag to the PendingIntent - Request from Android Platform Security team. go/immutable-pendingintents Bug: 170162129 Test: 1. adb shell am start -a android.settings.panel.action.INTERNET_CONNECTIVITY 2. make RunSettingsRoboTests ROBOTEST_FILTER=WifiSliceTest Change-Id: If3032959649206f2fb6736244d7aa8b9a8419378 --- src/com/android/settings/wifi/slice/WifiSlice.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/com/android/settings/wifi/slice/WifiSlice.java b/src/com/android/settings/wifi/slice/WifiSlice.java index 324d68c870e..2858ab44723 100644 --- a/src/com/android/settings/wifi/slice/WifiSlice.java +++ b/src/com/android/settings/wifi/slice/WifiSlice.java @@ -224,7 +224,7 @@ public class WifiSlice implements CustomSliceable { private SliceAction getActivityAction(int requestCode, Intent intent, IconCompat icon, CharSequence title) { final PendingIntent pi = PendingIntent.getActivity(mContext, requestCode, intent, - 0 /* flags */); + PendingIntent.FLAG_IMMUTABLE /* flags */); return SliceAction.createDeeplink(pi, icon, ListBuilder.ICON_IMAGE, title); } @@ -289,7 +289,7 @@ public class WifiSlice implements CustomSliceable { private PendingIntent getPrimaryAction() { final Intent intent = getIntent(); return PendingIntent.getActivity(mContext, 0 /* requestCode */, - intent, 0 /* flags */); + intent, PendingIntent.FLAG_IMMUTABLE /* flags */); } private Set getKeywords() {