PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed the IllegalStateException on removing account

Browse Source 
We display a dialog in AccountManager.removeAccountAsUser() callback, but at that
time fragment is onstop() which causes the IllegalStateException.

Fixes: 133253227
Fixes: 135004255
Test: make RunSettingsRoboTests -j56 ROBOTEST_FILTER=com.android.settings.accounts
      make RunSettingsRoboTests -j56 ROBOTEST_FILTER=com.android.settings.core
      make RunSettingsRoboTests -j56 ROBOTEST_FILTER=com.android.settings.dashboard

Change-Id: I8534e8f7118234f6346607415698f9f91c3e5ffb
(cherry picked from commit d843ee85de)
This commit is contained in:
Sunny Shao
2019-05-30 11:22:39 +08:00
committed by Raff Tsai
parent 7d43125964
commit d7d4a7ce6d
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/com/android/settings/accounts/RemoveAccountPreferenceController.java
View File

@@ -191,7 +191,11 @@ public class RemoveAccountPreferenceController extends AbstractPreferenceControl
} }
final RemoveAccountFailureDialog dialog = new RemoveAccountFailureDialog(); final RemoveAccountFailureDialog dialog = new RemoveAccountFailureDialog();
dialog.setTargetFragment(parent, 0); dialog.setTargetFragment(parent, 0);
dialog.show(parent.getFragmentManager(), FAILED_REMOVAL_DIALOG); try {
dialog.show(parent.getFragmentManager(), FAILED_REMOVAL_DIALOG);
} catch (IllegalStateException e) {
Log.w(TAG, "Can't show RemoveAccountFailureDialog. " + e.getMessage());
}
} }
@Override @Override