Precommit hook added to Settings, preventing the creation of new Robolectric tests.

Test: repo upload .
Change-Id: If31d79a7bf6a18f4c52692ffab4981056c14eaba
This commit is contained in:
Jeremy Goldman
2020-12-08 16:52:37 +08:00
parent 836df5eb3a
commit d6a29ea707
2 changed files with 18 additions and 0 deletions

View File

@@ -4,3 +4,5 @@ checkcolor_hook = ${REPO_ROOT}/prebuilts/checkcolor/checkcolor.py -p .
strings_lint_hook = ${REPO_ROOT}/frameworks/base/tools/stringslint/stringslint_sha.sh ${PREUPLOAD_COMMIT}
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
robolectric_hook = ${REPO_ROOT}/packages/apps/Settings/tests/robotests/new_tests_hook.sh ${REPO_PROJECT}

View File

@@ -0,0 +1,16 @@
#!/bin/bash
# This script detects the presence of new robolectric java tests within
# commits to be uploaded. If a new file is detected the script will print an
# error message and return an error code. Intended to be used as a repo hook.
new_robolectric_tests=$(
git diff --name-status $REPO_LREV | grep "^A.*tests/robotests.*\.java")
if [ $new_robolectric_tests != "" ]
then
echo "New Robolectric unit tests detected. Please submit junit tests" \
"instead, in the tests/junit directory." \
"See go/android-platform-robolectric-cleanup."
echo $new_robolectric_tests
exit 1
fi