Merge "Fix a crash when launching app detail for bad package name" am: ada1a39ffb
am: 2e2e1e243d
am: 59cd5abb96
Change-Id: I746d5c959761306d463a934e7c01f4155934fd93
This commit is contained in:
@@ -170,7 +170,7 @@ public final class AppInfoDashboardFragmentTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
public void launchFragment_hasNoPackageInfo_shouldFinish() {
|
||||
public void ensurePackageInfoAvailable_hasNoPackageInfo_shouldFinish() {
|
||||
ReflectionHelpers.setField(mFragment, "mPackageInfo", null);
|
||||
|
||||
assertThat(mFragment.ensurePackageInfoAvailable(mActivity)).isFalse();
|
||||
@@ -178,7 +178,7 @@ public final class AppInfoDashboardFragmentTest {
|
||||
}
|
||||
|
||||
@Test
|
||||
public void launchFragment_hasPackageInfo_shouldReturnTrue() {
|
||||
public void ensurePackageInfoAvailable_hasPackageInfo_shouldReturnTrue() {
|
||||
final PackageInfo packageInfo = mock(PackageInfo.class);
|
||||
ReflectionHelpers.setField(mFragment, "mPackageInfo", packageInfo);
|
||||
|
||||
@@ -186,6 +186,16 @@ public final class AppInfoDashboardFragmentTest {
|
||||
verify(mActivity, never()).finishAndRemoveTask();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void createPreference_hasNoPackageInfo_shouldSkip() {
|
||||
ReflectionHelpers.setField(mFragment, "mPackageInfo", null);
|
||||
|
||||
mFragment.onCreatePreferences(new Bundle(), "root_key");
|
||||
|
||||
verify(mActivity).finishAndRemoveTask();
|
||||
verify(mFragment, never()).getPreferenceScreen();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void packageSizeChange_isOtherPackage_shouldNotRefreshUi() {
|
||||
ReflectionHelpers.setField(mFragment, "mPackageName", PACKAGE_NAME);
|
||||
|
Reference in New Issue
Block a user