Create a permission bar chart in Privacy page
Using PermissionControllerManager to get the apps usage of different permission groups. And then we visualize the result with bar chart. Test: visual, robotest Fixes: 116628158 Change-Id: I0442a04c35d74f715418fac0279bb8f36f6d64df
This commit is contained in:
@@ -10512,4 +10512,14 @@
|
|||||||
|
|
||||||
<!-- Preference title text for silence gesture [CHAR LIMIT=60]-->
|
<!-- Preference title text for silence gesture [CHAR LIMIT=60]-->
|
||||||
<string name="gesture_silence_title">Silence alerts gesture</string>
|
<string name="gesture_silence_title">Silence alerts gesture</string>
|
||||||
|
|
||||||
|
<!-- Text to display when no app used permission. [CHAR LIMIT=NONE] -->
|
||||||
|
<string name="permission_bar_chart_empty_text">0 apps used permissions</string>
|
||||||
|
|
||||||
|
<!-- Text for permission bar chart title in Privacy page. [CHAR LIMIT=NONE] -->
|
||||||
|
<string name="permission_bar_chart_title">Most-used permissions in last 24 hours</string>
|
||||||
|
|
||||||
|
<!-- Text for permission bar chart details in Privacy page. [CHAR LIMIT=NONE] -->
|
||||||
|
<string name="permission_bar_chart_details">See all usage</string>
|
||||||
|
|
||||||
</resources>
|
</resources>
|
||||||
|
@@ -22,10 +22,16 @@
|
|||||||
android:title="@string/privacy_dashboard_title"
|
android:title="@string/privacy_dashboard_title"
|
||||||
settings:initialExpandedChildrenCount="3">
|
settings:initialExpandedChildrenCount="3">
|
||||||
|
|
||||||
|
<com.android.settingslib.widget.BarChartPreference
|
||||||
|
android:key="permission_bar_chart"
|
||||||
|
android:title="@string/privacy_dashboard_title"
|
||||||
|
settings:controller="com.android.settings.privacy.PermissionBarChartPreferenceController"/>
|
||||||
|
|
||||||
<!-- App permissions -->
|
<!-- App permissions -->
|
||||||
<Preference
|
<Preference
|
||||||
android:key="privacy_manage_perms"
|
android:key="privacy_manage_perms"
|
||||||
android:title="@string/app_permissions"
|
android:title="@string/app_permissions"
|
||||||
|
settings:allowDividerAbove="true"
|
||||||
settings:keywords="@string/keywords_app_permissions"
|
settings:keywords="@string/keywords_app_permissions"
|
||||||
settings:controller="com.android.settings.applications.AppPermissionsPreferenceController">
|
settings:controller="com.android.settings.applications.AppPermissionsPreferenceController">
|
||||||
<intent android:action="android.intent.action.MANAGE_PERMISSIONS"/>
|
<intent android:action="android.intent.action.MANAGE_PERMISSIONS"/>
|
||||||
|
@@ -0,0 +1,165 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2019 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.privacy;
|
||||||
|
|
||||||
|
import static com.android.settingslib.widget.BarChartPreference.MAXIMUM_BAR_VIEWS;
|
||||||
|
|
||||||
|
import static java.util.concurrent.TimeUnit.DAYS;
|
||||||
|
|
||||||
|
import android.content.Context;
|
||||||
|
import android.content.Intent;
|
||||||
|
import android.content.pm.PackageManager;
|
||||||
|
import android.graphics.drawable.Drawable;
|
||||||
|
import android.permission.PermissionControllerManager;
|
||||||
|
import android.permission.RuntimePermissionUsageInfo;
|
||||||
|
import android.util.Log;
|
||||||
|
import android.view.View;
|
||||||
|
|
||||||
|
import androidx.annotation.NonNull;
|
||||||
|
import androidx.preference.Preference;
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
|
import com.android.settings.R;
|
||||||
|
import com.android.settings.core.BasePreferenceController;
|
||||||
|
import com.android.settingslib.widget.BarChartInfo;
|
||||||
|
import com.android.settingslib.widget.BarChartPreference;
|
||||||
|
import com.android.settingslib.widget.BarViewInfo;
|
||||||
|
|
||||||
|
import java.util.ArrayList;
|
||||||
|
import java.util.Comparator;
|
||||||
|
import java.util.List;
|
||||||
|
import java.util.concurrent.Executors;
|
||||||
|
|
||||||
|
|
||||||
|
public class PermissionBarChartPreferenceController extends BasePreferenceController implements
|
||||||
|
PermissionControllerManager.OnPermissionUsageResultCallback {
|
||||||
|
|
||||||
|
private static final String TAG = "BarChartPreferenceCtl";
|
||||||
|
|
||||||
|
private PackageManager mPackageManager;
|
||||||
|
private BarChartPreference mBarChartPreference;
|
||||||
|
private List<RuntimePermissionUsageInfo> mOldUsageInfos;
|
||||||
|
|
||||||
|
public PermissionBarChartPreferenceController(Context context, String preferenceKey) {
|
||||||
|
super(context, preferenceKey);
|
||||||
|
mOldUsageInfos = new ArrayList<>();
|
||||||
|
mPackageManager = context.getPackageManager();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public int getAvailabilityStatus() {
|
||||||
|
return AVAILABLE_UNSEARCHABLE;
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void displayPreference(PreferenceScreen screen) {
|
||||||
|
super.displayPreference(screen);
|
||||||
|
mBarChartPreference = (BarChartPreference) screen.findPreference(getPreferenceKey());
|
||||||
|
|
||||||
|
final BarChartInfo info = new BarChartInfo.Builder()
|
||||||
|
.setTitle(R.string.permission_bar_chart_title)
|
||||||
|
.setDetails(R.string.permission_bar_chart_details)
|
||||||
|
.setEmptyText(R.string.permission_bar_chart_empty_text)
|
||||||
|
.setDetailsOnClickListener((View v) -> {
|
||||||
|
final Intent intent = new Intent(Intent.ACTION_REVIEW_PERMISSION_USAGE);
|
||||||
|
mContext.startActivity(intent);
|
||||||
|
})
|
||||||
|
.build();
|
||||||
|
|
||||||
|
mBarChartPreference.initializeBarChart(info);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void updateState(Preference preference) {
|
||||||
|
retrievePermissionUsageData();
|
||||||
|
}
|
||||||
|
|
||||||
|
@Override
|
||||||
|
public void onPermissionUsageResult(@NonNull List<RuntimePermissionUsageInfo> usageInfos) {
|
||||||
|
usageInfos.sort(Comparator.comparingInt(
|
||||||
|
RuntimePermissionUsageInfo::getAppAccessCount).reversed());
|
||||||
|
|
||||||
|
// If the result is different, we need to update bar views.
|
||||||
|
if (!areSamePermissionGroups(usageInfos)) {
|
||||||
|
mBarChartPreference.setBarViewInfos(createBarViews(usageInfos));
|
||||||
|
mOldUsageInfos = usageInfos;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private void retrievePermissionUsageData() {
|
||||||
|
mContext.getSystemService(PermissionControllerManager.class).getPermissionUsages(
|
||||||
|
false /* countSystem */, (int) DAYS.toSeconds(1),
|
||||||
|
mContext.getMainExecutor() /* executor */, this /* callback */);
|
||||||
|
}
|
||||||
|
|
||||||
|
private BarViewInfo[] createBarViews(List<RuntimePermissionUsageInfo> usageInfos) {
|
||||||
|
if (usageInfos.isEmpty()) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
final BarViewInfo[] barViewInfos = new BarViewInfo[
|
||||||
|
Math.min(BarChartPreference.MAXIMUM_BAR_VIEWS, usageInfos.size())];
|
||||||
|
|
||||||
|
for (int index = 0; index < barViewInfos.length; index++) {
|
||||||
|
final RuntimePermissionUsageInfo permissionGroupInfo = usageInfos.get(index);
|
||||||
|
|
||||||
|
barViewInfos[index] = new BarViewInfo(
|
||||||
|
getPermissionGroupIcon(permissionGroupInfo.getName()),
|
||||||
|
permissionGroupInfo.getAppAccessCount(),
|
||||||
|
R.string.storage_detail_apps);
|
||||||
|
|
||||||
|
// Set the click listener for each bar view.
|
||||||
|
// The listener will navigate user to permission usage app.
|
||||||
|
barViewInfos[index].setClickListener((View v) -> {
|
||||||
|
final Intent intent = new Intent(Intent.ACTION_REVIEW_PERMISSION_USAGE);
|
||||||
|
intent.putExtra(Intent.EXTRA_PERMISSION_GROUP_NAME, permissionGroupInfo.getName());
|
||||||
|
mContext.startActivity(intent);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
return barViewInfos;
|
||||||
|
}
|
||||||
|
|
||||||
|
private Drawable getPermissionGroupIcon(CharSequence permissionGroup) {
|
||||||
|
Drawable icon = null;
|
||||||
|
try {
|
||||||
|
icon = mPackageManager.getPermissionGroupInfo(permissionGroup.toString(), 0)
|
||||||
|
.loadIcon(mPackageManager);
|
||||||
|
} catch (PackageManager.NameNotFoundException e) {
|
||||||
|
Log.w(TAG, "Cannot find group icon for " + permissionGroup, e);
|
||||||
|
}
|
||||||
|
|
||||||
|
return icon;
|
||||||
|
}
|
||||||
|
|
||||||
|
private boolean areSamePermissionGroups(List<RuntimePermissionUsageInfo> newUsageInfos) {
|
||||||
|
if (newUsageInfos.size() != mOldUsageInfos.size()) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
for (int index = 0; index < newUsageInfos.size(); index++) {
|
||||||
|
final RuntimePermissionUsageInfo newInfo = newUsageInfos.get(index);
|
||||||
|
final RuntimePermissionUsageInfo oldInfo = mOldUsageInfos.get(index);
|
||||||
|
|
||||||
|
if (!newInfo.getName().equals(oldInfo.getName()) ||
|
||||||
|
newInfo.getAppAccessCount() != oldInfo.getAppAccessCount()) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
@@ -0,0 +1,113 @@
|
|||||||
|
/*
|
||||||
|
* Copyright (C) 2019 The Android Open Source Project
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package com.android.settings.privacy;
|
||||||
|
|
||||||
|
import static com.android.settings.core.BasePreferenceController.AVAILABLE_UNSEARCHABLE;
|
||||||
|
|
||||||
|
import static com.google.common.truth.Truth.assertThat;
|
||||||
|
|
||||||
|
import static org.mockito.ArgumentMatchers.any;
|
||||||
|
import static org.mockito.Mockito.spy;
|
||||||
|
import static org.mockito.Mockito.times;
|
||||||
|
import static org.mockito.Mockito.verify;
|
||||||
|
import static org.mockito.Mockito.when;
|
||||||
|
|
||||||
|
import android.content.Context;
|
||||||
|
import android.permission.RuntimePermissionUsageInfo;
|
||||||
|
|
||||||
|
import androidx.preference.PreferenceScreen;
|
||||||
|
|
||||||
|
import com.android.settingslib.widget.BarChartInfo;
|
||||||
|
import com.android.settingslib.widget.BarChartPreference;
|
||||||
|
import com.android.settingslib.widget.BarViewInfo;
|
||||||
|
|
||||||
|
import org.junit.Before;
|
||||||
|
import org.junit.Test;
|
||||||
|
import org.junit.runner.RunWith;
|
||||||
|
import org.mockito.Mock;
|
||||||
|
import org.mockito.MockitoAnnotations;
|
||||||
|
import org.robolectric.RobolectricTestRunner;
|
||||||
|
import org.robolectric.RuntimeEnvironment;
|
||||||
|
|
||||||
|
import java.util.ArrayList;
|
||||||
|
import java.util.List;
|
||||||
|
|
||||||
|
@RunWith(RobolectricTestRunner.class)
|
||||||
|
public class PermissionBarChartPreferenceControllerTest {
|
||||||
|
|
||||||
|
@Mock
|
||||||
|
private PreferenceScreen mScreen;
|
||||||
|
|
||||||
|
private PermissionBarChartPreferenceController mController;
|
||||||
|
private BarChartPreference mPreference;
|
||||||
|
|
||||||
|
@Before
|
||||||
|
public void setUp() {
|
||||||
|
MockitoAnnotations.initMocks(this);
|
||||||
|
Context Context = RuntimeEnvironment.application;
|
||||||
|
mController = new PermissionBarChartPreferenceController(Context, "test_key");
|
||||||
|
mPreference = spy(new BarChartPreference(Context));
|
||||||
|
when(mScreen.findPreference(mController.getPreferenceKey()))
|
||||||
|
.thenReturn((BarChartPreference) mPreference);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getAvailabilityStatus_shouldReturnAvailableUnsearchable() {
|
||||||
|
assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE_UNSEARCHABLE);
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void displayPreference_shouldInitializeBarChart() {
|
||||||
|
mController.displayPreference(mScreen);
|
||||||
|
|
||||||
|
verify(mPreference).initializeBarChart(any(BarChartInfo.class));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void onPermissionUsageResult_differentPermissionResultSet_shouldSetBarViewInfos() {
|
||||||
|
final List<RuntimePermissionUsageInfo> infos1 = new ArrayList<>();
|
||||||
|
final RuntimePermissionUsageInfo info1 =
|
||||||
|
new RuntimePermissionUsageInfo("permission 1", 10);
|
||||||
|
infos1.add(info1);
|
||||||
|
mController.displayPreference(mScreen);
|
||||||
|
mController.onPermissionUsageResult(infos1);
|
||||||
|
|
||||||
|
verify(mPreference).setBarViewInfos(any(BarViewInfo[].class));
|
||||||
|
|
||||||
|
final List<RuntimePermissionUsageInfo> infos2 = new ArrayList<>();
|
||||||
|
final RuntimePermissionUsageInfo info2 =
|
||||||
|
new RuntimePermissionUsageInfo("permission 2", 20);
|
||||||
|
infos2.add(info2);
|
||||||
|
mController.onPermissionUsageResult(infos2);
|
||||||
|
|
||||||
|
verify(mPreference, times(2)).setBarViewInfos(any(BarViewInfo[].class));
|
||||||
|
}
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void onPermissionUsageResult_samePermissionResultSet_shouldNotSetBarViewInfos() {
|
||||||
|
final List<RuntimePermissionUsageInfo> mInfos = new ArrayList<>();
|
||||||
|
final RuntimePermissionUsageInfo info1 =
|
||||||
|
new RuntimePermissionUsageInfo("permission 1", 10);
|
||||||
|
mInfos.add(info1);
|
||||||
|
mController.displayPreference(mScreen);
|
||||||
|
mController.onPermissionUsageResult(mInfos);
|
||||||
|
|
||||||
|
mController.onPermissionUsageResult(mInfos);
|
||||||
|
|
||||||
|
verify(mPreference, times(1)).setBarViewInfos(any(BarViewInfo[].class));
|
||||||
|
}
|
||||||
|
}
|
Reference in New Issue
Block a user