From ea3bfabee6aab07cd542318e0a228b504d451e09 Mon Sep 17 00:00:00 2001 From: Arc Wang Date: Tue, 21 Apr 2020 17:54:16 +0800 Subject: [PATCH] [Wi-Fi] Fix a fail WifiEnhancedMacRandomizationPreferenceControllerTest Mock objects do not know the relation between setChecked and isChecked. Should not call mock objects's setter and assume the getter will return the corresponding value. Bug: 154564960 Test: make RunSettingsRoboTests ROBOTEST_FILTER=WifiEnhancedMacRandomizationPreferenceControllerTest Change-Id: Ib2e06f0fe60f7d6f90f76bd179a7aadccfcff4c4 --- ...fiEnhancedMacRandomizationPreferenceControllerTest.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java index 862f78f7d14..25e5a2274f1 100644 --- a/tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/WifiEnhancedMacRandomizationPreferenceControllerTest.java @@ -18,6 +18,7 @@ package com.android.settings.development; import static com.google.common.truth.Truth.assertThat; +import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; import android.content.Context; @@ -27,7 +28,6 @@ import androidx.preference.PreferenceScreen; import androidx.preference.SwitchPreference; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.Mock; @@ -75,13 +75,12 @@ public class WifiEnhancedMacRandomizationPreferenceControllerTest { } @Test - @Ignore public void updateState_preferenceShouldBeChecked() { Settings.Global.putInt(mContext.getContentResolver(), ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 1); mController.updateState(mPreference); - assertThat(mPreference.isChecked()).isTrue(); + verify(mPreference).setChecked(true); } @Test @@ -90,7 +89,7 @@ public class WifiEnhancedMacRandomizationPreferenceControllerTest { ENHANCED_MAC_RANDOMIZATION_FEATURE_FLAG, 0); mController.updateState(mPreference); - assertThat(mPreference.isChecked()).isFalse(); + verify(mPreference).setChecked(false); } @Test