PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Increase touch target for suggestion close button." into pi-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2018-03-30 01:55:54 +00:00
committed by Android (Google) Code Review
parent 0ae4204f54 39cd1d8f0d
commit d483041078
4 changed files with 45 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
res/layout/suggestion_tile.xml
View File

@@ -47,16 +47,23 @@
android:layout_marginTop="16dp"
android:layout_marginBottom="6dp" />
<ImageView
<FrameLayout
android:id="@+id/close_button"
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_alignParentEnd="true"
android:paddingTop="8dp"
android:paddingEnd="8dp"
android:orientation="horizontal"
android:contentDescription="@string/dlg_close">
<ImageView
android:layout_width="18dp"
android:layout_height="18dp"
android:layout_gravity="end|top"
android:alpha="0.54"
android:layout_alignParentEnd="true"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:contentDescription="@string/dlg_close"
android:src="@drawable/ic_suggestion_close_button"/>
</FrameLayout>
</RelativeLayout>

17
res/layout/suggestion_tile_two_cards.xml
View File

@@ -44,16 +44,23 @@
android:layout_marginTop="16dp"
android:layout_marginBottom="8dp" />
<ImageView
<FrameLayout
android:id="@+id/close_button"
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_alignParentEnd="true"
android:gravity="end|top"
android:paddingTop="8dp"
android:paddingEnd="8dp"
android:orientation="horizontal"
android:contentDescription="@string/dlg_close">
<ImageView
android:layout_width="18dp"
android:layout_height="18dp"
android:layout_gravity="end|top"
android:alpha="0.54"
android:layout_alignParentEnd="true"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:contentDescription="@string/dlg_close"
android:src="@drawable/ic_suggestion_close_button"/>
</FrameLayout>
</RelativeLayout>

16
res/layout/suggestion_tile_with_button.xml
View File

@@ -46,16 +46,22 @@
android:layout_marginTop="16dp"
android:layout_marginBottom="6dp" />
<ImageView
<FrameLayout
android:id="@+id/close_button"
android:layout_width="48dp"
android:layout_height="48dp"
android:layout_alignParentEnd="true"
android:paddingTop="8dp"
android:paddingEnd="8dp"
android:orientation="horizontal"
android:contentDescription="@string/dlg_close">
<ImageView
android:layout_width="18dp"
android:layout_height="18dp"
android:layout_gravity="end|top"
android:alpha="0.54"
android:layout_alignParentEnd="true"
android:layout_marginTop="8dp"
android:layout_marginEnd="8dp"
android:contentDescription="@string/dlg_close"
android:src="@drawable/ic_suggestion_close_button"/>
</FrameLayout>
</RelativeLayout>

2
src/com/android/settings/dashboard/suggestions/SuggestionAdapter.java
View File

@@ -140,7 +140,7 @@ public class SuggestionAdapter extends RecyclerView.Adapter<DashboardItemHolder>
mConfig.setCardLayout(holder, position);
}
final ImageView closeButton = holder.itemView.findViewById(R.id.close_button);
final View closeButton = holder.itemView.findViewById(R.id.close_button);
if (closeButton != null) {
closeButton.setOnClickListener(v -> {
mSuggestionFeatureProvider.dismissSuggestion(