Fixed accessibility issues in Wi-Fi SSID view
- Keep the Save button enabled at all times - Show "Enter the SSID" to remind the user Bug: 386897596 Flag: EXEMPT bugfix Test: Manual testing atest SettingsUnitTests:AddNetworkFragmentTest atest WifiConfigController2Test Change-Id: I6cc6b197864511ee2c1c92affc67698b1761f11d
This commit is contained in:
@@ -193,15 +193,6 @@ public class WifiConfigController2Test {
|
||||
.isEqualTo(View.GONE);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void isSubmittable_noSSID_shouldReturnFalse() {
|
||||
createController(mWifiEntry, WifiConfigUiBase2.MODE_CONNECT, false);
|
||||
final TextView ssid = mView.findViewById(R.id.ssid);
|
||||
assertThat(ssid).isNotNull();
|
||||
ssid.setText("");
|
||||
assertThat(mController.isSubmittable()).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void isSubmittable_longPsk_shouldReturnFalse() {
|
||||
createController(mWifiEntry, WifiConfigUiBase2.MODE_CONNECT, false);
|
||||
@@ -1048,6 +1039,24 @@ public class WifiConfigController2Test {
|
||||
verify(mController.mEapAnonymousView, never()).setText(any(String.class));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void canFinish_ssidIsEmpty_returnFalse() {
|
||||
createController(null, WifiConfigUiBase2.MODE_CONNECT, false);
|
||||
TextView ssid = mView.findViewById(R.id.ssid);
|
||||
ssid.setText("");
|
||||
|
||||
assertThat(mController.canFinish()).isFalse();
|
||||
}
|
||||
|
||||
@Test
|
||||
public void canFinish_ssidIsGood_returnTrue() {
|
||||
createController(null, WifiConfigUiBase2.MODE_CONNECT, false);
|
||||
TextView ssid = mView.findViewById(R.id.ssid);
|
||||
ssid.setText(GOOD_SSID);
|
||||
|
||||
assertThat(mController.canFinish()).isTrue();
|
||||
}
|
||||
|
||||
private void setUpModifyingSavedCertificateConfigController(String savedCaCertificate,
|
||||
String savedUserCertificate) {
|
||||
final WifiConfiguration mockWifiConfig = spy(new WifiConfiguration());
|
||||
|
Reference in New Issue
Block a user