From 64b66e6036d2069368977b6c3ff07065599a037d Mon Sep 17 00:00:00 2001 From: jeffreyhuang Date: Thu, 28 Sep 2017 15:54:50 -0700 Subject: [PATCH] Optimize poking to happen in dashboard fragment - Make sure that poking happens only once in onDeveloperOptionsDisabled() Bug: 34203528 Test: make RunSettingsRoboTests -j40 Change-Id: I2a47f34ab17bf57ac4dabc7b0e67b42cc0b120b7 --- .../development/DevelopmentSettingsDashboardFragment.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java b/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java index a4e5de1cfee..dd7703ef704 100644 --- a/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java +++ b/src/com/android/settings/development/DevelopmentSettingsDashboardFragment.java @@ -43,6 +43,7 @@ import com.android.settings.widget.SwitchBar; import com.android.settingslib.core.AbstractPreferenceController; import com.android.settingslib.core.lifecycle.Lifecycle; import com.android.settingslib.development.DevelopmentSettingsEnabler; +import com.android.settingslib.development.SystemPropPoker; import java.util.ArrayList; import java.util.Arrays; @@ -126,12 +127,16 @@ public class DevelopmentSettingsDashboardFragment extends RestrictedDashboardFra EnableDevelopmentSettingWarningDialog.show(this /* host */); } else { DevelopmentSettingsEnabler.setDevelopmentSettingsEnabled(getContext(), false); + final SystemPropPoker poker = SystemPropPoker.getInstance(); + poker.blockPokes(); for (AbstractPreferenceController controller : mPreferenceControllers) { if (controller instanceof DeveloperOptionsPreferenceController) { ((DeveloperOptionsPreferenceController) controller) .onDeveloperOptionsDisabled(); } } + poker.unblockPokes(); + poker.poke(); } } }