PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update survey triggering mechanisms

Browse Source 
Settings will send the Settings screen to a central decision-making
place instead of each page handling its own.

Bug: 236662190
Test: robotest, manual

Change-Id: Ibfbdd421c723158d8d317aa4a02d9b51f877316a
This commit is contained in:
Binyi Wu
2022-07-22 15:33:19 +08:00
parent 08345933df
commit d43ecab8f7
3 changed files with 31 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

102
tests/robotests/src/com/android/settings/survey/SurveyMixinTest.java
View File

@@ -1,20 +1,12 @@
package com.android.settings.survey;
import static com.google.common.truth.Truth.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import android.content.BroadcastReceiver;
import android.content.Context;
import android.content.IntentFilter;
import androidx.fragment.app.FragmentActivity;
import androidx.localbroadcastmanager.content.LocalBroadcastManager;
import com.android.settings.core.InstrumentedPreferenceFragment;
import com.android.settings.overlay.SurveyFeatureProvider;
@@ -28,22 +20,15 @@ import org.mockito.MockitoAnnotations;
import org.robolectric.Robolectric;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.RuntimeEnvironment;
import org.robolectric.util.ReflectionHelpers;
import java.util.ArrayList;
import java.util.HashMap;
@RunWith(RobolectricTestRunner.class)
public class SurveyMixinTest {
private static final String FAKE_KEY = "fake_key";
private static final String FAKE_SURVEY_ID = "fake_id";
private Context mContext;
private SurveyFeatureProvider mProvider;
@Mock
private BroadcastReceiver mReceiver;
@Mock
private InstrumentedPreferenceFragment mFragment;
@Before
@@ -52,99 +37,16 @@ public class SurveyMixinTest {
MockitoAnnotations.initMocks(this);
mContext = RuntimeEnvironment.application;
mProvider = FakeFeatureFactory.setupForTest().getSurveyFeatureProvider(mContext);
when(mProvider.getSurveyId(any(), eq(FAKE_KEY))).thenReturn(FAKE_SURVEY_ID);
}
@Test
public void onResume_triesRegisteringReceiverAndDownloadingWhenNoSurveyDetected() {
// Pretend there is no survey in memory
when(mProvider.getSurveyExpirationDate(any(), any())).thenReturn(-1L);
public void onResume_noActionIfActivityDoesNotExist() {
// Pretend we are an activity that is starting up
FragmentActivity temp = Robolectric.setupActivity(FragmentActivity.class);
when(mFragment.getActivity()).thenReturn(temp);
SurveyMixin mixin = new SurveyMixin(mFragment, FAKE_KEY);
mixin.onResume();
// Verify that a download was attempted
verify(mProvider, times(1)).downloadSurvey(any(), any(), any());
// Verify that we registered a receiver for download completion broadcasts
verify(mProvider, times(1)).createAndRegisterReceiver(any());
// Verify we did not try to show a survey
verify(mProvider, never()).showSurveyIfAvailable(any(), any());
}
@Test
public void onResume_triesShowingSurveyWhenOneIsPresent() {
// Pretend there is a survey in memory
when(mProvider.getSurveyExpirationDate(any(), any())).thenReturn(0L);
// Pretend we are an activity that is starting up
FragmentActivity temp = Robolectric.setupActivity(FragmentActivity.class);
when(mFragment.getActivity()).thenReturn(temp);
SurveyMixin mixin = new SurveyMixin(mFragment, FAKE_KEY);
mixin.onResume();
// Verify that a download was not attempted
verify(mProvider, never()).downloadSurvey(any(), any(), any());
// Verify that we did not register a receiver
verify(mProvider, never()).createAndRegisterReceiver(any());
// Verify we tried to show a survey
verify(mProvider, times(1)).showSurveyIfAvailable(any(), any());
}
@Test
public void onResume_doesNothingWhenActivityIsNull() {
// Pretend the activity died somewhere in the process
when(mFragment.getActivity()).thenReturn(null);
SurveyMixin mixin = new SurveyMixin(mFragment, FAKE_KEY);
mixin.onResume();
// Verify we don't try showing or downloading a survey
verify(mProvider, never()).showSurveyIfAvailable(any(), any());
verify(mProvider, never()).downloadSurvey(any(), any(), any());
}
@Test
public void onPause_removesReceiverIfPreviouslySet() {
// Pretend there is a survey in memory
when(mProvider.getSurveyExpirationDate(any(), any())).thenReturn(-1L);
// Pretend we are an activity that starts and stops
FragmentActivity temp = Robolectric.setupActivity(FragmentActivity.class);
when(mFragment.getActivity()).thenReturn(temp);
when(mProvider.createAndRegisterReceiver(any())).thenReturn(mReceiver);
LocalBroadcastManager manager = LocalBroadcastManager.getInstance(temp);
SurveyMixin mixin = new SurveyMixin(mFragment, FAKE_KEY);
mixin.onResume();
manager.registerReceiver(mReceiver, new IntentFilter());
mixin.onPause();
// Verify we remove the receiver
HashMap<BroadcastReceiver, ArrayList<IntentFilter>> map =
ReflectionHelpers.getField(manager, "mReceivers");
assertThat(map.containsKey(mReceiver)).isFalse();
}
@Test
public void onPause_doesNothingWhenActivityOrReceiverNull() {
// Pretend there is a survey in memory
when(mProvider.getSurveyExpirationDate(any(), any())).thenReturn(-1L);
// Pretend we are an activity that fails to create a receiver properly
FragmentActivity temp = Robolectric.setupActivity(FragmentActivity.class);
when(mFragment.getActivity()).thenReturn(temp);
SurveyMixin mixin = new SurveyMixin(mFragment, FAKE_KEY);
mixin.onPause();
// Verify we do nothing;
verify(mProvider, never()).showSurveyIfAvailable(any(), any());
// pretend the activity died before onPause
when(mFragment.getActivity()).thenReturn(null);
mixin.onPause();
// Verify we do nothing
verify(mProvider, never()).showSurveyIfAvailable(any(), any());
verify(mProvider, times(0)).sendActivityIfAvailable(FAKE_KEY);
}
}