From 3d81e3893ed518f2de0a940b4f1235117336fa7b Mon Sep 17 00:00:00 2001 From: Hao Dong Date: Wed, 7 Jun 2023 18:14:13 +0000 Subject: [PATCH] Clean up multi window toast on FingerprintEnrollEnrolling. ag/22361082 and ag/22460413 have added a dialog preventing entering FingerprintEnrollEnrolling. So showing toast and early return in onCreate() will never be reached. This CL cleans up this obsolete code block. Bug: 283244022 Test: N/A Change-Id: Ifc5f3d909a275c735035146e44f70d2b5d5b51e3 --- .../fingerprint/FingerprintEnrollEnrolling.java | 9 --------- .../fingerprint/FingerprintEnrollEnrollingTest.java | 11 ----------- 2 files changed, 20 deletions(-) diff --git a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java index 400a92ee7a7..386daae7db4 100644 --- a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java +++ b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java @@ -59,7 +59,6 @@ import android.view.animation.Interpolator; import android.widget.ProgressBar; import android.widget.RelativeLayout; import android.widget.TextView; -import android.widget.Toast; import androidx.annotation.IdRes; import androidx.appcompat.app.AlertDialog; @@ -217,14 +216,6 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { protected void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); - if (isInMultiWindowMode()) { - final Toast splitUnsupportedToast = Toast.makeText(this, - R.string.dock_multi_instances_not_supported_text, Toast.LENGTH_SHORT); - splitUnsupportedToast.show(); - finish(); - return; - } - if (savedInstanceState != null) { restoreSavedState(savedInstanceState); } diff --git a/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java b/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java index 8c84128913f..948e056ba75 100644 --- a/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java +++ b/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java @@ -78,7 +78,6 @@ import org.mockito.MockitoAnnotations; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; import org.robolectric.android.controller.ActivityController; -import org.robolectric.shadows.ShadowToast; import org.robolectric.util.ReflectionHelpers; import java.util.ArrayList; @@ -119,16 +118,6 @@ public class FingerprintEnrollEnrollingTest { FakeFeatureFactory.setupForTest(); } - @Test - public void fingerprintMultiWindowMode() { - initializeActivityWithoutCreate(TYPE_UDFPS_OPTICAL); - when(mActivity.isInMultiWindowMode()).thenReturn(true); - createActivity(); - - assertThat(ShadowToast.getTextOfLatestToast()).isEqualTo( - mContext.getString(R.string.dock_multi_instances_not_supported_text)); - } - @Test public void fingerprintUdfpsEnrollSuccessProgress_shouldNotVibrate() { initializeActivityFor(TYPE_UDFPS_OPTICAL);