diff --git a/res/layout/notification_channel_panel.xml b/res/layout/notification_channel_panel.xml index 18e634269b8..fd94707f997 100644 --- a/res/layout/notification_channel_panel.xml +++ b/res/layout/notification_channel_panel.xml @@ -16,8 +16,8 @@ diff --git a/res/layout/sfps_enroll_enrolling.xml b/res/layout/sfps_enroll_enrolling.xml index 498d751a055..e0f9d1f8454 100644 --- a/res/layout/sfps_enroll_enrolling.xml +++ b/res/layout/sfps_enroll_enrolling.xml @@ -32,11 +32,13 @@ android:clipChildren="false"> + android:orientation="vertical" + android:translationX="0dp"> 248dp 348dp - 300dp + 300dp diff --git a/res/values/dimens.xml b/res/values/dimens.xml index f8d3e5013a2..ba98c307869 100755 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -458,6 +458,9 @@ 52dp 16dp + + 600dp + 28dp 24dp diff --git a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java index 0b30f879bc6..c76a58a5043 100644 --- a/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java +++ b/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrolling.java @@ -53,10 +53,12 @@ import android.view.Surface; import android.view.View; import android.view.accessibility.AccessibilityEvent; import android.view.accessibility.AccessibilityManager; +import android.view.animation.AccelerateDecelerateInterpolator; import android.view.animation.AnimationUtils; import android.view.animation.Interpolator; import android.widget.LinearLayout; import android.widget.ProgressBar; +import android.widget.RelativeLayout; import android.widget.TextView; import androidx.annotation.IdRes; @@ -185,6 +187,7 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { private boolean mHaveShownSfpsLeftEdgeLottie; private boolean mHaveShownSfpsRightEdgeLottie; private boolean mShouldShowLottie; + private ObjectAnimator mHelpAnimation; private OrientationEventListener mOrientationEventListener; private int mPreviousRotation = 0; @@ -276,6 +279,7 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { } else if (mCanAssumeSfps) { setContentView(R.layout.sfps_enroll_enrolling); setDescriptionText(R.string.security_settings_fingerprint_enroll_start_message); + setHelpAnimation(); } else { setContentView(R.layout.fingerprint_enroll_enrolling); setDescriptionText(R.string.security_settings_fingerprint_enroll_start_message); @@ -350,6 +354,17 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { maybeHideSfpsText(config); } + private void setHelpAnimation() { + final float translationX = 40; + final int duration = 550; + final RelativeLayout progressLottieLayout = findViewById(R.id.progress_lottie); + mHelpAnimation = ObjectAnimator.ofFloat(progressLottieLayout, + "translationX" /* propertyName */, + 0, translationX, -1 * translationX, translationX, 0f); + mHelpAnimation.setInterpolator(new AccelerateDecelerateInterpolator()); + mHelpAnimation.setDuration(duration); + mHelpAnimation.setAutoCancel(false); + } @Override protected BiometricEnrollSidecar getSidecar() { final FingerprintEnrollSidecar sidecar = new FingerprintEnrollSidecar(this, @@ -755,6 +770,7 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { if (!TextUtils.isEmpty(helpString)) { if (!(mCanAssumeUdfps || mCanAssumeSfps)) { mErrorText.removeCallbacks(mTouchAgainRunnable); + mErrorText.removeCallbacks(mTouchAgainRunnable); } showError(helpString); } @@ -848,6 +864,9 @@ public class FingerprintEnrollEnrolling extends BiometricsEnrollEnrolling { // Show nothing for subtitle when getting an error message. setDescriptionText(""); if (mCanAssumeSfps) { + if (!mHelpAnimation.isRunning()) { + mHelpAnimation.start(); + } applySfpsErrorDynamicColors(getApplicationContext(), true); } } else { diff --git a/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java b/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java index ee6ae223169..9052322f8c3 100644 --- a/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java +++ b/tests/robotests/src/com/android/settings/biometrics/fingerprint/FingerprintEnrollEnrollingTest.java @@ -36,6 +36,7 @@ import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; +import android.animation.ObjectAnimator; import android.content.Context; import android.content.res.ColorStateList; import android.content.res.Resources; @@ -80,6 +81,8 @@ public class FingerprintEnrollEnrollingTest { @Mock private LottieAnimationView mIllustrationLottie; + @Mock private ObjectAnimator mHelpAnimation; + @Mock private FingerprintEnrollSidecar mSidecar; @Mock private Display mMockDisplay; @@ -178,6 +181,15 @@ public class FingerprintEnrollEnrollingTest { assertThat(observedLottieAssetOrder).isEqualTo(expectedLottieAssetOrder); } + @Test + public void fingerprintSfpsEnrollHelpAnimation() { + initializeActivityFor(TYPE_POWER_BUTTON); + ReflectionHelpers.setField(mActivity, "mHelpAnimation", mHelpAnimation); + mActivity.onEnrollmentHelp(0 /* helpMsgId */, "Test help message" /* helpString */); + + verify(mHelpAnimation).start(); + } + // SFPS_STAGE_CENTER is first stage with progress bar colors, starts at steps=25, remaining=25 private void configureSfpsStageColorTest() { when(mSidecar.getEnrollmentSteps()).thenReturn(25);