Merge "Add unaudited exported flag to exposed runtime receivers"

This commit is contained in:
Michael Groover
2022-01-03 17:35:02 +00:00
committed by Android (Google) Code Review
25 changed files with 52 additions and 26 deletions

View File

@@ -58,7 +58,8 @@ public class WorkModePreferenceController extends BasePreferenceController imple
@Override @Override
public void onStart() { public void onStart() {
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -52,7 +52,8 @@ public class AlwaysDiscoverable extends BroadcastReceiver {
if (mStarted) { if (mStarted) {
return; return;
} }
mContext.registerReceiver(this, mIntentFilter); mContext.registerReceiver(this, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
mStarted = true; mStarted = true;
if (mBluetoothAdapter.getScanMode() if (mBluetoothAdapter.getScanMode()
!= BluetoothAdapter.SCAN_MODE_CONNECTABLE_DISCOVERABLE) { != BluetoothAdapter.SCAN_MODE_CONNECTABLE_DISCOVERABLE) {

View File

@@ -115,7 +115,8 @@ public final class BluetoothEnabler implements SwitchWidgetController.OnSwitchCh
} }
mSwitchController.startListening(); mSwitchController.startListening();
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
mValidListener = true; mValidListener = true;
} }

View File

@@ -57,7 +57,8 @@ public class AddDevicePreferenceController extends BasePreferenceController
@Override @Override
public void onStart() { public void onStart() {
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -111,7 +111,8 @@ public class PreviouslyConnectedDevicePreferenceController extends BasePreferenc
public void onStart() { public void onStart() {
mBluetoothDeviceUpdater.registerCallback(); mBluetoothDeviceUpdater.registerCallback();
mSavedDockUpdater.registerCallback(); mSavedDockUpdater.registerCallback();
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
mBluetoothDeviceUpdater.refreshPreference(); mBluetoothDeviceUpdater.refreshPreference();
} }

View File

@@ -189,7 +189,8 @@ public class AdbQrcodeScannerFragment extends WifiDppQrCodeBaseFragment implemen
restartCamera(); restartCamera();
mAdbManager = IAdbManager.Stub.asInterface(ServiceManager.getService(Context.ADB_SERVICE)); mAdbManager = IAdbManager.Stub.asInterface(ServiceManager.getService(Context.ADB_SERVICE));
getActivity().registerReceiver(mReceiver, mIntentFilter); getActivity().registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -227,7 +227,8 @@ public class WirelessDebuggingFragment extends DashboardFragment
public void onResume() { public void onResume() {
super.onResume(); super.onResume();
getActivity().registerReceiver(mReceiver, mIntentFilter); getActivity().registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -99,7 +99,8 @@ public abstract class LocationInjectedServiceBasePreferenceController
}; };
} }
mContext.registerReceiver( mContext.registerReceiver(
mInjectedSettingsReceiver, INTENT_FILTER_INJECTED_SETTING_CHANGED); mInjectedSettingsReceiver, INTENT_FILTER_INJECTED_SETTING_CHANGED,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
/** @OnLifecycleEvent(ON_PAUSE) */ /** @OnLifecycleEvent(ON_PAUSE) */

View File

@@ -302,7 +302,8 @@ public abstract class ActiveSubscriptionsListener
mSubscriptionChangeReceiver = getSubscriptionChangeReceiver(); mSubscriptionChangeReceiver = getSubscriptionChangeReceiver();
} }
mContext.registerReceiver(mSubscriptionChangeReceiver, mContext.registerReceiver(mSubscriptionChangeReceiver,
mSubscriptionChangeIntentFilter, null, new Handler(mLooper)); mSubscriptionChangeIntentFilter, null, new Handler(mLooper),
Context.RECEIVER_EXPORTED_UNAUDITED);
registerForSubscriptionsChange(); registerForSubscriptionsChange();
mCacheState.compareAndSet(STATE_PREPARING, STATE_LISTENING); mCacheState.compareAndSet(STATE_PREPARING, STATE_LISTENING);
return; return;

View File

@@ -105,7 +105,8 @@ public class InternetResetHelper implements LifecycleObserver,
/** @OnLifecycleEvent(Lifecycle.Event.ON_RESUME) */ /** @OnLifecycleEvent(Lifecycle.Event.ON_RESUME) */
@OnLifecycleEvent(Lifecycle.Event.ON_RESUME) @OnLifecycleEvent(Lifecycle.Event.ON_RESUME)
public void onResume() { public void onResume() {
mContext.registerReceiver(mWifiStateReceiver, mWifiStateFilter); mContext.registerReceiver(mWifiStateReceiver, mWifiStateFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
/** @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE) */ /** @OnLifecycleEvent(Lifecycle.Event.ON_PAUSE) */

View File

@@ -182,7 +182,8 @@ public class InternetUpdater implements AirplaneModeEnabler.OnAirplaneModeChange
public void onResume() { public void onResume() {
mAirplaneModeEnabler.start(); mAirplaneModeEnabler.start();
mConnectivityManager.registerDefaultNetworkCallback(mNetworkCallback); mConnectivityManager.registerDefaultNetworkCallback(mNetworkCallback);
mContext.registerReceiver(mWifiStateReceiver, mWifiStateFilter); mContext.registerReceiver(mWifiStateReceiver, mWifiStateFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
/** @OnLifecycleEvent(ON_PAUSE) */ /** @OnLifecycleEvent(ON_PAUSE) */

View File

@@ -267,7 +267,8 @@ public class ApnSettings extends RestrictedSettingsFragment
return; return;
} }
getActivity().registerReceiver(mReceiver, mIntentFilter); getActivity().registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
restartPhoneStateListener(mSubId); restartPhoneStateListener(mSubId);

View File

@@ -59,7 +59,8 @@ public abstract class BaseNfcEnabler {
return; return;
} }
handleNfcStateChanged(mNfcAdapter.getAdapterState()); handleNfcStateChanged(mNfcAdapter.getAdapterState());
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
public void pause() { public void pause() {

View File

@@ -74,7 +74,8 @@ public class VolumePanel implements PanelContent, LifecycleObserver {
public void onResume() { public void onResume() {
final IntentFilter filter = new IntentFilter(); final IntentFilter filter = new IntentFilter();
filter.addAction(MediaOutputConstants.ACTION_CLOSE_PANEL); filter.addAction(MediaOutputConstants.ACTION_CLOSE_PANEL);
mContext.registerReceiver(mReceiver, filter); mContext.registerReceiver(mReceiver, filter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
/** Invoked when the panel is paused. */ /** Invoked when the panel is paused. */

View File

@@ -131,7 +131,8 @@ public class CryptKeeperSettings extends InstrumentedPreferenceFragment {
@Override @Override
public void onResume() { public void onResume() {
super.onResume(); super.onResume();
getActivity().registerReceiver(mIntentReceiver, mIntentFilter); getActivity().registerReceiver(mIntentReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -309,7 +309,8 @@ public class UserSettings extends SettingsPreferenceFragment
mAddSupervisedUser.setOnPreferenceClickListener(this); mAddSupervisedUser.setOnPreferenceClickListener(this);
activity.registerReceiverAsUser( activity.registerReceiverAsUser(
mUserChangeReceiver, UserHandle.ALL, USER_REMOVED_INTENT_FILTER, null, mHandler); mUserChangeReceiver, UserHandle.ALL, USER_REMOVED_INTENT_FILTER, null, mHandler,
Context.RECEIVER_EXPORTED_UNAUDITED);
updateUI(); updateUI();
mShouldUpdateUserList = false; mShouldUpdateUserList = false;

View File

@@ -118,7 +118,8 @@ public class WifiEnabler implements SwitchWidgetController.OnSwitchChangeListene
public void resume(Context context) { public void resume(Context context) {
mContext = context; mContext = context;
// Wi-Fi state is sticky, so just let the receiver update UI // Wi-Fi state is sticky, so just let the receiver update UI
mContext.registerReceiver(mReceiver, mIntentFilter); mContext.registerReceiver(mReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
if (!mListeningToOnSwitchChange) { if (!mListeningToOnSwitchChange) {
mSwitchWidget.startListening(); mSwitchWidget.startListening();
mListeningToOnSwitchChange = true; mListeningToOnSwitchChange = true;

View File

@@ -125,7 +125,8 @@ public class WifiStatusTest extends Activity {
mWifiStateFilter.addAction(WifiManager.RSSI_CHANGED_ACTION); mWifiStateFilter.addAction(WifiManager.RSSI_CHANGED_ACTION);
mWifiStateFilter.addAction(WifiManager.WIFI_STATE_CHANGED_ACTION); mWifiStateFilter.addAction(WifiManager.WIFI_STATE_CHANGED_ACTION);
registerReceiver(mWifiStateReceiver, mWifiStateFilter); registerReceiver(mWifiStateReceiver, mWifiStateFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
setContentView(R.layout.wifi_status_test); setContentView(R.layout.wifi_status_test);
@@ -157,7 +158,8 @@ public class WifiStatusTest extends Activity {
@Override @Override
protected void onResume() { protected void onResume() {
super.onResume(); super.onResume();
registerReceiver(mWifiStateReceiver, mWifiStateFilter); registerReceiver(mWifiStateReceiver, mWifiStateFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -76,7 +76,8 @@ public final class WifiSummaryUpdater extends SummaryUpdater {
if (register) { if (register) {
mWifiTracker.fetchInitialState(); mWifiTracker.fetchInitialState();
notifyChangeIfNeeded(); notifyChangeIfNeeded();
mContext.registerReceiver(mReceiver, INTENT_FILTER); mContext.registerReceiver(mReceiver, INTENT_FILTER,
Context.RECEIVER_EXPORTED_UNAUDITED);
} else { } else {
mContext.unregisterReceiver(mReceiver); mContext.unregisterReceiver(mReceiver);
} }

View File

@@ -429,7 +429,8 @@ public class WifiCallingSettingsForSub extends SettingsPreferenceFragment
mValidListener = true; mValidListener = true;
} }
context.registerReceiver(mIntentReceiver, mIntentFilter); context.registerReceiver(mIntentReceiver, mIntentFilter,
Context.RECEIVER_EXPORTED_UNAUDITED);
final Intent intent = getActivity().getIntent(); final Intent intent = getActivity().getIntent();
if (intent.getBooleanExtra(Phone.EXTRA_KEY_ALERT_SHOW, false)) { if (intent.getBooleanExtra(Phone.EXTRA_KEY_ALERT_SHOW, false)) {

View File

@@ -147,7 +147,8 @@ public class WifiTetherSettings extends RestrictedDashboardFragment
} }
final Context context = getContext(); final Context context = getContext();
if (context != null) { if (context != null) {
context.registerReceiver(mTetherChangeReceiver, TETHER_STATE_CHANGE_FILTER); context.registerReceiver(mTetherChangeReceiver, TETHER_STATE_CHANGE_FILTER,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
} }

View File

@@ -83,7 +83,8 @@ public class WifiTetherSwitchBarController implements
public void onStart() { public void onStart() {
mDataSaverBackend.addListener(this); mDataSaverBackend.addListener(this);
mSwitch.setOnClickListener(this); mSwitch.setOnClickListener(this);
mContext.registerReceiver(mReceiver, WIFI_INTENT_FILTER); mContext.registerReceiver(mReceiver, WIFI_INTENT_FILTER,
Context.RECEIVER_EXPORTED_UNAUDITED);
} }
@Override @Override

View File

@@ -101,7 +101,8 @@ public class InternetPreferenceControllerTest {
public void onResume_shouldRegisterCallback() { public void onResume_shouldRegisterCallback() {
mController.onResume(); mController.onResume();
verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class)); verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class),
any(int.class));
verify(mConnectivityManager).registerNetworkCallback( verify(mConnectivityManager).registerNetworkCallback(
any(NetworkRequest.class), any(NetworkRequest.class),
any(ConnectivityManager.NetworkCallback.class), any(ConnectivityManager.NetworkCallback.class),

View File

@@ -121,7 +121,8 @@ public class InternetResetHelperTest {
public void onResume_registerReceiver() { public void onResume_registerReceiver() {
mInternetResetHelper.onResume(); mInternetResetHelper.onResume();
verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class)); verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class),
any(int.class));
} }
@Test @Test

View File

@@ -88,7 +88,8 @@ public class InternetUpdaterTest {
mInternetUpdater.onResume(); mInternetUpdater.onResume();
verify(mAirplaneModeEnabler).start(); verify(mAirplaneModeEnabler).start();
verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class)); verify(mContext).registerReceiver(any(BroadcastReceiver.class), any(IntentFilter.class),
any(int.class));
verify(mConnectivityManager).registerDefaultNetworkCallback( verify(mConnectivityManager).registerDefaultNetworkCallback(
any(ConnectivityManager.NetworkCallback.class)); any(ConnectivityManager.NetworkCallback.class));
// Unregister callbacks // Unregister callbacks