From 0333f74b9c54227cee22f04fbb08a562771504e9 Mon Sep 17 00:00:00 2001 From: Daisuke Miyakawa Date: Wed, 15 Dec 2010 15:21:25 -0800 Subject: [PATCH 1/6] Use different text in unsecured network. We don't show any config UI when network is unsecured, while Previously we've shown "Enter network configuration" anyway. Also stop showing network status on StatusText (above AccessPoint). New network status often appears and instructions are removed unexpectedly. Bug: 3175016 Change-Id: I3aa288930a8643e178f7c3897b326b7e00964361 --- res/values/strings.xml | 4 ++++ .../settings/wifi/WifiSettingsForSetupWizardXL.java | 7 +++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/res/values/strings.xml b/res/values/strings.xml index 0e428169430..e6bed299521 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -2984,6 +2984,10 @@ found in the list of installed applications. networks and the UI is showing one possible existing network. Used in Wifi Setup. --> Connect to existing network + + Connect to unsecured network diff --git a/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java b/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java index 1781847ba0b..145e6824c5d 100644 --- a/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java +++ b/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java @@ -265,7 +265,6 @@ public class WifiSettingsForSetupWizardXL extends Activity implements OnClickLis mProgressBar.setIndeterminate(false); mProgressBar.setProgress(0); - mStatusText.setText(stateString); mProgressText.setText(stateString); mAddNetworkButton.setEnabled(true); @@ -322,7 +321,11 @@ public class WifiSettingsForSetupWizardXL extends Activity implements OnClickLis } // parent.addView(view); - mStatusText.setText(R.string.wifi_setup_status_edit_network); + if (selectedAccessPoint.security == AccessPoint.SECURITY_NONE) { + mStatusText.setText(R.string.wifi_setup_status_unsecured_network); + } else { + mStatusText.setText(R.string.wifi_setup_status_edit_network); + } mAddNetworkButton.setVisibility(View.GONE); mRefreshButton.setVisibility(View.GONE); mSkipOrNextButton.setVisibility(View.GONE); From dadf1e53cb99691689028667aab473ea4ccf67fa Mon Sep 17 00:00:00 2001 From: Daisuke Miyakawa Date: Wed, 15 Dec 2010 12:27:59 -0800 Subject: [PATCH 2/6] Show "not configurable" screen in EAP Bug: 3175016 Change-Id: If67c0cbf41adee205c8b3eec410e39bc29c2f04d --- res/layout/wifi_config_ui_for_setup_wizard.xml | 12 ++++++++++++ res/values/strings.xml | 12 ++++++++++-- .../android/settings/wifi/WifiConfigController.java | 11 +++++++++++ .../settings/wifi/WifiSettingsForSetupWizardXL.java | 2 ++ 4 files changed, 35 insertions(+), 2 deletions(-) diff --git a/res/layout/wifi_config_ui_for_setup_wizard.xml b/res/layout/wifi_config_ui_for_setup_wizard.xml index 2a4fa653de6..c32920a1e20 100644 --- a/res/layout/wifi_config_ui_for_setup_wizard.xml +++ b/res/layout/wifi_config_ui_for_setup_wizard.xml @@ -105,6 +105,18 @@ android:entries="@array/wifi_security" /> + + + + if needed. Used in Wifi Setup with XL screen. [CHAR LIMIT=35] --> Enter network configuration + button. Used in Wifi Setup For Setup Wizard with XL screen. [CHAR LIMIT=35] --> Connect to new network + Used in Wifi Setup For Setup Wizard with XL screen. [CHAR LIMIT=35] --> Connecting... Proceed to the next step + + EAP not supported + + You can\u0027t configure an EAP Wi-Fi connection during setup. After setup, you can do that in Settings, under Wireless & Networks. Select Time Zone diff --git a/src/com/android/settings/wifi/WifiConfigController.java b/src/com/android/settings/wifi/WifiConfigController.java index 1a882d40c29..649f7de78d5 100644 --- a/src/com/android/settings/wifi/WifiConfigController.java +++ b/src/com/android/settings/wifi/WifiConfigController.java @@ -121,6 +121,9 @@ public class WifiConfigController implements TextWatcher, private ProxySettings mProxySettings; private LinkProperties mLinkProperties = new LinkProperties(); + // True when this instance is used in SetupWizard XL context. + private final boolean mInXlSetupWizard; + static boolean requireKeyStore(WifiConfiguration config) { if (config == null) { return false; @@ -138,6 +141,7 @@ public class WifiConfigController implements TextWatcher, public WifiConfigController( WifiConfigUiBase parent, View view, AccessPoint accessPoint, boolean edit) { mConfigUi = parent; + mInXlSetupWizard = (parent instanceof WifiConfigUiForSetupWizardXL); mView = view; mAccessPoint = accessPoint; @@ -474,6 +478,13 @@ public class WifiConfigController implements TextWatcher, if (mAccessPointSecurity == AccessPoint.SECURITY_NONE) { mView.findViewById(R.id.security_fields).setVisibility(View.GONE); return; + } else if (mAccessPointSecurity == AccessPoint.SECURITY_EAP && mInXlSetupWizard) { + // In SetupWizard for XLarge screen, we don't have enough space for showing + // configurations needed for EAP. We instead disable the whole feature there and let + // users configure those networks after the setup. + mView.findViewById(R.id.eap_not_supported).setVisibility(View.VISIBLE); + mView.findViewById(R.id.security_fields).setVisibility(View.GONE); + return; } mView.findViewById(R.id.security_fields).setVisibility(View.VISIBLE); diff --git a/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java b/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java index 145e6824c5d..fa38d6250ce 100644 --- a/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java +++ b/src/com/android/settings/wifi/WifiSettingsForSetupWizardXL.java @@ -323,6 +323,8 @@ public class WifiSettingsForSetupWizardXL extends Activity implements OnClickLis if (selectedAccessPoint.security == AccessPoint.SECURITY_NONE) { mStatusText.setText(R.string.wifi_setup_status_unsecured_network); + } else if (selectedAccessPoint.security == AccessPoint.SECURITY_EAP) { + mStatusText.setText(R.string.wifi_setup_status_eap_not_supported); } else { mStatusText.setText(R.string.wifi_setup_status_edit_network); } From 22c4b39e0673582c752eaf0978681a152751bdd2 Mon Sep 17 00:00:00 2001 From: Jake Hamby Date: Mon, 13 Dec 2010 15:06:01 -0800 Subject: [PATCH 3/6] Change BT pairing UI PIN dialog string for clarity. When pairing with a Bluetooth keyboard, the user may not realize that the PIN should be entered on the keyboard as well as the device. Added "You may need to enter the same PIN on the Bluetooth device." to pairing dialog string. Also, remove unused Bluetooth device info debug strings. Bug: 3270429 Change-Id: I6d7fa70cf7b12c1feafb8347f356c568b10ae646 --- res/layout/bluetooth_device_info.xml | 62 ---------------------------- res/values/strings.xml | 20 +-------- 2 files changed, 2 insertions(+), 80 deletions(-) delete mode 100644 res/layout/bluetooth_device_info.xml diff --git a/res/layout/bluetooth_device_info.xml b/res/layout/bluetooth_device_info.xml deleted file mode 100644 index 4178734ee46..00000000000 --- a/res/layout/bluetooth_device_info.xml +++ /dev/null @@ -1,62 +0,0 @@ - - - - - - - - - - -