From d13146bf83aeca291c945735149eeea5238a4c1b Mon Sep 17 00:00:00 2001
From: Becca Hughes <beccahughes@google.com>
Date: Mon, 6 Feb 2023 21:39:24 +0000
Subject: [PATCH] Hide password managers from cred man settings

Hides legacy password managers from credential
manager settings.

Bug: 267816303
Test: make
Change-Id: I985a72426aef9bd7b08f9e11a4fa8ecedcc9ed30
---
 res/xml/accounts_dashboard_settings_credman.xml            | 7 -------
 res/xml/accounts_personal_dashboard_settings_credman.xml   | 7 -------
 res/xml/accounts_work_dashboard_settings_credman.xml       | 7 -------
 .../settings/accounts/AccountDashboardFragment.java        | 4 ++--
 .../accounts/AccountPersonalDashboardFragment.java         | 4 ++--
 .../accounts/AccountWorkProfileDashboardFragment.java      | 4 ++--
 6 files changed, 6 insertions(+), 27 deletions(-)

diff --git a/res/xml/accounts_dashboard_settings_credman.xml b/res/xml/accounts_dashboard_settings_credman.xml
index 605d315bcbc..38f3f5560de 100644
--- a/res/xml/accounts_dashboard_settings_credman.xml
+++ b/res/xml/accounts_dashboard_settings_credman.xml
@@ -45,13 +45,6 @@
         settings:controller="com.android.settings.applications.credentials.CredentialManagerPreferenceController"
         settings:keywords="@string/credman_keywords" />
 
-    <PreferenceCategory
-        android:key="passwords_category"
-        android:order="30"
-        android:persistent="false"
-        settings:controller="com.android.settings.applications.autofill.PasswordsPreferenceController"
-        settings:keywords="@string/autofill_keywords" />
-
     <PreferenceCategory
         android:key="dashboard_tile_placeholder"
         android:order="130"/>
diff --git a/res/xml/accounts_personal_dashboard_settings_credman.xml b/res/xml/accounts_personal_dashboard_settings_credman.xml
index a5188dd6885..c3f061dde3b 100644
--- a/res/xml/accounts_personal_dashboard_settings_credman.xml
+++ b/res/xml/accounts_personal_dashboard_settings_credman.xml
@@ -46,13 +46,6 @@
         settings:controller="com.android.settings.applications.credentials.CredentialManagerPreferenceController"
         settings:keywords="@string/credman_keywords" />
 
-    <PreferenceCategory
-        android:key="passwords_category"
-        android:order="30"
-        android:persistent="false"
-        settings:controller="com.android.settings.applications.autofill.PasswordsPreferenceController"
-        settings:keywords="@string/autofill_keywords" />
-
     <PreferenceCategory
         android:key="dashboard_tile_placeholder"
         android:order="130"/>
diff --git a/res/xml/accounts_work_dashboard_settings_credman.xml b/res/xml/accounts_work_dashboard_settings_credman.xml
index f4e8af2f27a..155947629dc 100644
--- a/res/xml/accounts_work_dashboard_settings_credman.xml
+++ b/res/xml/accounts_work_dashboard_settings_credman.xml
@@ -46,13 +46,6 @@
         settings:controller="com.android.settings.applications.credentials.CredentialManagerPreferenceController"
         settings:keywords="@string/credman_keywords" />
 
-    <PreferenceCategory
-        android:key="passwords_category"
-        android:order="30"
-        android:persistent="false"
-        settings:controller="com.android.settings.applications.autofill.PasswordsPreferenceController"
-        settings:keywords="@string/autofill_keywords" />
-
     <PreferenceCategory
         android:key="dashboard_tile_placeholder"
         android:order="130"/>
diff --git a/src/com/android/settings/accounts/AccountDashboardFragment.java b/src/com/android/settings/accounts/AccountDashboardFragment.java
index 16351e834f3..bba28262bb5 100644
--- a/src/com/android/settings/accounts/AccountDashboardFragment.java
+++ b/src/com/android/settings/accounts/AccountDashboardFragment.java
@@ -76,9 +76,9 @@ public class AccountDashboardFragment extends DashboardFragment {
             CredentialManagerPreferenceController cmpp =
                     use(CredentialManagerPreferenceController.class);
             cmpp.init(this, getFragmentManager());
+        } else {
+            getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
         }
-
-        getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
     }
 
     @Override
diff --git a/src/com/android/settings/accounts/AccountPersonalDashboardFragment.java b/src/com/android/settings/accounts/AccountPersonalDashboardFragment.java
index 30fb1a1c5af..e0d49d2171a 100644
--- a/src/com/android/settings/accounts/AccountPersonalDashboardFragment.java
+++ b/src/com/android/settings/accounts/AccountPersonalDashboardFragment.java
@@ -70,9 +70,9 @@ public class AccountPersonalDashboardFragment extends DashboardFragment {
             CredentialManagerPreferenceController cmpp =
                     use(CredentialManagerPreferenceController.class);
             cmpp.init(this, getFragmentManager());
+        } else {
+            getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
         }
-
-        getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
     }
 
     @Override
diff --git a/src/com/android/settings/accounts/AccountWorkProfileDashboardFragment.java b/src/com/android/settings/accounts/AccountWorkProfileDashboardFragment.java
index 5a894575aeb..da380b3b140 100644
--- a/src/com/android/settings/accounts/AccountWorkProfileDashboardFragment.java
+++ b/src/com/android/settings/accounts/AccountWorkProfileDashboardFragment.java
@@ -70,9 +70,9 @@ public class AccountWorkProfileDashboardFragment extends DashboardFragment {
             CredentialManagerPreferenceController cmpp =
                     use(CredentialManagerPreferenceController.class);
             cmpp.init(this, getFragmentManager());
+        } else {
+            getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
         }
-
-        getSettingsLifecycle().addObserver(use(PasswordsPreferenceController.class));
     }
 
     @Override