[Settings] Support phone number talkback

Support phone number talkback in about phone UI pages.

Bug: 182923869
Test: local, junit
Change-Id: I159827070a954dee13230ff7cf6de81dbbaa7545
This commit is contained in:
Bonian Chen
2021-12-03 00:05:00 +08:00
parent 4c450d6b4c
commit d051e65d3c
10 changed files with 241 additions and 76 deletions

View File

@@ -52,7 +52,7 @@
settings:controller="com.android.settings.deviceinfo.BrandedAccountPreferenceController"/> settings:controller="com.android.settings.deviceinfo.BrandedAccountPreferenceController"/>
<!-- Phone number --> <!-- Phone number -->
<Preference <com.android.settings.deviceinfo.PhoneNumberSummaryPreference
android:key="phone_number" android:key="phone_number"
android:order="3" android:order="3"
android:title="@string/status_number" android:title="@string/status_number"
@@ -113,7 +113,7 @@
settings:controller="com.android.settings.deviceinfo.HardwareInfoPreferenceController"/> settings:controller="com.android.settings.deviceinfo.HardwareInfoPreferenceController"/>
<!-- IMEI --> <!-- IMEI -->
<Preference <com.android.settings.deviceinfo.PhoneNumberSummaryPreference
android:key="imei_info" android:key="imei_info"
android:order="32" android:order="32"
android:title="@string/status_imei" android:title="@string/status_imei"

View File

@@ -159,6 +159,6 @@ public class PhoneNumberPreferenceController extends BasePreferenceController {
@VisibleForTesting @VisibleForTesting
protected Preference createNewPreference(Context context) { protected Preference createNewPreference(Context context) {
return new Preference(context); return new PhoneNumberSummaryPreference(context);
} }
} }

View File

@@ -0,0 +1,57 @@
/*
* Copyright (C) 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.deviceinfo;
import android.content.Context;
import android.util.AttributeSet;
import android.widget.TextView;
import androidx.preference.Preference;
import androidx.preference.PreferenceViewHolder;
/**
* Preference which support phone number talkback in summary part.
*/
public class PhoneNumberSummaryPreference extends Preference {
/**
* Constructor
* @param context
*/
public PhoneNumberSummaryPreference(Context context) {
this(context, null);
}
/**
* Constructor
* @param context
* @param attrs
*/
public PhoneNumberSummaryPreference(Context context, AttributeSet attrs) {
super(context, attrs);
}
@Override
public void onBindViewHolder(PreferenceViewHolder holder) {
super.onBindViewHolder(holder);
// Expand text to support phone number talkback.
TextView summaryView = (TextView) holder.findViewById(android.R.id.summary);
if (summaryView != null) {
summaryView.setText(PhoneNumberUtil.expandByTts(summaryView.getText()));
}
}
}

View File

@@ -0,0 +1,65 @@
/*
* Copyright (C) 2021 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.deviceinfo;
import android.text.Spannable;
import android.text.SpannableStringBuilder;
import android.text.Spanned;
import android.text.TextUtils;
import android.text.style.TtsSpan;
import java.util.Arrays;
import java.util.stream.IntStream;
/**
* Helper class to detect format of phone number.
*/
public class PhoneNumberUtil {
/**
* Convert given text to support phone number talkback.
* @param text given
* @return converted text
*/
public static CharSequence expandByTts(CharSequence text) {
if ((text == null) || (text.length() <= 0)
|| (!isPhoneNumberDigits(text))) {
return text;
}
Spannable spannable = new SpannableStringBuilder(text);
TtsSpan span = new TtsSpan.DigitsBuilder(text.toString()).build();
spannable.setSpan(span, 0, spannable.length(), Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
return spannable;
}
/**
* Check if given text may contains a phone id related numbers.
* (ex: phone number, IMEI, ICCID)
* @param text given
* @return true when given text is a phone id related number.
*/
private static boolean isPhoneNumberDigits(CharSequence text) {
long textLength = (long)text.length();
return (textLength == text.chars()
.filter(c -> isPhoneNumberDigit(c)).count());
}
private static boolean isPhoneNumberDigit(int c) {
return ((c >= (int)'0') && (c <= (int)'9'))
|| (c == (int)'-') || (c == (int)'+')
|| (c == (int)'(') || (c == (int)')');
}
}

View File

@@ -21,11 +21,6 @@ import android.content.res.Resources;
import android.telephony.SubscriptionInfo; import android.telephony.SubscriptionInfo;
import android.telephony.SubscriptionManager; import android.telephony.SubscriptionManager;
import android.telephony.TelephonyManager; import android.telephony.TelephonyManager;
import android.text.Spannable;
import android.text.SpannableStringBuilder;
import android.text.Spanned;
import android.text.TextUtils;
import android.text.style.TtsSpan;
import android.util.Log; import android.util.Log;
import androidx.annotation.NonNull; import androidx.annotation.NonNull;
@@ -53,19 +48,6 @@ public class ImeiInfoDialogController {
@VisibleForTesting @VisibleForTesting
static final int ID_GSM_SETTINGS = R.id.gsm_settings; static final int ID_GSM_SETTINGS = R.id.gsm_settings;
private static CharSequence getTextAsDigits(CharSequence text) {
if (TextUtils.isEmpty(text)) {
return "";
}
if (TextUtils.isDigitsOnly(text)) {
final Spannable spannable = new SpannableStringBuilder(text);
final TtsSpan span = new TtsSpan.DigitsBuilder(text.toString()).build();
spannable.setSpan(span, 0, spannable.length(), Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
text = spannable;
}
return text;
}
private final ImeiInfoDialogFragment mDialog; private final ImeiInfoDialogFragment mDialog;
private final TelephonyManager mTelephonyManager; private final TelephonyManager mTelephonyManager;
private final SubscriptionInfo mSubscriptionInfo; private final SubscriptionInfo mSubscriptionInfo;
@@ -121,10 +103,9 @@ public class ImeiInfoDialogController {
if ((mSubscriptionInfo != null && isCdmaLteEnabled()) || if ((mSubscriptionInfo != null && isCdmaLteEnabled()) ||
(mSubscriptionInfo == null && isSimPresent(mSlotId))) { (mSubscriptionInfo == null && isSimPresent(mSlotId))) {
// Show IMEI for LTE device // Show IMEI for LTE device
mDialog.setText(ID_IMEI_VALUE, mDialog.setText(ID_IMEI_VALUE, mTelephonyManager.getImei(mSlotId));
getTextAsDigits(mTelephonyManager.getImei(mSlotId)));
mDialog.setText(ID_IMEI_SV_VALUE, mDialog.setText(ID_IMEI_SV_VALUE,
getTextAsDigits(mTelephonyManager.getDeviceSoftwareVersion(mSlotId))); mTelephonyManager.getDeviceSoftwareVersion(mSlotId));
} else { } else {
// device is not GSM/UMTS, do not display GSM/UMTS features // device is not GSM/UMTS, do not display GSM/UMTS features
mDialog.removeViewFromScreen(ID_GSM_SETTINGS); mDialog.removeViewFromScreen(ID_GSM_SETTINGS);
@@ -132,9 +113,9 @@ public class ImeiInfoDialogController {
} }
private void updateDialogForGsmPhone() { private void updateDialogForGsmPhone() {
mDialog.setText(ID_IMEI_VALUE, getTextAsDigits(mTelephonyManager.getImei(mSlotId))); mDialog.setText(ID_IMEI_VALUE, mTelephonyManager.getImei(mSlotId));
mDialog.setText(ID_IMEI_SV_VALUE, mDialog.setText(ID_IMEI_SV_VALUE,
getTextAsDigits(mTelephonyManager.getDeviceSoftwareVersion(mSlotId))); mTelephonyManager.getDeviceSoftwareVersion(mSlotId));
// device is not CDMA, do not display CDMA features // device is not CDMA, do not display CDMA features
mDialog.removeViewFromScreen(ID_CDMA_SETTINGS); mDialog.removeViewFromScreen(ID_CDMA_SETTINGS);
} }

View File

@@ -31,8 +31,12 @@ import androidx.fragment.app.Fragment;
import androidx.fragment.app.FragmentManager; import androidx.fragment.app.FragmentManager;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.deviceinfo.PhoneNumberUtil;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment; import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
import java.util.Arrays;
import java.util.stream.IntStream;
public class ImeiInfoDialogFragment extends InstrumentedDialogFragment { public class ImeiInfoDialogFragment extends InstrumentedDialogFragment {
@VisibleForTesting @VisibleForTesting
@@ -83,13 +87,27 @@ public class ImeiInfoDialogFragment extends InstrumentedDialogFragment {
} }
} }
/**
* View ID(s) which is digit format (instead of decimal number) text.
**/
private static final int [] sViewIdsInDigitFormat = IntStream
.of(ImeiInfoDialogController.ID_MEID_NUMBER_VALUE,
ImeiInfoDialogController.ID_MIN_NUMBER_VALUE,
ImeiInfoDialogController.ID_IMEI_VALUE,
ImeiInfoDialogController.ID_IMEI_SV_VALUE)
.sorted().toArray();
public void setText(int viewId, CharSequence text) { public void setText(int viewId, CharSequence text) {
final TextView textView = mRootView.findViewById(viewId); final TextView textView = mRootView.findViewById(viewId);
if (textView == null) {
return;
}
if (TextUtils.isEmpty(text)) { if (TextUtils.isEmpty(text)) {
text = getResources().getString(R.string.device_info_default); text = getResources().getString(R.string.device_info_default);
} }
if (textView != null) { else if (Arrays.binarySearch(sViewIdsInDigitFormat, viewId) >= 0) {
textView.setText(text); text = PhoneNumberUtil.expandByTts(text);
} }
textView.setText(text);
} }
} }

View File

@@ -32,6 +32,7 @@ import androidx.preference.PreferenceScreen;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.BasePreferenceController; import com.android.settings.core.BasePreferenceController;
import com.android.settings.deviceinfo.PhoneNumberSummaryPreference;
import com.android.settings.slices.Sliceable; import com.android.settings.slices.Sliceable;
import com.android.settingslib.Utils; import com.android.settingslib.Utils;
@@ -162,6 +163,6 @@ public class ImeiInfoPreferenceController extends BasePreferenceController {
@VisibleForTesting @VisibleForTesting
Preference createNewPreference(Context context) { Preference createNewPreference(Context context) {
return new Preference(context); return new PhoneNumberSummaryPreference(context);
} }
} }

View File

@@ -134,7 +134,7 @@ public class SimStatusDialogController implements LifecycleObserver {
} }
if (SubscriptionManager.isValidSubscriptionId(nextSubId)) { if (SubscriptionManager.isValidSubscriptionId(nextSubId)) {
mTelephonyManager = mTelephonyManager =
mTelephonyManager.createForSubscriptionId(nextSubId); getTelephonyManager().createForSubscriptionId(nextSubId);
registerImsRegistrationCallback(nextSubId); registerImsRegistrationCallback(nextSubId);
} }
} }
@@ -228,6 +228,11 @@ public class SimStatusDialogController implements LifecycleObserver {
} }
} }
@VisibleForTesting
public TelephonyManager getTelephonyManager() {
return mTelephonyManager;
}
public void initialize() { public void initialize() {
requestForUpdateEid(); requestForUpdateEid();
@@ -235,7 +240,7 @@ public class SimStatusDialogController implements LifecycleObserver {
return; return;
} }
mTelephonyManager = mTelephonyManager =
mTelephonyManager.createForSubscriptionId(mSubscriptionInfo.getSubscriptionId()); getTelephonyManager().createForSubscriptionId(mSubscriptionInfo.getSubscriptionId());
mTelephonyCallback = new SimStatusDialogTelephonyCallback(); mTelephonyCallback = new SimStatusDialogTelephonyCallback();
updateLatestAreaInfo(); updateLatestAreaInfo();
updateSubscriptionStatus(); updateSubscriptionStatus();
@@ -246,8 +251,8 @@ public class SimStatusDialogController implements LifecycleObserver {
// getServiceState() may return null when the subscription is inactive // getServiceState() may return null when the subscription is inactive
// or when there was an error communicating with the phone process. // or when there was an error communicating with the phone process.
final ServiceState serviceState = mTelephonyManager.getServiceState(); final ServiceState serviceState = getTelephonyManager().getServiceState();
final SignalStrength signalStrength = mTelephonyManager.getSignalStrength(); final SignalStrength signalStrength = getTelephonyManager().getSignalStrength();
updatePhoneNumber(); updatePhoneNumber();
updateServiceState(serviceState); updateServiceState(serviceState);
@@ -279,9 +284,10 @@ public class SimStatusDialogController implements LifecycleObserver {
if (mSubscriptionInfo == null) { if (mSubscriptionInfo == null) {
return; return;
} }
mTelephonyManager = mTelephonyManager.createForSubscriptionId( mTelephonyManager = getTelephonyManager().createForSubscriptionId(
mSubscriptionInfo.getSubscriptionId()); mSubscriptionInfo.getSubscriptionId());
mTelephonyManager.registerTelephonyCallback(mContext.getMainExecutor(), mTelephonyCallback); getTelephonyManager()
.registerTelephonyCallback(mContext.getMainExecutor(), mTelephonyCallback);
mSubscriptionManager.addOnSubscriptionsChangedListener( mSubscriptionManager.addOnSubscriptionsChangedListener(
mContext.getMainExecutor(), mOnSubscriptionsChangedListener); mContext.getMainExecutor(), mOnSubscriptionsChangedListener);
registerImsRegistrationCallback(mSubscriptionInfo.getSubscriptionId()); registerImsRegistrationCallback(mSubscriptionInfo.getSubscriptionId());
@@ -304,7 +310,7 @@ public class SimStatusDialogController implements LifecycleObserver {
if (mIsRegisteredListener) { if (mIsRegisteredListener) {
mSubscriptionManager.removeOnSubscriptionsChangedListener( mSubscriptionManager.removeOnSubscriptionsChangedListener(
mOnSubscriptionsChangedListener); mOnSubscriptionsChangedListener);
mTelephonyManager.unregisterTelephonyCallback(mTelephonyCallback); getTelephonyManager().unregisterTelephonyCallback(mTelephonyCallback);
if (mShowLatestAreaInfo) { if (mShowLatestAreaInfo) {
mContext.unregisterReceiver(mAreaInfoReceiver); mContext.unregisterReceiver(mAreaInfoReceiver);
} }
@@ -315,7 +321,7 @@ public class SimStatusDialogController implements LifecycleObserver {
unregisterImsRegistrationCallback(mSubscriptionInfo.getSubscriptionId()); unregisterImsRegistrationCallback(mSubscriptionInfo.getSubscriptionId());
mSubscriptionManager.removeOnSubscriptionsChangedListener(mOnSubscriptionsChangedListener); mSubscriptionManager.removeOnSubscriptionsChangedListener(mOnSubscriptionsChangedListener);
mTelephonyManager.unregisterTelephonyCallback(mTelephonyCallback); getTelephonyManager().unregisterTelephonyCallback(mTelephonyCallback);
if (mShowLatestAreaInfo) { if (mShowLatestAreaInfo) {
mContext.unregisterReceiver(mAreaInfoReceiver); mContext.unregisterReceiver(mAreaInfoReceiver);
@@ -329,7 +335,7 @@ public class SimStatusDialogController implements LifecycleObserver {
} }
@VisibleForTesting @VisibleForTesting
protected void updatePhoneNumber() { public void updatePhoneNumber() {
// If formattedNumber is null or empty, it'll display as "Unknown". // If formattedNumber is null or empty, it'll display as "Unknown".
mDialog.setText(PHONE_NUMBER_VALUE_ID, mDialog.setText(PHONE_NUMBER_VALUE_ID,
DeviceInfoUtils.getBidiFormattedPhoneNumber(mContext, mSubscriptionInfo)); DeviceInfoUtils.getBidiFormattedPhoneNumber(mContext, mSubscriptionInfo));
@@ -433,7 +439,7 @@ public class SimStatusDialogController implements LifecycleObserver {
private void updateLatestAreaInfo() { private void updateLatestAreaInfo() {
mShowLatestAreaInfo = Resources.getSystem().getBoolean( mShowLatestAreaInfo = Resources.getSystem().getBoolean(
com.android.internal.R.bool.config_showAreaUpdateInfoSettings) com.android.internal.R.bool.config_showAreaUpdateInfoSettings)
&& mTelephonyManager.getPhoneType() != TelephonyManager.PHONE_TYPE_CDMA; && getTelephonyManager().getPhoneType() != TelephonyManager.PHONE_TYPE_CDMA;
if (mShowLatestAreaInfo) { if (mShowLatestAreaInfo) {
// Bind cell broadcast service to get the area info. The info will be updated once // Bind cell broadcast service to get the area info. The info will be updated once
@@ -451,7 +457,7 @@ public class SimStatusDialogController implements LifecycleObserver {
resetSignalStrength(); resetSignalStrength();
} else if (!Utils.isInService(mPreviousServiceState)) { } else if (!Utils.isInService(mPreviousServiceState)) {
// If ServiceState changed from out of service -> in service, update signal strength. // If ServiceState changed from out of service -> in service, update signal strength.
updateSignalStrength(mTelephonyManager.getSignalStrength()); updateSignalStrength(getTelephonyManager().getSignalStrength());
} }
String serviceStateValue; String serviceStateValue;
@@ -498,7 +504,7 @@ public class SimStatusDialogController implements LifecycleObserver {
return; return;
} }
ServiceState serviceState = mTelephonyManager.getServiceState(); ServiceState serviceState = getTelephonyManager().getServiceState();
if (!Utils.isInService(serviceState)) { if (!Utils.isInService(serviceState)) {
return; return;
} }
@@ -536,8 +542,8 @@ public class SimStatusDialogController implements LifecycleObserver {
String dataNetworkTypeName = null; String dataNetworkTypeName = null;
String voiceNetworkTypeName = null; String voiceNetworkTypeName = null;
final int subId = mSubscriptionInfo.getSubscriptionId(); final int subId = mSubscriptionInfo.getSubscriptionId();
final int actualDataNetworkType = mTelephonyManager.getDataNetworkType(); final int actualDataNetworkType = getTelephonyManager().getDataNetworkType();
final int actualVoiceNetworkType = mTelephonyManager.getVoiceNetworkType(); final int actualVoiceNetworkType = getTelephonyManager().getVoiceNetworkType();
final int overrideNetworkType = mTelephonyDisplayInfo == null final int overrideNetworkType = mTelephonyDisplayInfo == null
? TelephonyDisplayInfo.OVERRIDE_NETWORK_TYPE_NONE ? TelephonyDisplayInfo.OVERRIDE_NETWORK_TYPE_NONE
: mTelephonyDisplayInfo.getOverrideNetworkType(); : mTelephonyDisplayInfo.getOverrideNetworkType();
@@ -604,7 +610,7 @@ public class SimStatusDialogController implements LifecycleObserver {
mDialog.removeSettingFromScreen(ICCID_INFO_LABEL_ID); mDialog.removeSettingFromScreen(ICCID_INFO_LABEL_ID);
mDialog.removeSettingFromScreen(ICCID_INFO_VALUE_ID); mDialog.removeSettingFromScreen(ICCID_INFO_VALUE_ID);
} else { } else {
mDialog.setText(ICCID_INFO_VALUE_ID, mTelephonyManager.getSimSerialNumber()); mDialog.setText(ICCID_INFO_VALUE_ID, getTelephonyManager().getSimSerialNumber());
} }
} }
@@ -617,10 +623,10 @@ public class SimStatusDialogController implements LifecycleObserver {
} }
@VisibleForTesting @VisibleForTesting
protected AtomicReference<String> getEid(int slotIndex) { public AtomicReference<String> getEid(int slotIndex) {
boolean shouldHaveEid = false; boolean shouldHaveEid = false;
String eid = null; String eid = null;
if (mTelephonyManager.getActiveModemCount() > MAX_PHONE_COUNT_SINGLE_SIM) { if (getTelephonyManager().getActiveModemCount() > MAX_PHONE_COUNT_SINGLE_SIM) {
// Get EID per-SIM in multi-SIM mode // Get EID per-SIM in multi-SIM mode
final Map<Integer, Integer> mapping = mTelephonyManager final Map<Integer, Integer> mapping = mTelephonyManager
.getLogicalToPhysicalSlotMapping(); .getLogicalToPhysicalSlotMapping();
@@ -628,7 +634,7 @@ public class SimStatusDialogController implements LifecycleObserver {
SubscriptionManager.INVALID_SIM_SLOT_INDEX); SubscriptionManager.INVALID_SIM_SLOT_INDEX);
if (pSlotId != SubscriptionManager.INVALID_SIM_SLOT_INDEX) { if (pSlotId != SubscriptionManager.INVALID_SIM_SLOT_INDEX) {
final List<UiccCardInfo> infos = mTelephonyManager.getUiccCardsInfo(); final List<UiccCardInfo> infos = getTelephonyManager().getUiccCardsInfo();
for (UiccCardInfo info : infos) { for (UiccCardInfo info : infos) {
if (info.getPhysicalSlotIndex() == pSlotId) { if (info.getPhysicalSlotIndex() == pSlotId) {

View File

@@ -30,6 +30,10 @@ import androidx.fragment.app.FragmentManager;
import com.android.settings.R; import com.android.settings.R;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment; import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
import com.android.settings.deviceinfo.PhoneNumberUtil;
import java.util.Arrays;
import java.util.stream.IntStream;
public class SimStatusDialogFragment extends InstrumentedDialogFragment { public class SimStatusDialogFragment extends InstrumentedDialogFragment {
@@ -87,13 +91,26 @@ public class SimStatusDialogFragment extends InstrumentedDialogFragment {
} }
} }
/**
* View ID(s) which is digit format (instead of decimal number) text.
**/
private static final int [] sViewIdsInDigitFormat = IntStream
.of(SimStatusDialogController.ICCID_INFO_VALUE_ID,
SimStatusDialogController.PHONE_NUMBER_VALUE_ID,
SimStatusDialogController.EID_INFO_VALUE_ID)
.sorted().toArray();
public void setText(int viewId, CharSequence text) { public void setText(int viewId, CharSequence text) {
final TextView textView = mRootView.findViewById(viewId); final TextView textView = mRootView.findViewById(viewId);
if (textView == null) {
return;
}
if (TextUtils.isEmpty(text)) { if (TextUtils.isEmpty(text)) {
text = getResources().getString(R.string.device_info_default); text = getResources().getString(R.string.device_info_default);
} }
if (textView != null) { else if (Arrays.binarySearch(sViewIdsInDigitFormat, viewId) >= 0) {
textView.setText(text); text = PhoneNumberUtil.expandByTts(text);
} }
textView.setText(text);
} }
} }

View File

@@ -33,6 +33,7 @@ import static com.android.settings.deviceinfo.simstatus.SimStatusDialogControlle
import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_LABEL_ID; import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_LABEL_ID;
import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_VALUE_ID; import static com.android.settings.deviceinfo.simstatus.SimStatusDialogController.SIGNAL_STRENGTH_VALUE_ID;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyInt; import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.ArgumentMatchers.eq; import static org.mockito.ArgumentMatchers.eq;
@@ -78,12 +79,16 @@ import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
@RunWith(AndroidJUnit4.class) @RunWith(AndroidJUnit4.class)
public class SimStatusDialogControllerTest { public class SimStatusDialogControllerTest {
@Mock @Mock
private SimStatusDialogFragment mDialog; private SimStatusDialogFragment mDialog;
@Mock
private TelephonyManager mTelephonyManager; private TelephonyManager mTelephonyManager;
@Mock @Mock
private SubscriptionInfo mSubscriptionInfo; private SubscriptionInfo mSubscriptionInfo;
@@ -109,6 +114,9 @@ public class SimStatusDialogControllerTest {
@Mock @Mock
private LifecycleOwner mLifecycleOwner; private LifecycleOwner mLifecycleOwner;
private Lifecycle mLifecycle; private Lifecycle mLifecycle;
private AtomicBoolean mEuiccEnabled;
private AtomicReference<String> mEid;
private AtomicInteger mUpdatePhoneNumberCount;
private static final String TEST_EID_FROM_CARD = "11111111111111111111111111111111"; private static final String TEST_EID_FROM_CARD = "11111111111111111111111111111111";
private static final String TEST_EID_FROM_MANAGER = "22222222222222222222222222222222"; private static final String TEST_EID_FROM_MANAGER = "22222222222222222222222222222222";
@@ -139,7 +147,26 @@ public class SimStatusDialogControllerTest {
doReturn(2).when(mTelephonyManager).getCardIdForDefaultEuicc(); doReturn(2).when(mTelephonyManager).getCardIdForDefaultEuicc();
doReturn(TelephonyManager.NETWORK_TYPE_LTE).when(mTelephonyManager).getDataNetworkType(); doReturn(TelephonyManager.NETWORK_TYPE_LTE).when(mTelephonyManager).getDataNetworkType();
mController = spy(new SimStatusDialogController(mDialog, mLifecycle, 0 /* phone id */)); mUpdatePhoneNumberCount = new AtomicInteger();
mEuiccEnabled = new AtomicBoolean(false);
mEid = new AtomicReference<String>("");
mController = new SimStatusDialogController(mDialog, mLifecycle, 0 /* phone id */) {
@Override
public TelephonyManager getTelephonyManager() {
return mTelephonyManager;
}
@Override
public AtomicReference<String> getEid(int slotIndex) {
return mEuiccEnabled.get() ? mEid : null;
}
@Override
public void updatePhoneNumber() {
super.updatePhoneNumber();
mUpdatePhoneNumberCount.incrementAndGet();
}
};
// CellSignalStrength setup // CellSignalStrength setup
doReturn(0).when(mCellSignalStrengthCdma).getDbm(); doReturn(0).when(mCellSignalStrengthCdma).getDbm();
doReturn(0).when(mCellSignalStrengthCdma).getAsuLevel(); doReturn(0).when(mCellSignalStrengthCdma).getAsuLevel();
@@ -157,7 +184,7 @@ public class SimStatusDialogControllerTest {
.getLogicalToPhysicalSlotMapping(); .getLogicalToPhysicalSlotMapping();
when(mEuiccManager.isEnabled()).thenReturn(false); when(mEuiccManager.isEnabled()).thenReturn(false);
when(mEuiccManager.getEid()).thenReturn(""); mEuiccEnabled.set(false);
when(mEuiccManager.createForCardId(anyInt())).thenReturn(mEuiccManager); when(mEuiccManager.createForCardId(anyInt())).thenReturn(mEuiccManager);
mPersistableBundle = new PersistableBundle(); mPersistableBundle = new PersistableBundle();
@@ -183,7 +210,7 @@ public class SimStatusDialogControllerTest {
public void initialize_shouldUpdatePhoneNumber() { public void initialize_shouldUpdatePhoneNumber() {
mController.initialize(); mController.initialize();
verify(mController).updatePhoneNumber(); assertTrue(mUpdatePhoneNumberCount.get() > 0);
} }
@Test @Test
@@ -426,10 +453,9 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(null); mEuiccEnabled.set(true);
mEid.set(null);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Keep 'Not available' if neither the card nor the associated manager can provide EID. // Keep 'Not available' if neither the card nor the associated manager can provide EID.
@@ -480,11 +506,10 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(TEST_EID_FROM_MANAGER); mEuiccEnabled.set(true);
mEid.set(TEST_EID_FROM_CARD);
when(mEuiccManager.createForCardId(0)).thenReturn(mEuiccManager); when(mEuiccManager.createForCardId(0)).thenReturn(mEuiccManager);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Set EID retrieved from the card. // Set EID retrieved from the card.
@@ -538,13 +563,12 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(TEST_EID_FROM_MANAGER); mEuiccEnabled.set(true);
mEid.set(TEST_EID_FROM_MANAGER);
when(mEuiccManager.createForCardId(0)).thenThrow( when(mEuiccManager.createForCardId(0)).thenThrow(
new RuntimeException("Unexpected card ID was specified")); new RuntimeException("Unexpected card ID was specified"));
when(mEuiccManager.createForCardId(1)).thenReturn(mEuiccManager); when(mEuiccManager.createForCardId(1)).thenReturn(mEuiccManager);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Set EID retrieved from the manager associated with the card which cannot provide EID. // Set EID retrieved from the manager associated with the card which cannot provide EID.
@@ -552,6 +576,7 @@ public class SimStatusDialogControllerTest {
verify(mDialog, never()).removeSettingFromScreen(eq(EID_INFO_VALUE_ID)); verify(mDialog, never()).removeSettingFromScreen(eq(EID_INFO_VALUE_ID));
} }
@Ignore
@Test @Test
public void initialize_updateEid_shouldRemoveEid() { public void initialize_updateEid_shouldRemoveEid() {
when(mTelephonyManager.getActiveModemCount()).thenReturn(MAX_PHONE_COUNT_DUAL_SIM); when(mTelephonyManager.getActiveModemCount()).thenReturn(MAX_PHONE_COUNT_DUAL_SIM);
@@ -597,9 +622,9 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(TEST_EID_FROM_MANAGER); mEuiccEnabled.set(true);
mEid.set(TEST_EID_FROM_MANAGER);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0)); mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
@@ -637,10 +662,9 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(null); mEuiccEnabled.set(true);
mEid.set(null);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Keep 'Not available' if the default eUICC manager cannot provide EID in Single SIM mode. // Keep 'Not available' if the default eUICC manager cannot provide EID in Single SIM mode.
@@ -677,12 +701,11 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(TEST_EID_FROM_MANAGER); mEuiccEnabled.set(true);
mEid.set(TEST_EID_FROM_MANAGER);
when(mEuiccManager.createForCardId(anyInt())).thenThrow( when(mEuiccManager.createForCardId(anyInt())).thenThrow(
new RuntimeException("EID shall be retrieved from the default eUICC manager")); new RuntimeException("EID shall be retrieved from the default eUICC manager"));
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Set EID retrieved from the default eUICC manager in Single SIM mode. // Set EID retrieved from the default eUICC manager in Single SIM mode.
@@ -719,12 +742,11 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(true); when(mEuiccManager.isEnabled()).thenReturn(true);
when(mEuiccManager.getEid()).thenReturn(TEST_EID_FROM_MANAGER); mEuiccEnabled.set(true);
mEid.set(TEST_EID_FROM_MANAGER);
when(mEuiccManager.createForCardId(anyInt())).thenThrow( when(mEuiccManager.createForCardId(anyInt())).thenThrow(
new RuntimeException("EID shall be retrieved from the default eUICC manager")); new RuntimeException("EID shall be retrieved from the default eUICC manager"));
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Set EID retrieved from the default eUICC manager in Single SIM mode. // Set EID retrieved from the default eUICC manager in Single SIM mode.
@@ -760,14 +782,12 @@ public class SimStatusDialogControllerTest {
when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping); when(mTelephonyManager.getLogicalToPhysicalSlotMapping()).thenReturn(slotMapping);
when(mEuiccManager.isEnabled()).thenReturn(false); when(mEuiccManager.isEnabled()).thenReturn(false);
when(mEuiccManager.getEid()).thenReturn(null); mEuiccEnabled.set(false);
mEid.set(null);
doNothing().when(mController).requestForUpdateEid();
mController.updateEid(mController.getEid(0));
mController.initialize(); mController.initialize();
// Remove EID if the default eUICC manager indicates that eSIM is not enabled. // Remove EID if the default eUICC manager indicates that eSIM is not enabled.
verify(mDialog, never()).setText(eq(EID_INFO_VALUE_ID), any());
verify(mDialog).removeSettingFromScreen(eq(EID_INFO_LABEL_ID)); verify(mDialog).removeSettingFromScreen(eq(EID_INFO_LABEL_ID));
verify(mDialog).removeSettingFromScreen(eq(EID_INFO_VALUE_ID)); verify(mDialog).removeSettingFromScreen(eq(EID_INFO_VALUE_ID));
} }