diff --git a/res/values/strings.xml b/res/values/strings.xml index 7e1f46ebd69..dbf20d3acff 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -10793,34 +10793,34 @@ ANGLE enabled application: %1$s - - Game Driver Preferences - - Modify Game Driver settings - - When Game Driver is turned on, you can pick to use the updated graphics driver for Apps installed on the device. - - Enable for all apps - - Select Graphics Driver - - Default + + Graphics Driver Preferences + + Modify graphics driver settings + + When there are multiple graphics drivers, you can pick to use the updated graphics driver for Apps installed on the device. + + Enable for all apps + + Select Graphics Driver + + Default - Game Driver - - Prerelease Driver - - System Graphics Driver - - - @string/game_driver_app_preference_default - @string/game_driver_app_preference_game_driver + Game Driver + + Prerelease Driver + + System Graphics Driver + + + @string/graphics_driver_app_preference_default + @string/graphics_driver_app_preference_game_driver - - - @string/game_driver_app_preference_default - @string/game_driver_app_preference_game_driver - @string/game_driver_app_preference_system + + + @string/graphics_driver_app_preference_default + @string/graphics_driver_app_preference_game_driver + @string/graphics_driver_app_preference_system diff --git a/res/xml/development_settings.xml b/res/xml/development_settings.xml index acd50adb1c7..ff6640cc1c2 100644 --- a/res/xml/development_settings.xml +++ b/res/xml/development_settings.xml @@ -217,9 +217,9 @@ android:summary="@string/enable_gpu_debug_layers_summary" /> diff --git a/res/xml/game_driver_settings.xml b/res/xml/graphics_driver_settings.xml similarity index 67% rename from res/xml/game_driver_settings.xml rename to res/xml/graphics_driver_settings.xml index e4673204701..e4aa04ed9cd 100644 --- a/res/xml/game_driver_settings.xml +++ b/res/xml/graphics_driver_settings.xml @@ -18,27 +18,27 @@ + android:key="graphics_driver_settings" + android:title="@string/graphics_driver_dashboard_title"> diff --git a/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceController.java b/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceController.java index 489408d4818..d6bdb54bf0f 100644 --- a/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceController.java +++ b/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceController.java @@ -85,14 +85,14 @@ public class GameDriverAppPreferenceController extends BasePreferenceController new GameDriverContentObserver(new Handler(Looper.getMainLooper()), this); final Resources resources = context.getResources(); - mEntryList = resources.getStringArray(R.array.game_driver_app_preference_values); - mPreferenceTitle = resources.getString(R.string.game_driver_app_preference_title); - mPreferenceDefault = resources.getString(R.string.game_driver_app_preference_default); + mEntryList = resources.getStringArray(R.array.graphics_driver_app_preference_values); + mPreferenceTitle = resources.getString(R.string.graphics_driver_app_preference_title); + mPreferenceDefault = resources.getString(R.string.graphics_driver_app_preference_default); mPreferenceGameDriver = - resources.getString(R.string.game_driver_app_preference_game_driver); + resources.getString(R.string.graphics_driver_app_preference_game_driver); mPreferencePrereleaseDriver = - resources.getString(R.string.game_driver_app_preference_prerelease_driver); - mPreferenceSystem = resources.getString(R.string.game_driver_app_preference_system); + resources.getString(R.string.graphics_driver_app_preference_prerelease_driver); + mPreferenceSystem = resources.getString(R.string.graphics_driver_app_preference_system); // TODO: Move this task to background if there's potential ANR/Jank. // Update the UI when all the app infos are ready. diff --git a/src/com/android/settings/development/gamedriver/GameDriverDashboard.java b/src/com/android/settings/development/gamedriver/GameDriverDashboard.java index f67c029cb45..4ef0a878859 100644 --- a/src/com/android/settings/development/gamedriver/GameDriverDashboard.java +++ b/src/com/android/settings/development/gamedriver/GameDriverDashboard.java @@ -49,7 +49,7 @@ public class GameDriverDashboard extends DashboardFragment { @Override protected int getPreferenceScreenResId() { - return R.xml.game_driver_settings; + return R.xml.graphics_driver_settings; } @Override @@ -71,7 +71,7 @@ public class GameDriverDashboard extends DashboardFragment { } public static final BaseSearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = - new BaseSearchIndexProvider(R.xml.game_driver_settings) { + new BaseSearchIndexProvider(R.xml.graphics_driver_settings) { @Override protected boolean isPageSearchEnabled(Context context) { diff --git a/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceController.java b/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceController.java index 290e4b2a1d0..9c816c5244c 100644 --- a/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceController.java +++ b/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceController.java @@ -64,11 +64,11 @@ public class GameDriverEnableForAllAppsPreferenceController extends BasePreferen mContentResolver = context.getContentResolver(); final Resources resources = context.getResources(); - mPreferenceDefault = resources.getString(R.string.game_driver_app_preference_default); + mPreferenceDefault = resources.getString(R.string.graphics_driver_app_preference_default); mPreferenceGameDriver = - resources.getString(R.string.game_driver_app_preference_game_driver); + resources.getString(R.string.graphics_driver_app_preference_game_driver); mPreferencePrereleaseDriver = - resources.getString(R.string.game_driver_app_preference_prerelease_driver); + resources.getString(R.string.graphics_driver_app_preference_prerelease_driver); mGameDriverContentObserver = new GameDriverContentObserver(new Handler(Looper.getMainLooper()), this); } diff --git a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceControllerTest.java index dd5af2b6045..de4be1da007 100644 --- a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverAppPreferenceControllerTest.java @@ -21,6 +21,7 @@ import static com.android.settings.core.BasePreferenceController.CONDITIONALLY_U import static com.android.settings.development.gamedriver.GameDriverEnableForAllAppsPreferenceController.GAME_DRIVER_DEFAULT; import static com.android.settings.development.gamedriver.GameDriverEnableForAllAppsPreferenceController.GAME_DRIVER_OFF; import static com.android.settings.testutils.ApplicationTestUtils.buildInfo; + import static com.google.common.truth.Truth.assertThat; import static org.mockito.Mockito.spy; @@ -41,8 +42,6 @@ import androidx.preference.PreferenceScreen; import com.android.settings.R; -import java.util.Arrays; - import org.junit.Before; import org.junit.Test; import org.junit.runner.RunWith; @@ -51,6 +50,8 @@ import org.mockito.MockitoAnnotations; import org.robolectric.RobolectricTestRunner; import org.robolectric.RuntimeEnvironment; +import java.util.Arrays; + @RunWith(RobolectricTestRunner.class) public class GameDriverAppPreferenceControllerTest { @@ -87,10 +88,13 @@ public class GameDriverAppPreferenceControllerTest { mContext = spy(RuntimeEnvironment.application); mResolver = mContext.getContentResolver(); mValueList = - mContext.getResources().getStringArray(R.array.game_driver_app_preference_values); - mDialogTitle = mContext.getResources().getString(R.string.game_driver_app_preference_title); + mContext.getResources().getStringArray( + R.array.graphics_driver_app_preference_values); + mDialogTitle = mContext.getResources().getString( + R.string.graphics_driver_app_preference_title); mPreferencePrereleaseDriver = - mContext.getResources().getString(R.string.game_driver_app_preference_prerelease_driver); + mContext.getResources().getString( + R.string.graphics_driver_app_preference_prerelease_driver); } @Test diff --git a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverDashboardTest.java b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverDashboardTest.java index f8f8addc9a0..eb5c3b394f8 100644 --- a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverDashboardTest.java +++ b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverDashboardTest.java @@ -50,6 +50,6 @@ public class GameDriverDashboardTest { @Test public void getPreferenceScreen_shouldReturnGameDriverSettings() { - assertThat(mDashboard.getPreferenceScreenResId()).isEqualTo(R.xml.game_driver_settings); + assertThat(mDashboard.getPreferenceScreenResId()).isEqualTo(R.xml.graphics_driver_settings); } } diff --git a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceControllerTest.java index df599713b6e..8495f60f642 100644 --- a/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/development/gamedriver/GameDriverEnableForAllAppsPreferenceControllerTest.java @@ -71,11 +71,11 @@ public class GameDriverEnableForAllAppsPreferenceControllerTest { mResolver = mContext.getContentResolver(); final Resources resources = mContext.getResources(); - mPreferenceDefault = resources.getString(R.string.game_driver_app_preference_default); + mPreferenceDefault = resources.getString(R.string.graphics_driver_app_preference_default); mPreferenceGameDriver = - resources.getString(R.string.game_driver_app_preference_game_driver); + resources.getString(R.string.graphics_driver_app_preference_game_driver); mPreferencePrereleaseDriver = - resources.getString(R.string.game_driver_app_preference_prerelease_driver); + resources.getString(R.string.graphics_driver_app_preference_prerelease_driver); Settings.Global.putInt(mResolver, Settings.Global.DEVELOPMENT_SETTINGS_ENABLED, 1); Settings.Global.putInt( diff --git a/tests/uitests/assets/search_results_list b/tests/uitests/assets/search_results_list index f2536ef06ef..a6dafe2e98e 100644 --- a/tests/uitests/assets/search_results_list +++ b/tests/uitests/assets/search_results_list @@ -224,7 +224,7 @@ Emergency information;emergency_info Enable Bluetooth HCI snoop log;bt_hci_snoop_log Enable GPU debug layers;enable_gpu_debug_layers Enable Wi-Fi Verbose Logging;wifi_verbose_logging -Enable for all apps;game_driver_all_apps_preference +Enable for all apps;graphics_driver_all_apps_preference Enable freeform windows;enable_freeform_support Enable view attribute inspection;debug_view_attributes Encrypt phone;encryption_and_credentials_encryption_status @@ -256,7 +256,7 @@ Force allow apps on external;force_allow_on_external Force desktop mode;force_desktop_mode_on_external_displays Force full GNSS measurements;enable_gnss_raw_meas_full_tracking Free up space;storage_settings_free_space -Game Driver Preferences;game_driver_settings +Graphics Driver Preferences;graphics_driver_settings Games;pref_games Gestures;gesture_settings Gestures;gesture_settings_screen @@ -612,7 +612,7 @@ Wait for debugger;wait_for_debugger Wallpaper;wallpaper Wallpapers;wallpaper_attributions WebView implementation;select_webview_provider -When Game Driver is turned on, you can pick to use the updated graphics driver for Apps installed on the device.;game_driver_footer +When there are multiple graphics drivers, you can pick to use the updated graphics driver for Apps installed on the device.;graphics_driver_footer When device is in VR;vr_display_pref When to start;when_to_start Wi-Fi;main_toggle_wifi