PawletOS/app_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Wi-Fi] Use new defined proto field for adding new networks panel page.

Browse Source 
Use new metric, PANEL_ADD_WIFI_NETWORKS, for proto upload log use.

For R feature: Add a mechanism for apps to add saved networks to the
device, need to apply new metrics category.

Bug: 144891278
Test: Add following test case for testing metric:
      getMetricsCategory_shouldReturnPanelAddWifiNetworks()

Change-Id: I7cde8057c5f2b01c951b1de4203ab1c1a2f0f40a
This commit is contained in:
govenliu
2019-12-18 13:57:30 +08:00
parent 063cf2f059
commit cfd8a5d253
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/com/android/settings/wifi/addappnetworks/AddAppNetworksFragment.java
View File

@@ -164,7 +164,6 @@ public class AddAppNetworksFragment extends InstrumentedFragment {
return inflater.inflate(R.layout.wifi_add_app_networks, container, false); return inflater.inflate(R.layout.wifi_add_app_networks, container, false);
} }
// TODO: Makesure function work correctly after rotate.
@Override @Override
public void onViewCreated(View view, Bundle savedInstanceState) { public void onViewCreated(View view, Bundle savedInstanceState) {
super.onViewCreated(view, savedInstanceState); super.onViewCreated(view, savedInstanceState);
@@ -585,8 +584,7 @@ public class AddAppNetworksFragment extends InstrumentedFragment {
@Override @Override
public int getMetricsCategory() { public int getMetricsCategory() {
// TODO(b/144891278): Need to define a new metric for this page, use the WIFI item first. return SettingsEnums.PANEL_ADD_WIFI_NETWORKS;
return SettingsEnums.WIFI;
} }
private void showSaveStatusByState(int status) { private void showSaveStatusByState(int status) {

8
tests/robotests/src/com/android/settings/wifi/addappnetworks/AddAppNetworksFragmentTest.java
View File

@@ -21,6 +21,7 @@ import static com.google.common.truth.Truth.assertThat;
import static org.mockito.Mockito.doReturn; import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.spy; import static org.mockito.Mockito.spy;
import android.app.settings.SettingsEnums;
import android.net.wifi.WifiConfiguration; import android.net.wifi.WifiConfiguration;
import android.os.Bundle; import android.os.Bundle;
import android.os.Parcelable; import android.os.Parcelable;
@@ -139,6 +140,12 @@ public class AddAppNetworksFragmentTest {
0).mWifiConfiguration.SSID).isEqualTo(FAKE_NEW_OPEN_SSID); 0).mWifiConfiguration.SSID).isEqualTo(FAKE_NEW_OPEN_SSID);
} }
@Test
public void getMetricsCategory_shouldReturnPanelAddWifiNetworks() {
assertThat(mAddAppNetworksFragment.getMetricsCategory()).isEqualTo(
SettingsEnums.PANEL_ADD_WIFI_NETWORKS);
}
private void addOneSavedNetworkConfig(@NonNull WifiConfiguration wifiConfiguration) { private void addOneSavedNetworkConfig(@NonNull WifiConfiguration wifiConfiguration) {
if (mFakeSavedNetworksList == null) { if (mFakeSavedNetworksList == null) {
mFakeSavedNetworksList = new ArrayList<>(); mFakeSavedNetworksList = new ArrayList<>();
@@ -180,5 +187,4 @@ public class AddAppNetworksFragmentTest {
} }
return config; return config;
} }
} }