[Panlingual] Add device default language to suggested group
- Add default language preference - Polish unit test - Fix unsupported locale show on suggested group Bug: 209728327 Test: local test Test: atest pass Change-Id: I69778cb8d69b21314c75689f0d61c25294c7f9d2
This commit is contained in:
tom hsu
@@ -20,6 +20,7 @@ import static org.junit.Assert.assertFalse;
|
||||
import static org.junit.Assert.assertTrue;
|
||||
import static org.mockito.ArgumentMatchers.anyString;
|
||||
import static org.mockito.Mockito.spy;
|
||||
import static org.mockito.Mockito.verify;
|
||||
import static org.mockito.Mockito.when;
|
||||
|
||||
import android.app.LocaleManager;
|
||||
@@ -32,7 +33,7 @@ import androidx.test.annotation.UiThreadTest;
|
||||
import androidx.test.core.app.ApplicationProvider;
|
||||
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
||||
|
||||
import com.google.common.collect.Iterables;
|
||||
import com.android.settingslib.widget.RadioButtonPreference;
|
||||
|
||||
import org.junit.Before;
|
||||
import org.junit.Test;
|
||||
@@ -40,8 +41,14 @@ import org.junit.runner.RunWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.MockitoAnnotations;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.Collection;
|
||||
import java.util.Locale;
|
||||
|
||||
/**
|
||||
* Unittest for ApplocaleDetails
|
||||
* TODO Need to add a unittest for the UI preference component.
|
||||
*/
|
||||
@RunWith(AndroidJUnit4.class)
|
||||
public class AppLocaleDetailsTest {
|
||||
private static final String APP_PACKAGE_NAME = "app_package_name";
|
||||
@@ -52,7 +59,7 @@ public class AppLocaleDetailsTest {
|
||||
private LocaleManager mLocaleManager;
|
||||
|
||||
private Context mContext;
|
||||
private LocaleList mSystemLocales;
|
||||
private Collection<Locale> mSystemLocales;
|
||||
private LocaleList mAppLocale;
|
||||
private String[] mAssetLocales;
|
||||
private LocaleList mPackageLocales;
|
||||
@@ -69,12 +76,48 @@ public class AppLocaleDetailsTest {
|
||||
when(mContext.getSystemService(LocaleManager.class)).thenReturn(mLocaleManager);
|
||||
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "en",
|
||||
/* appLocale= */ "en-gb",
|
||||
/* simCountry= */ "tw",
|
||||
/* networkCountry= */ "jp",
|
||||
/* systemLocales= */ "en, uk, jp, ne",
|
||||
/* packageLocales= */ "pa, cn, tw, en",
|
||||
/* assetLocales= */ new String[]{"en", "ne", "ms", "pa"});
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "pa, cn, zh-tw, en-gb, ja-jp",
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "zh-tw", "ja-jp"});
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void onRadioButtonClicked_setCurrentLocaleToSystem() {
|
||||
AppLocaleDetails appLocaleDetails = new AppLocaleDetails() {
|
||||
@Override
|
||||
void refreshUiInternal() {}
|
||||
};
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
spy(new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME));
|
||||
appLocaleDetails.mAppLocaleDetailsHelper = helper;
|
||||
RadioButtonPreference pref = new RadioButtonPreference(mContext);
|
||||
pref.setKey(AppLocaleDetails.KEY_SYSTEM_DEFAULT_LOCALE);
|
||||
|
||||
appLocaleDetails.onRadioButtonClicked(pref);
|
||||
|
||||
verify(helper).setAppDefaultLocale(LocaleList.forLanguageTags(""));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void onRadioButtonClicked_setCurrentLocaleForUserSelected() {
|
||||
AppLocaleDetails appLocaleDetails = new AppLocaleDetails() {
|
||||
@Override
|
||||
void refreshUiInternal() {}
|
||||
};
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
spy(new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME));
|
||||
appLocaleDetails.mAppLocaleDetailsHelper = helper;
|
||||
RadioButtonPreference pref = new RadioButtonPreference(mContext);
|
||||
pref.setKey("en");
|
||||
|
||||
appLocaleDetails.onRadioButtonClicked(pref);
|
||||
|
||||
verify(helper).setAppDefaultLocale("en");
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -90,7 +133,7 @@ public class AppLocaleDetailsTest {
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_1stLocaleOfSuggestedLocaleListIsAppLocale() {
|
||||
public void handleAllLocalesData_1stLocaleIsAppLocaleAndHasSimAndNetwork() {
|
||||
Locale simCountryLocale = new Locale("zh", "TW");
|
||||
Locale networkCountryLocale = new Locale("ja", "JP");
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
@@ -98,36 +141,122 @@ public class AppLocaleDetailsTest {
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Locale locale = Iterables.get(helper.getSuggestedLocales(), 0);
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
assertTrue(locale.equals(mAppLocale.get(0)));
|
||||
assertTrue(helper.getSuggestedLocales().contains(simCountryLocale));
|
||||
assertTrue(helper.getSuggestedLocales().contains(networkCountryLocale));
|
||||
assertTrue(suggestedLocales.contains(simCountryLocale));
|
||||
assertTrue(suggestedLocales.contains(networkCountryLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_withoutAppLocale_1stSuggestedLocaleIsSimCountryLocale() {
|
||||
Locale simCountryLocale = new Locale("zh", "TW");
|
||||
public void
|
||||
handleAllLocalesData_noAppAndNoSupportedSimLocale_1stSuggestedLocaleIsAssetLocale() {
|
||||
Locale firstAssetLocale = new Locale("en", "GB");
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "tw",
|
||||
/* networkCountry= */ "",
|
||||
/* systemLocales= */ "en, uk, jp, ne",
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{});
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "ja-jp"});
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Locale locale = Iterables.get(helper.getSuggestedLocales(), 0);
|
||||
assertTrue(locale.equals(simCountryLocale));
|
||||
assertFalse(helper.getSuggestedLocales().contains(mAppLocale.get(0)));
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
assertTrue(locale.equals(firstAssetLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_withoutAppLocale_1stSuggestedLocaleIsNetworkCountryLocale() {
|
||||
public void handleAllLocalesData_noAppButHasSupportedSimLocale_1stSuggestedLocaleIsSim() {
|
||||
Locale simLocale = new Locale("zh", "tw");
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "tw",
|
||||
/* networkCountry= */ "",
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "ja-jp", "zh-tw"});
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
assertTrue(locale.equals(simLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void
|
||||
handleAllLocalesData_noAppButHasSupportedNetworkLocale_1stSuggestedLocaleIsNetwork() {
|
||||
Locale networkLocale = new Locale("ja", "JP");
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "",
|
||||
/* networkCountry= */ "jp",
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "ja-jp"});
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
assertTrue(locale.equals(networkLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_noAppSimOrNetworkLocale_suggestedLocalesHasSystemLocale() {
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "",
|
||||
/* networkCountry= */ "",
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "zh-tw", "ja-jp"});
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
assertTrue(suggestedLocales.contains(Locale.forLanguageTag("ne")));
|
||||
// ru language is not present in the asset locales
|
||||
assertFalse(suggestedLocales.contains(Locale.forLanguageTag("ru")));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_noAppButHasSimAndNetworkLocale_1stLocaleIsSimLocale() {
|
||||
Locale simCountryLocale = new Locale("zh", "TW");
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "tw",
|
||||
/* networkCountry= */ "jp",
|
||||
/* systemLocales= */ "en-gb, ru, ja-jp, ne, zh-tw",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{"en-gb", "ne", "ms", "pa", "zh-tw", "ja-jp"});
|
||||
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
assertTrue(locale.equals(simCountryLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_noSupportedLocale_noSuggestedLocales() {
|
||||
Locale networkCountryLocale = new Locale("en", "GB");
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
@@ -141,28 +270,8 @@ public class AppLocaleDetailsTest {
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Locale locale = Iterables.get(helper.getSuggestedLocales(), 0);
|
||||
assertTrue(locale.equals(networkCountryLocale));
|
||||
assertFalse(helper.getSuggestedLocales().contains(mAppLocale.get(0)));
|
||||
}
|
||||
|
||||
@Test
|
||||
@UiThreadTest
|
||||
public void handleAllLocalesData_noAppAndSimNetworkLocale_1stLocaleIsFirstOneInSystemLocales() {
|
||||
setupInitialLocales(
|
||||
/* appLocale= */ "",
|
||||
/* simCountry= */ "",
|
||||
/* networkCountry= */ "",
|
||||
/* systemLocales= */ "en, uk, jp, ne",
|
||||
/* packageLocales= */ "",
|
||||
/* assetLocales= */ new String[]{});
|
||||
DummyAppLocaleDetailsHelper helper =
|
||||
new DummyAppLocaleDetailsHelper(mContext, APP_PACKAGE_NAME);
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Locale locale = Iterables.get(helper.getSuggestedLocales(), 0);
|
||||
assertTrue(locale.equals(mSystemLocales.get(0)));
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
assertTrue(suggestedLocales.size() == 0);
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -180,8 +289,10 @@ public class AppLocaleDetailsTest {
|
||||
|
||||
helper.handleAllLocalesData();
|
||||
|
||||
Locale locale = Iterables.get(helper.getSuggestedLocales(), 0);
|
||||
assertTrue(locale.equals(mSystemLocales.get(0)));
|
||||
Collection<Locale> suggestedLocales = helper.getSuggestedLocales();
|
||||
Locale locale = suggestedLocales.iterator().next();
|
||||
Locale systemLocale = mSystemLocales.iterator().next();
|
||||
assertTrue(locale.equals(systemLocale));
|
||||
}
|
||||
|
||||
@Test
|
||||
@@ -248,15 +359,23 @@ public class AppLocaleDetailsTest {
|
||||
String packageLocales,
|
||||
String[] assetLocales) {
|
||||
mAppLocale = LocaleList.forLanguageTags(appLocale);
|
||||
mSystemLocales = LocaleList.forLanguageTags(systemLocales);
|
||||
// forLanguageTags does not filter space to the input string. If there is any space included
|
||||
// in string, this will make locale fail to generate.
|
||||
systemLocales = systemLocales.replaceAll("\\s+", "");
|
||||
LocaleList listOfSystemLocales = LocaleList.forLanguageTags(systemLocales);
|
||||
mSystemLocales = new ArrayList<>();
|
||||
for (int i = 0; i < listOfSystemLocales.size(); i++) {
|
||||
mSystemLocales.add(listOfSystemLocales.get(i));
|
||||
}
|
||||
mAssetLocales = assetLocales;
|
||||
packageLocales = packageLocales.replaceAll("\\s+", "");
|
||||
mPackageLocales = LocaleList.forLanguageTags(packageLocales);
|
||||
when(mTelephonyManager.getSimCountryIso()).thenReturn(simCountry);
|
||||
when(mTelephonyManager.getNetworkCountryIso()).thenReturn(networkCountry);
|
||||
when(mLocaleManager.getApplicationLocales(anyString())).thenReturn(mAppLocale);
|
||||
}
|
||||
|
||||
private class DummyAppLocaleDetailsHelper
|
||||
public class DummyAppLocaleDetailsHelper
|
||||
extends AppLocaleDetails.AppLocaleDetailsHelper {
|
||||
|
||||
DummyAppLocaleDetailsHelper(Context context, String packageName) {
|
||||
@@ -264,12 +383,12 @@ public class AppLocaleDetailsTest {
|
||||
}
|
||||
|
||||
@Override
|
||||
String[] getAssetSystemLocales() {
|
||||
String[] getAssetLocales() {
|
||||
return mAssetLocales;
|
||||
}
|
||||
|
||||
@Override
|
||||
LocaleList getCurrentSystemLocales() {
|
||||
Collection<Locale> getCurrentSystemLocales() {
|
||||
return mSystemLocales;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user