diff --git a/res/xml/encryption_and_credential.xml b/res/xml/encryption_and_credential.xml index f107b58b107..beaccce1742 100644 --- a/res/xml/encryption_and_credential.xml +++ b/res/xml/encryption_and_credential.xml @@ -27,7 +27,8 @@ android:key="encryption_and_credentials_encryption_status" android:title="@string/crypt_keeper_encrypt_title" android:fragment="com.android.settings.security.CryptKeeperSettings" - android:summary="@string/summary_placeholder" /> + android:summary="@string/summary_placeholder" + settings:controller="com.android.settings.security.EncryptionStatusPreferenceController"/> diff --git a/res/xml/security_advanced_settings.xml b/res/xml/security_advanced_settings.xml index 84ebd4a03c7..3d04d0164a4 100644 --- a/res/xml/security_advanced_settings.xml +++ b/res/xml/security_advanced_settings.xml @@ -47,20 +47,23 @@ android:key="enterprise_privacy" android:title="@string/enterprise_privacy_settings" android:summary="@string/summary_placeholder" - android:fragment="com.android.settings.enterprise.EnterprisePrivacySettings" /> + android:fragment="com.android.settings.enterprise.EnterprisePrivacySettings" + settings:controller="com.android.settings.enterprise.EnterprisePrivacyPreferenceController"/> + android:fragment="com.android.settings.enterprise.EnterprisePrivacySettings" + settings:controller="com.android.settings.enterprise.FinancedPrivacyPreferenceController"/> + android:title="@string/sim_lock_settings_category" + settings:controller="com.android.settings.security.SimLockPreferenceController"> + android:fragment="com.android.settings.security.EncryptionAndCredential" + settings:controller="com.android.settings.security.EncryptionStatusPreferenceController" /> + android:fragment="com.android.settings.security.trustagent.TrustAgentSettings" + settings:controller="com.android.settings.security.trustagent.ManageTrustAgentsPreferenceController" /> + settings:keywords="@string/keywords_app_pinning" + settings:controller="com.android.settings.security.ScreenPinningPreferenceController" /> + settings:controller="com.android.settings.security.ConfirmSimDeletionPreferenceController" /> buildPreferenceControllers(Context context, Lifecycle lifecycle, DashboardFragment host) { final List controllers = new ArrayList<>(); - controllers.add(new EnterprisePrivacyPreferenceController(context)); - controllers.add(new FinancedPrivacyPreferenceController(context)); - controllers.add(new ManageTrustAgentsPreferenceController(context)); - controllers.add(new ScreenPinningPreferenceController(context)); - controllers.add(new SimLockPreferenceController(context)); - controllers.add(new EncryptionStatusPreferenceController(context, - PREF_KEY_ENCRYPTION_SECURITY_PAGE)); controllers.add(new TrustAgentListPreferenceController(context, host, lifecycle)); final List profileSecurityControllers = new ArrayList<>(); diff --git a/src/com/android/settings/security/SimLockPreferenceController.java b/src/com/android/settings/security/SimLockPreferenceController.java index 3b8588852e8..6f663c2409c 100644 --- a/src/com/android/settings/security/SimLockPreferenceController.java +++ b/src/com/android/settings/security/SimLockPreferenceController.java @@ -33,17 +33,11 @@ import java.util.List; public class SimLockPreferenceController extends BasePreferenceController { - private static final String KEY_SIM_LOCK = "sim_lock_settings"; - private final CarrierConfigManager mCarrierConfigManager; private final UserManager mUserManager; private final SubscriptionManager mSubscriptionManager; private TelephonyManager mTelephonyManager; - public SimLockPreferenceController(Context context) { - this(context, KEY_SIM_LOCK); - } - public SimLockPreferenceController(Context context, String key) { super(context, key); mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE); diff --git a/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceController.java b/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceController.java index b0f991efb8c..2f8d58dc412 100644 --- a/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceController.java +++ b/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceController.java @@ -19,7 +19,6 @@ package com.android.settings.security.trustagent; import android.content.Context; import android.os.UserHandle; -import androidx.annotation.VisibleForTesting; import androidx.preference.Preference; import com.android.internal.widget.LockPatternUtils; @@ -30,17 +29,11 @@ import com.android.settings.security.SecurityFeatureProvider; public class ManageTrustAgentsPreferenceController extends BasePreferenceController { - @VisibleForTesting - static final String KEY_MANAGE_TRUST_AGENTS = "manage_trust_agents"; private static final int MY_USER_ID = UserHandle.myUserId(); private final LockPatternUtils mLockPatternUtils; private TrustAgentManager mTrustAgentManager; - public ManageTrustAgentsPreferenceController(Context context) { - this(context, KEY_MANAGE_TRUST_AGENTS); - } - public ManageTrustAgentsPreferenceController(Context context, String key) { super(context, key); final SecurityFeatureProvider securityFeatureProvider = FeatureFactory.getFactory(context) diff --git a/tests/robotests/src/com/android/settings/security/ScreenPinningPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/security/ScreenPinningPreferenceControllerTest.java index f63f4c16a76..b8be931f825 100644 --- a/tests/robotests/src/com/android/settings/security/ScreenPinningPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/security/ScreenPinningPreferenceControllerTest.java @@ -46,7 +46,7 @@ public class ScreenPinningPreferenceControllerTest { public void setUp() { MockitoAnnotations.initMocks(this); mContext = RuntimeEnvironment.application; - mController = new ScreenPinningPreferenceController(mContext); + mController = new ScreenPinningPreferenceController(mContext, "key"); mPreference = new Preference(mContext); mPreference.setKey(mController.getPreferenceKey()); } diff --git a/tests/robotests/src/com/android/settings/security/SimLockPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/security/SimLockPreferenceControllerTest.java index 6f9c1baf83f..6c5a418a2b3 100644 --- a/tests/robotests/src/com/android/settings/security/SimLockPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/security/SimLockPreferenceControllerTest.java @@ -77,7 +77,7 @@ public class SimLockPreferenceControllerTest { shadowApplication.setSystemService(Context.USER_SERVICE, mUserManager); shadowApplication.setSystemService(Context.TELEPHONY_SERVICE, mTelephonyManager); mContext = RuntimeEnvironment.application; - mController = new SimLockPreferenceController(mContext); + mController = new SimLockPreferenceController(mContext, "key"); mPreference = new Preference(mContext); mPreference.setKey(mController.getPreferenceKey()); when(mScreen.findPreference(mController.getPreferenceKey())).thenReturn(mPreference); diff --git a/tests/robotests/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceControllerTest.java b/tests/robotests/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceControllerTest.java index a7a3b643acd..23c55c9fbee 100644 --- a/tests/robotests/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceControllerTest.java +++ b/tests/robotests/src/com/android/settings/security/trustagent/ManageTrustAgentsPreferenceControllerTest.java @@ -64,7 +64,7 @@ public class ManageTrustAgentsPreferenceControllerTest { .thenReturn(mLockPatternUtils); when(mFeatureFactory.securityFeatureProvider.getTrustAgentManager()) .thenReturn(mTrustAgentManager); - mController = new ManageTrustAgentsPreferenceController(mContext); + mController = new ManageTrustAgentsPreferenceController(mContext, "key"); mPreference = new Preference(mContext); mPreference.setKey(mController.getPreferenceKey()); }